Uh oh!
There was an error while loading. Please reload this page.
[feature](function) upper lower support utf8 input - #49231
Conversation
Thearas
commented
Mar 19, 2025
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Mryange
commented
Mar 19, 2025
run buildall |
doris-robot
commented
Mar 19, 2025
TPC-H: Total hot run time: 32291 ms |
doris-robot
commented
Mar 19, 2025
TPC-DS: Total hot run time: 185553 ms |
doris-robot
commented
Mar 19, 2025
ClickBench: Total hot run time: 30.87 s |
hello-stephen
commented
Mar 19, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
zclllyybb
left a comment
There was a problem hiding this comment.
这个得有足够多的testcase才行,把特殊情况都覆盖到。
Mryange
commented
Mar 19, 2025
run buildall |
doris-robot
commented
Mar 19, 2025
TPC-H: Total hot run time: 32325 ms |
doris-robot
commented
Mar 19, 2025
TPC-DS: Total hot run time: 191762 ms |
doris-robot
commented
Mar 19, 2025
ClickBench: Total hot run time: 31.35 s |
PR approved by anyone and no changes requested. |
doris-robot
commented
Mar 19, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Mryange
commented
Mar 19, 2025
run cloud_p0 |
| sp.set(data, size); | ||
| icu::UnicodeString unicode_str = icu::UnicodeString::fromUTF8(sp); | ||
| unicode_str.toUpper(); | ||
| std::string output; |
There was a problem hiding this comment.
why pass output as the param, reuse the string mem.
Mryange
commented
Mar 20, 2025
run buildall |
doris-robot
commented
Mar 20, 2025
TPC-H: Total hot run time: 32554 ms |
doris-robot
commented
Mar 20, 2025
TPC-DS: Total hot run time: 192183 ms |
doris-robot
commented
Mar 20, 2025
ClickBench: Total hot run time: 31 s |
doris-robot
commented
Mar 20, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
PR approved by at least one committer and no changes requested. |
upper lower supports SQL similar to this
```
select lower('ÀÇ')
```### What problem does this PR solve? #49231
upper lower supports SQL similar to this
```
select lower('ÀÇ')
```
What problem does this PR solve?
upper lower supports SQL similar to this
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)