[fix](multi-catalog) Fix bug: "Can not create a Path from an empty string"

[suxiaogang223]

What problem does this PR solve?

Problem Summary:
In HiveMetaStoreCache, the function FileInputFormat.setInputPaths is used to set input paths. However, this function splits paths using commas, which is not the expected behavior. As a result, when partition values contain commas, it leads to incorrect path parsing and potential errors.

publicstaticvoidsetInputPaths(JobConfconf, Stringorg.apache.hadoop.shaded.com.aSeparatedPaths) {
setInputPaths(conf, StringUtils.stringToPath(
getPathStrings(org.apache.hadoop.shaded.com.aSeparatedPaths)));
}

Release note

To prevent FileInputFormat.setInputPaths from splitting paths by commas, we use another overloaded version of the method. Instead of passing a comma-separated string, we explicitly pass a Path object, ensuring that partition values containing commas are handled correctly.

publicstaticvoidsetInputPaths(JobConfconf, Path... inputPaths) {
Pathpath = newPath(conf.getWorkingDirectory(), inputPaths[0]);
StringBufferstr = newStringBuffer(StringUtils.escapeString(path.toString()));
for(inti = 1; i < inputPaths.length;i++) {
str.append(StringUtils.COMMA_STR);
path = newPath(conf.getWorkingDirectory(), inputPaths[i]);
str.append(StringUtils.escapeString(path.toString()));
}
conf.set(org.apache.hadoop.shaded.org.apache.hadoop.mapreduce.lib.input.
FileInputFormat.INPUT_DIR, str.toString());
}

Check List (For Author)

• Test

  • Regression test
  • Unit Test
  • Manual test (add detailed scripts or steps below)
  • No need to test or manual test. Explain why:
    • This is a refactor/code format and no logic has been changed.
    • Previous test can cover this change.
    • No code files have been changed.
    • Other reason

• Behavior changed:

  • No.
  • Yes.

• Does this need documentation?

  • No.
  • Yes.

Check List (For Reviewer who merge this PR)

• Confirm the release note
• Confirm test cases
• Confirm document
• Add branch pick label

[Thearas]

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?

[suxiaogang223]

run buildall

[Copilot]

Pull Request Overview

This PR addresses a bug in the HiveMetaStoreCache related to incorrect path parsing caused by using the wrong overload of FileInputFormat.setInputPaths.

• Fixes a bug by replacing a call to finalLocation.get() with finalLocation.getPath() to avoid unwanted comma splitting.
• Adds a comment to clarify the choice of the correct overload.

Files not reviewed (3)

• docker/thirdparties/docker-compose/hive/scripts/create_preinstalled_scripts/run74.hql: Language not supported
• regression-test/data/external_table_p0/hive/test_hive_partitions.out: Language not supported
• regression-test/suites/external_table_p0/hive/test_hive_partitions.groovy: Language not supported

Comments suppressed due to low confidence (1)

fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreCache.java:414

• Ensuring the use of finalLocation.getPath() is correct for avoiding comma-splitting issues. Verify that finalLocation.getPath() returns a valid Path object as expected by the FileInputFormat.setInputPaths overloaded method.

FileInputFormat.setInputPaths(jobConf, finalLocation.getPath());

[morningman]

LGTM

[github-actions]

PR approved by at least one committer and no changes requested.

[github-actions]

PR approved by anyone and no changes requested.