Uh oh!
There was an error while loading. Please reload this page.
[opt](iceberg)Optimize the batch mode conditions for Iceberg. - #49489
Merged
Conversation
Thearas
commented
Mar 26, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
wuwenchi
marked this pull request as draft
March 26, 2025 01:25
wuwenchiforce-pushed
the
opt-iceberg-batch
branch
from
March 27, 2025 05:30
57f1cec to
4ee0018Comparewuwenchi
marked this pull request as ready for review
March 27, 2025 05:30
wuwenchi
commented
Mar 27, 2025
ContributorAuthor
run buildall |
wuwenchi
commented
Mar 27, 2025
ContributorAuthor
run buildall |
wuwenchi
commented
Mar 27, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Mar 27, 2025
TPC-H: Total hot run time: 33977 ms |
doris-robot
commented
Mar 27, 2025
TPC-DS: Total hot run time: 186453 ms |
doris-robot
commented
Mar 27, 2025
ClickBench: Total hot run time: 31.3 s |
wuwenchi
commented
Mar 28, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Mar 28, 2025
TPC-H: Total hot run time: 33916 ms |
doris-robot
commented
Mar 28, 2025
TPC-DS: Total hot run time: 192534 ms |
doris-robot
commented
Mar 28, 2025
ClickBench: Total hot run time: 31.01 s |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| int cnt = 0; | ||
| while (matchingManifest.hasNext()) { | ||
| cnt += matchingManifest.next().addedFilesCount(); | ||
| if (cnt >= sessionVariable.getNumPartitionsInBatchMode()) { |
Contributor
There was a problem hiding this comment.
It is strange to use file number to compare with partition number.
wuwenchi
commented
Apr 1, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Apr 1, 2025
TPC-H: Total hot run time: 34617 ms |
doris-robot
commented
Apr 1, 2025
TPC-DS: Total hot run time: 192853 ms |
doris-robot
commented
Apr 1, 2025
ClickBench: Total hot run time: 31.49 s |
morningman
approved these changes
Apr 2, 2025
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
16 tasks
morningman pushed a commit
that referenced
this pull request
Apr 29, 2025
) ### What problem does this PR solve? related pr: #49489 Problem Summary: The manifest file needs to read the "exists" type.
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…#49489) ### What problem does this PR solve? Problem Summary: 1. Add control variables for batch mode. 2. Determine whether to use batch mode by matching the number of manifest files. Related apache#46398
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…che#50434) ### What problem does this PR solve? related pr: apache#49489 Problem Summary: The manifest file needs to read the "exists" type.
wuwenchi added a commit
to wuwenchi/doris
that referenced
this pull request
Jun 5, 2025
…#49489) Problem Summary: 1. Add control variables for batch mode. 2. Determine whether to use batch mode by matching the number of manifest files. Related apache#46398
wuwenchi added a commit
to wuwenchi/doris
that referenced
this pull request
Jun 5, 2025
…che#50434) ### What problem does this PR solve? related pr: apache#49489 Problem Summary: The manifest file needs to read the "exists" type.
morningman pushed a commit
to morningman/doris
that referenced
this pull request
Jun 20, 2025
…#49489) Problem Summary: 1. Add control variables for batch mode. 2. Determine whether to use batch mode by matching the number of manifest files. Related apache#46398
morningman pushed a commit
to morningman/doris
that referenced
this pull request
Jun 20, 2025
…che#50434) ### What problem does this PR solve? related pr: apache#49489 Problem Summary: The manifest file needs to read the "exists" type.
This was referenced Jun 20, 2025
morrySnow pushed a commit
that referenced
this pull request
Jun 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Related #46398
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)