Skip to content

branch-3.0: [fix](lzo) fix lzo decompression failed #49538 - #49633

Closed
github-actions[bot] wants to merge 3 commits into
branch-3.0from
auto-pick-49538-branch-3.0
Closed

branch-3.0: [fix](lzo) fix lzo decompression failed #49538#49633
github-actions[bot] wants to merge 3 commits into
branch-3.0from
auto-pick-49538-branch-3.0

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #49538

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

run buildall

dataroaring
dataroaring previously approved these changes Mar 30, 2025

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 30, 2025
@github-actions

Copy link
Copy Markdown
ContributorAuthor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
ContributorAuthor

PR approved by anyone and no changes requested.

@morningman
morningmanforce-pushed the auto-pick-49538-branch-3.0 branch from f3cf344 to 739481fCompareApril 22, 2025 05:05
@morningman

Copy link
Copy Markdown
Contributor

run buildall

@morningman

Copy link
Copy Markdown
Contributor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Apr 22, 2025
@morningman

Copy link
Copy Markdown
Contributor

run buildall

### What problem does this PR solve?
Problem Summary:
1.
If there is an empty block in lzo file, the decompress may fail:
`Lzo decompression failed: MalformedInputException at :13`
This is because if the next block's uncompressed size is 0,
we thought it is the last block, which is not right.
This PR fix it by removing the peek for the next block.
2.
Fix a bug that compressed size may be read wrong.
@morningman
morningmanforce-pushed the auto-pick-49538-branch-3.0 branch from c52f55c to f7ee06cCompareApril 23, 2025 05:42
@morningman
morningman deleted the auto-pick-49538-branch-3.0 branch July 8, 2026 14:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen@morningman@dataroaring