Skip to content

branch-2.1: [fix](lzo) fix lzo decompression failed #49538 - #49634

Merged
yiguolei merged 2 commits into
branch-2.1from
auto-pick-49538-branch-2.1
Apr 17, 2025
Merged

branch-2.1: [fix](lzo) fix lzo decompression failed #49538#49634
yiguolei merged 2 commits into
branch-2.1from
auto-pick-49538-branch-2.1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #49538

### What problem does this PR solve?
Problem Summary:
1.
If there is an empty block in lzo file, the decompress may fail:
`Lzo decompression failed: MalformedInputException at :13`
This is because if the next block's uncompressed size is 0,
we thought it is the last block, which is not right.
This PR fix it by removing the peek for the next block.
2.
Fix a bug that compressed size may be read wrong.
@Thearas

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Thearas

Copy link
Copy Markdown
Contributor

run buildall

@morningman

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/8) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage38.17% (10060/26353)
Line Coverage29.20% (82894/283910)
Region Coverage27.85% (42601/152943)
Branch Coverage24.48% (21588/88200)

@yiguolei
yiguolei merged commit 2aa9cb2 into branch-2.1Apr 17, 2025
@github-actions
github-actionsBot deleted the auto-pick-49538-branch-2.1 branch April 17, 2025 01:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas@morningman@hello-stephen@yiguolei@dataroaring