[fix](Nereids) fix unix_timestamp by LiBinfeng-01 · Pull Request #49686 · apache/doris

LiBinfeng-01 · 2025-03-31T06:27:34Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

when considering timezone to unix_timestamp, the boundary condition should changed

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-03-31T06:27:38Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

LiBinfeng-01 · 2025-03-31T06:27:47Z

run buildall

doris-robot · 2025-03-31T07:19:23Z

TPC-H: Total hot run time: 34199 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9bab16615a7d4a1a36624356a38bf8a917034ee6, data reload: false
------ Round 1 ----------------------------------
q1	25866	5631	5120	5120
q2	2076	299	168	168
q3	10383	1267	705	705
q4	10230	1019	530	530
q5	7552	2379	2395	2379
q6	184	163	134	134
q7	923	763	618	618
q8	9321	1313	1106	1106
q9	6865	5127	5170	5127
q10	6876	2304	1905	1905
q11	485	283	254	254
q12	353	355	225	225
q13	17775	3734	3084	3084
q14	238	218	215	215
q15	528	489	491	489
q16	642	614	602	602
q17	586	871	346	346
q18	7505	7139	7037	7037
q19	1747	972	576	576
q20	325	341	190	190
q21	3879	3343	2442	2442
q22	1104	992	947	947
Total cold run time: 115443 ms
Total hot run time: 34199 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5212	5158	5164	5158
q2	243	333	229	229
q3	2165	2686	2267	2267
q4	1434	1825	1491	1491
q5	4504	4396	4405	4396
q6	214	175	132	132
q7	1988	1976	1751	1751
q8	2621	2649	2602	2602
q9	7241	7214	7054	7054
q10	2986	3215	2729	2729
q11	600	517	509	509
q12	713	749	593	593
q13	3512	3887	3350	3350
q14	300	298	262	262
q15	531	486	483	483
q16	664	675	653	653
q17	1205	1536	1427	1427
q18	7835	7523	7385	7385
q19	862	879	952	879
q20	1990	1963	1840	1840
q21	5223	4938	4813	4813
q22	1116	1062	1022	1022
Total cold run time: 53159 ms
Total hot run time: 51025 ms

doris-robot · 2025-03-31T07:31:21Z

TPC-DS: Total hot run time: 193400 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9bab16615a7d4a1a36624356a38bf8a917034ee6, data reload: false
query1	1396	1076	1054	1054
query2	6177	1926	1952	1926
query3	11123	4702	4531	4531
query4	25502	24077	23195	23195
query5	4092	667	495	495
query6	310	209	199	199
query7	3983	489	278	278
query8	301	254	246	246
query9	8532	2605	2583	2583
query10	480	330	272	272
query11	15301	15513	14902	14902
query12	168	109	110	109
query13	1668	514	401	401
query14	9910	6269	6260	6260
query15	218	189	176	176
query16	7611	643	528	528
query17	1268	786	606	606
query18	2060	423	335	335
query19	197	213	170	170
query20	132	126	131	126
query21	212	129	111	111
query22	4523	4610	4357	4357
query23	34060	33488	33415	33415
query24	8516	2463	2435	2435
query25	512	462	398	398
query26	1231	281	145	145
query27	2908	522	334	334
query28	4358	2460	2449	2449
query29	719	569	456	456
query30	285	235	204	204
query31	937	871	799	799
query32	73	60	64	60
query33	554	378	301	301
query34	818	867	516	516
query35	806	850	759	759
query36	985	1024	909	909
query37	120	110	80	80
query38	4178	4369	4265	4265
query39	1497	1466	1444	1444
query40	204	119	115	115
query41	57	54	52	52
query42	131	113	112	112
query43	519	514	475	475
query44	1361	801	830	801
query45	192	181	169	169
query46	850	1033	636	636
query47	1815	1864	1785	1785
query48	404	450	316	316
query49	778	516	467	467
query50	706	749	425	425
query51	4284	4312	4250	4250
query52	107	106	101	101
query53	235	280	186	186
query54	511	531	443	443
query55	89	81	87	81
query56	294	301	263	263
query57	1155	1223	1139	1139
query58	256	248	252	248
query59	2776	2855	2658	2658
query60	297	285	291	285
query61	142	129	132	129
query62	778	718	671	671
query63	230	186	201	186
query64	4136	1045	688	688
query65	4409	4363	4374	4363
query66	1001	400	300	300
query67	16525	15493	15476	15476
query68	9480	857	527	527
query69	474	309	265	265
query70	1223	1126	1107	1107
query71	479	304	287	287
query72	5124	4650	4669	4650
query73	678	580	348	348
query74	9016	9254	8771	8771
query75	4348	3225	2747	2747
query76	3757	1201	775	775
query77	849	378	287	287
query78	9827	10077	9415	9415
query79	2964	811	562	562
query80	624	583	473	473
query81	457	266	219	219
query82	242	125	95	95
query83	181	196	159	159
query84	280	95	72	72
query85	753	360	315	315
query86	344	312	296	296
query87	4458	4617	4395	4395
query88	2886	2248	2279	2248
query89	426	315	276	276
query90	2209	212	217	212
query91	142	145	115	115
query92	75	64	62	62
query93	2418	1060	583	583
query94	674	430	318	318
query95	360	293	272	272
query96	496	566	276	276
query97	3088	3198	3116	3116
query98	231	209	196	196
query99	1423	1408	1312	1312
Total cold run time: 281949 ms
Total hot run time: 193400 ms

doris-robot · 2025-03-31T07:36:49Z

ClickBench: Total hot run time: 31.88 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9bab16615a7d4a1a36624356a38bf8a917034ee6, data reload: false
query1	0.03	0.04	0.03
query2	0.12	0.10	0.11
query3	0.25	0.19	0.19
query4	1.59	0.19	0.19
query5	0.59	0.59	0.59
query6	1.18	0.71	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.53
query10	0.57	0.60	0.56
query11	0.15	0.11	0.11
query12	0.15	0.11	0.11
query13	0.62	0.61	0.60
query14	2.66	2.74	2.80
query15	0.93	0.86	0.84
query16	0.38	0.37	0.38
query17	1.05	1.05	1.04
query18	0.21	0.19	0.19
query19	1.86	1.91	1.80
query20	0.02	0.01	0.01
query21	15.36	0.92	0.54
query22	0.77	1.30	0.95
query23	14.73	1.39	0.63
query24	7.21	1.02	1.35
query25	0.49	0.17	0.19
query26	0.64	0.17	0.14
query27	0.05	0.05	0.04
query28	9.95	0.91	0.44
query29	12.56	4.04	3.34
query30	0.27	0.09	0.06
query31	2.83	0.59	0.39
query32	3.23	0.54	0.47
query33	3.00	3.06	3.05
query34	15.79	5.14	4.57
query35	4.57	4.54	4.53
query36	0.67	0.51	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.6 s
Total hot run time: 31.88 s

LiBinfeng-01 · 2025-04-01T07:56:42Z

run buildall

doris-robot · 2025-04-01T08:15:48Z

TPC-H: Total hot run time: 34463 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 377978a2f71db40b8c61b3cc65bca7bcbbe094e3, data reload: false
------ Round 1 ----------------------------------
q1	26049	5147	5035	5035
q2	2070	288	187	187
q3	10384	1268	709	709
q4	10224	990	524	524
q5	7493	2423	2433	2423
q6	190	164	132	132
q7	927	763	608	608
q8	9337	1347	1126	1126
q9	6856	5078	5180	5078
q10	6817	2278	1876	1876
q11	481	286	262	262
q12	344	347	211	211
q13	17784	3731	3107	3107
q14	227	230	205	205
q15	550	504	485	485
q16	626	616	578	578
q17	598	872	390	390
q18	7608	7332	7243	7243
q19	1076	935	560	560
q20	337	346	247	247
q21	4284	3445	2473	2473
q22	1092	1032	1004	1004
Total cold run time: 115354 ms
Total hot run time: 34463 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5133	5125	5132	5125
q2	240	326	225	225
q3	2187	2652	2262	2262
q4	1419	1832	1495	1495
q5	4658	4461	4378	4378
q6	208	168	125	125
q7	1982	1904	1735	1735
q8	2602	2624	2556	2556
q9	7100	7260	7088	7088
q10	2967	3191	2724	2724
q11	575	501	494	494
q12	675	738	602	602
q13	3446	3912	3315	3315
q14	285	309	270	270
q15	538	504	495	495
q16	662	680	648	648
q17	1180	1551	1359	1359
q18	7823	7484	7491	7484
q19	826	770	885	770
q20	1979	2003	1900	1900
q21	5213	4788	4677	4677
q22	1095	1013	979	979
Total cold run time: 52793 ms
Total hot run time: 50706 ms

doris-robot · 2025-04-01T08:27:29Z

TPC-DS: Total hot run time: 188029 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 377978a2f71db40b8c61b3cc65bca7bcbbe094e3, data reload: false
query1	1003	509	492	492
query2	6569	1892	1893	1892
query3	6738	220	220	220
query4	26227	24033	23310	23310
query5	4328	676	483	483
query6	312	210	193	193
query7	4615	507	285	285
query8	299	245	246	245
query9	8617	2566	2565	2565
query10	466	338	270	270
query11	15900	15680	14941	14941
query12	172	116	113	113
query13	1663	535	415	415
query14	10178	6341	6450	6341
query15	205	198	171	171
query16	7657	673	514	514
query17	1205	738	594	594
query18	2014	413	308	308
query19	187	181	164	164
query20	122	123	118	118
query21	208	128	108	108
query22	4278	4196	4226	4196
query23	34074	33059	32972	32972
query24	8418	2416	2373	2373
query25	527	457	416	416
query26	1231	266	155	155
query27	2749	517	339	339
query28	4301	2409	2372	2372
query29	734	578	431	431
query30	299	226	198	198
query31	925	881	758	758
query32	77	66	62	62
query33	558	397	316	316
query34	802	864	527	527
query35	825	828	753	753
query36	946	970	885	885
query37	131	106	81	81
query38	4240	4213	4110	4110
query39	1453	1407	1565	1407
query40	231	120	108	108
query41	56	57	52	52
query42	120	106	105	105
query43	480	493	477	477
query44	1349	808	804	804
query45	183	178	173	173
query46	855	1032	621	621
query47	1751	1791	1704	1704
query48	382	408	304	304
query49	811	508	463	463
query50	667	694	409	409
query51	4273	4233	4179	4179
query52	114	113	103	103
query53	230	265	186	186
query54	569	597	514	514
query55	84	88	81	81
query56	305	300	313	300
query57	1177	1148	1066	1066
query58	273	267	273	267
query59	2631	2879	2637	2637
query60	337	344	313	313
query61	131	133	130	130
query62	822	742	665	665
query63	236	193	190	190
query64	4294	1028	732	732
query65	4428	4346	4285	4285
query66	1087	442	313	313
query67	15866	15732	15386	15386
query68	8075	892	535	535
query69	467	315	270	270
query70	1189	1112	1106	1106
query71	492	322	301	301
query72	5633	4735	4787	4735
query73	630	607	349	349
query74	9102	9034	8761	8761
query75	3623	3252	2733	2733
query76	3430	1204	785	785
query77	771	399	300	300
query78	10378	10468	9609	9609
query79	2241	874	596	596
query80	613	519	453	453
query81	497	263	241	241
query82	508	132	107	107
query83	273	271	259	259
query84	255	112	93	93
query85	850	457	390	390
query86	442	299	283	283
query87	4364	4652	4340	4340
query88	3823	2287	2263	2263
query89	391	316	281	281
query90	1926	223	226	223
query91	141	144	113	113
query92	76	63	59	59
query93	1950	962	588	588
query94	670	416	311	311
query95	381	309	294	294
query96	482	573	282	282
query97	3175	3240	3121	3121
query98	237	218	208	208
query99	1354	1422	1380	1380
Total cold run time: 277434 ms
Total hot run time: 188029 ms

doris-robot · 2025-04-01T08:32:51Z

ClickBench: Total hot run time: 31.29 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 377978a2f71db40b8c61b3cc65bca7bcbbe094e3, data reload: false
query1	0.04	0.04	0.03
query2	0.11	0.11	0.10
query3	0.24	0.19	0.19
query4	1.59	0.19	0.11
query5	0.55	0.55	0.55
query6	1.18	0.72	0.70
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.58	0.53	0.52
query10	0.61	0.57	0.57
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.69	2.68	2.86
query15	0.95	0.84	0.86
query16	0.40	0.38	0.37
query17	1.03	1.04	1.02
query18	0.21	0.20	0.20
query19	2.10	1.77	1.88
query20	0.02	0.01	0.01
query21	15.36	0.89	0.54
query22	0.77	1.27	0.69
query23	14.78	1.37	0.62
query24	7.10	1.82	0.94
query25	0.49	0.28	0.21
query26	0.64	0.17	0.14
query27	0.05	0.05	0.05
query28	9.52	0.87	0.44
query29	12.52	4.00	3.29
query30	0.26	0.08	0.06
query31	2.84	0.59	0.39
query32	3.22	0.55	0.47
query33	3.01	3.16	3.12
query34	16.01	5.10	4.52
query35	4.55	4.50	4.52
query36	0.66	0.51	0.48
query37	0.08	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.52 s
Total hot run time: 31.29 s

Copilot

Pull Request Overview

This PR fixes the unix_timestamp behavior in Nereids by adjusting the timezone conversion logic to correctly account for boundary conditions.

Normalize the provided LocalDateTime to UTC upfront.
Remove the redundant conversion in the duration calculation.
Ensure the boundary checks against the corrected UTC value.

Files not reviewed (1)

regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_date_arithmatic.groovy: Language not supported

Comments suppressed due to low confidence (1)

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java:577

[nitpick] Consider replacing ZoneId.of('UTC+0') (used on line 578) with ZoneOffset.UTC to clarify intent and improve readability.

dateTime = dateTime.atZone(DateUtils.getTimeZone())

LiBinfeng-01 · 2025-04-07T03:22:24Z

run buildall

github-actions · 2025-04-07T03:22:58Z

PR approved by anyone and no changes requested.

doris-robot · 2025-04-07T03:50:32Z

TPC-H: Total hot run time: 34262 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8e3569ed9c0e7309edf64071fce2246356603c99, data reload: false
------ Round 1 ----------------------------------
q1	25970	5038	5027	5027
q2	2059	276	184	184
q3	10394	1230	695	695
q4	10244	1002	543	543
q5	7560	2417	2366	2366
q6	197	167	130	130
q7	933	752	633	633
q8	9333	1286	1120	1120
q9	6937	5117	5176	5117
q10	6821	2290	1909	1909
q11	478	287	266	266
q12	351	352	219	219
q13	17756	3694	3086	3086
q14	234	225	214	214
q15	525	499	477	477
q16	632	640	567	567
q17	582	850	365	365
q18	7862	7169	7085	7085
q19	1213	968	593	593
q20	353	337	220	220
q21	4229	3429	2485	2485
q22	1094	1055	961	961
Total cold run time: 115757 ms
Total hot run time: 34262 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5143	5117	5136	5117
q2	235	331	234	234
q3	2191	2599	2302	2302
q4	1435	1900	1518	1518
q5	4578	4485	4393	4393
q6	214	164	124	124
q7	1953	1877	1686	1686
q8	2601	2628	2509	2509
q9	7212	7269	7143	7143
q10	2966	3176	2725	2725
q11	587	493	500	493
q12	671	743	588	588
q13	3532	3878	3229	3229
q14	302	315	270	270
q15	515	481	490	481
q16	630	695	674	674
q17	1151	1540	1369	1369
q18	7738	7583	7386	7386
q19	779	803	969	803
q20	1952	1954	1790	1790
q21	5118	4650	4713	4650
q22	1076	1030	999	999
Total cold run time: 52579 ms
Total hot run time: 50483 ms

doris-robot · 2025-04-07T04:02:10Z

TPC-DS: Total hot run time: 186172 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8e3569ed9c0e7309edf64071fce2246356603c99, data reload: false
query1	1025	486	480	480
query2	6551	1951	1968	1951
query3	6760	223	230	223
query4	26293	26158	22734	22734
query5	4376	659	472	472
query6	293	214	201	201
query7	4627	499	286	286
query8	303	248	244	244
query9	8632	2608	2610	2608
query10	471	333	274	274
query11	15701	15370	14722	14722
query12	178	120	106	106
query13	1671	522	407	407
query14	10577	6350	6412	6350
query15	207	184	170	170
query16	7646	663	484	484
query17	1371	752	622	622
query18	2022	407	305	305
query19	195	196	171	171
query20	120	123	120	120
query21	217	128	111	111
query22	4224	4369	4201	4201
query23	33803	32984	32975	32975
query24	8133	2412	2408	2408
query25	533	450	397	397
query26	1235	263	148	148
query27	2719	517	339	339
query28	4363	2421	2388	2388
query29	726	543	429	429
query30	292	222	207	207
query31	936	852	790	790
query32	70	67	62	62
query33	563	372	312	312
query34	779	862	509	509
query35	808	801	731	731
query36	936	1011	883	883
query37	115	101	79	79
query38	4280	4195	4042	4042
query39	1432	1381	1375	1375
query40	212	119	107	107
query41	59	55	54	54
query42	121	106	107	106
query43	498	519	484	484
query44	1305	808	801	801
query45	179	171	176	171
query46	841	1015	637	637
query47	1739	1780	1697	1697
query48	377	412	302	302
query49	780	509	431	431
query50	646	683	398	398
query51	4179	4200	4134	4134
query52	117	113	98	98
query53	226	254	188	188
query54	573	619	514	514
query55	84	87	86	86
query56	305	299	312	299
query57	1133	1144	1063	1063
query58	269	279	258	258
query59	2765	2737	2606	2606
query60	338	318	308	308
query61	133	129	146	129
query62	780	747	638	638
query63	231	194	202	194
query64	4249	1021	760	760
query65	4312	4226	4229	4226
query66	1062	414	309	309
query67	15898	15547	15369	15369
query68	8786	889	517	517
query69	455	294	256	256
query70	1204	1107	1083	1083
query71	476	330	305	305
query72	5285	4658	4545	4545
query73	682	554	393	393
query74	9144	9368	8646	8646
query75	4164	3227	2701	2701
query76	3713	1199	800	800
query77	785	411	296	296
query78	10034	10187	9243	9243
query79	2109	820	583	583
query80	625	510	435	435
query81	484	258	224	224
query82	488	124	100	100
query83	294	252	237	237
query84	296	114	86	86
query85	821	353	315	315
query86	333	295	294	294
query87	4445	4513	4385	4385
query88	2951	2254	2268	2254
query89	388	315	289	289
query90	1925	264	221	221
query91	141	141	113	113
query92	76	61	54	54
query93	1137	963	611	611
query94	677	381	318	318
query95	381	307	292	292
query96	488	549	279	279
query97	3186	3242	3111	3111
query98	224	210	208	208
query99	1434	1371	1295	1295
Total cold run time: 276225 ms
Total hot run time: 186172 ms

doris-robot · 2025-04-07T04:07:29Z

ClickBench: Total hot run time: 30.76 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8e3569ed9c0e7309edf64071fce2246356603c99, data reload: false
query1	0.04	0.04	0.03
query2	0.14	0.10	0.11
query3	0.25	0.19	0.19
query4	1.60	0.19	0.11
query5	0.57	0.55	0.55
query6	1.17	0.71	0.71
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.53	0.51
query10	0.61	0.57	0.57
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.63	0.60	0.60
query14	2.66	2.73	2.80
query15	0.92	0.85	0.83
query16	0.39	0.39	0.38
query17	1.01	1.02	1.03
query18	0.21	0.19	0.20
query19	1.97	1.86	1.84
query20	0.01	0.01	0.02
query21	15.36	0.93	0.57
query22	0.76	1.13	0.62
query23	15.05	1.38	0.59
query24	8.08	0.75	0.35
query25	0.47	0.16	0.13
query26	0.71	0.18	0.13
query27	0.05	0.05	0.05
query28	8.56	0.87	0.45
query29	12.60	4.02	3.33
query30	0.24	0.09	0.06
query31	2.82	0.60	0.38
query32	3.24	0.55	0.48
query33	2.99	3.08	3.12
query34	15.87	5.16	4.56
query35	4.55	4.57	4.54
query36	0.70	0.50	0.48
query37	0.08	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.67 s
Total hot run time: 30.76 s

LiBinfeng-01 · 2025-04-07T12:26:17Z

run p0

LiBinfeng-01 · 2025-04-07T12:26:24Z

run cloud_p0

github-actions · 2025-04-11T08:03:42Z

PR approved by at least one committer and no changes requested.

zclllyybb

LGTM

…ary condition should changed (apache#49686)

…ary condition should changed (#49686)

…, the boundary condition should changed (#49686) (#50669) backport: #49686 Co-authored-by: LiBinfeng <libinfeng@selectdb.com>

Cherry-picked from #49686 Co-authored-by: LiBinfeng <libinfeng@selectdb.com>

…ary condition should changed (apache#49686)

LiBinfeng-01 force-pushed the fix_fromunixtimestamp branch from 9bab166 to 377978aCompare April 1, 2025 07:56

morrySnow requested a review from Copilot April 3, 2025 09:59

morrySnow added p0_w dev/2.1.x dev/3.0.x labels Apr 3, 2025

CopilotAI reviewed Apr 3, 2025
View reviewed changes

morrySnow previously approved these changes Apr 3, 2025
View reviewed changes

zclllyybb approved these changes Apr 3, 2025
View reviewed changes

fix unit_timestamp
8e3569e

LiBinfeng-01 dismissed morrySnow’s stale review via 8e3569eApril 7, 2025 03:22

LiBinfeng-01 force-pushed the fix_fromunixtimestamp branch from 377978a to 8e3569eCompare April 7, 2025 03:22

github-actionsBot added the reviewed label Apr 7, 2025

LiBinfeng-01 requested a review from zclllyybb April 11, 2025 07:28

morrySnow approved these changes Apr 11, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 11, 2025

zclllyybb approved these changes Apr 11, 2025
View reviewed changes

morrySnow merged commit 72fea99 into apache:masterApr 14, 2025

github-actionsBot added dev/3.0.x-conflict dev/2.1.x-conflict labels Apr 14, 2025

seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 17, 2025
[fix](Nereids) when considering timezone to unix_timestamp, the bound…
2f3d406
…ary condition should changed (apache#49686)

shuke987 removed the dev/2.1.x label May 7, 2025

morrySnow added 2.1.0-conflict dev/2.1.x and removed 2.1.0-conflict dev/2.1.x-conflict labels May 7, 2025

github-actionsBot added the dev/2.1.x-conflict label May 7, 2025

Jibing-Li pushed a commit to Jibing-Li/incubator-doris that referenced this pull request May 7, 2025
[fix](Nereids) when considering timezone to unix_timestamp, the bound…
aa7c1dd
…ary condition should changed (apache#49686)

Jibing-Li mentioned this pull request May 7, 2025
branch-2.1:[fix](Nereids) when considering timezone to unix_timestamp, the boundary condition should changed (#49686) #50669
Merged

Jibing-Li added dev/3.0.x and removed dev/3.0.x dev/3.0.x-conflict labels May 7, 2025

github-actionsBot pushed a commit that referenced this pull request May 7, 2025
[fix](Nereids) when considering timezone to unix_timestamp, the bound…
bc3f231
…ary condition should changed (#49686)

github-actionsBot mentioned this pull request May 7, 2025
branch-3.0: [fix](Nereids) fix unix_timestamp #49686 #50670
Merged

yiguolei pushed a commit that referenced this pull request May 8, 2025
branch-2.1:[fix](Nereids) when considering timezone to unix_timestamp…
c637667
…, the boundary condition should changed (#49686) (#50669) backport: #49686 Co-authored-by: LiBinfeng <libinfeng@selectdb.com>

yiguolei added dev/2.1.10-merged and removed dev/2.1.x dev/2.1.x-conflict labels May 8, 2025

Jibing-Li pushed a commit that referenced this pull request May 8, 2025
branch-3.0: [fix](Nereids) fix unix_timestamp#49686(#50670)
e9d14da
Cherry-picked from #49686 Co-authored-by: LiBinfeng <libinfeng@selectdb.com>

Jibing-Li added dev/3.0.6-merged and removed dev/3.0.x labels May 8, 2025

yiguolei mentioned this pull request May 13, 2025
2.1.10 Release Note #50853
Closed

koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
[fix](Nereids) when considering timezone to unix_timestamp, the bound…
16b59e4
…ary condition should changed (apache#49686)

Uh oh!

Conversation

LiBinfeng-01 commented Mar 31, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Mar 31, 2025

Uh oh!

LiBinfeng-01 commented Mar 31, 2025

Uh oh!

doris-robot commented Mar 31, 2025

Uh oh!

doris-robot commented Mar 31, 2025

Uh oh!

doris-robot commented Mar 31, 2025

Uh oh!

LiBinfeng-01 commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

LiBinfeng-01 commented Apr 7, 2025

Uh oh!

github-actionsBot commented Apr 7, 2025

Uh oh!

doris-robot commented Apr 7, 2025

Uh oh!

doris-robot commented Apr 7, 2025

Uh oh!

doris-robot commented Apr 7, 2025

Uh oh!

LiBinfeng-01 commented Apr 7, 2025

Uh oh!

LiBinfeng-01 commented Apr 7, 2025

Uh oh!

github-actionsBot commented Apr 11, 2025

Uh oh!

zclllyybb left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

LiBinfeng-01 commented Mar 31, 2025•
edited
Loading