Skip to content

branch-3.0: [fix](paimon) Covert Paimon DeletionFile Path to StoragePath in fe #49645 - #49750

Merged
dataroaring merged 1 commit into
branch-3.0from
auto-pick-49645-branch-3.0
Apr 22, 2025
Merged

branch-3.0: [fix](paimon) Covert Paimon DeletionFile Path to StoragePath in fe #49645#49750
dataroaring merged 1 commit into
branch-3.0from
auto-pick-49645-branch-3.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Cherry-picked from #49645

@suxiaogang223Your Name
[fix](paimon) Covert Paimon DeletionFile Path to StoragePath in fe (#…
52a6bdd
…49645)
### What problem does this PR solve?
Related PR: #34743 Problem Summary:
The problem occurs because FE passes the deletion file URL with 'oss://'
prefix to BE, which cannot recognize this URL format. The solution is to
convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode
using LocationPath class to ensure BE can properly read the file.
@Thearas

Thearas commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaringdataroaring reopened this Apr 2, 2025
@Thearas

Thearas commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

run buildall

dataroaring
dataroaring approved these changes Apr 7, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 7, 2025
@github-actions

github-actionsBot commented Apr 7, 2025

Copy link
Copy Markdown
ContributorAuthor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Apr 7, 2025

Copy link
Copy Markdown
ContributorAuthor

PR approved by anyone and no changes requested.

@dataroaring
dataroaring merged commit c2976b5 into branch-3.0Apr 22, 2025
@github-actions
github-actionsBot deleted the auto-pick-49645-branch-3.0 branch April 22, 2025 03:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thearas@dataroaring@suxiaogang223