[Bug][function] fix the string cast jsonb cause null map have not init value by HappenLee · Pull Request #49810 · apache/doris

HappenLee · 2025-04-04T18:35:09Z

What problem does this PR solve?

Problem Summary:

if null map value not init, the value can be random cause the wired bug

col_null_map_to = ColumnUInt8::create(size, 0);

By the way: maybe we should reconsider the api column create force the init value, but may cause the some performance problem

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

…t value

Thearas · 2025-04-04T18:35:15Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

HappenLee · 2025-04-04T18:35:20Z

run buildall

doris-robot · 2025-04-04T18:55:36Z

TPC-H: Total hot run time: 34308 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a71bb35b8dc4106e0fceee7f6de71ebcbf2d93d4, data reload: false
------ Round 1 ----------------------------------
q1	25916	5483	5051	5051
q2	2081	281	195	195
q3	10419	1252	700	700
q4	10260	1048	530	530
q5	8682	2521	2356	2356
q6	190	164	129	129
q7	926	743	608	608
q8	9310	1313	1046	1046
q9	6829	5151	5197	5151
q10	6811	2329	1894	1894
q11	471	280	267	267
q12	350	355	226	226
q13	17777	3672	3086	3086
q14	238	226	215	215
q15	536	500	479	479
q16	647	602	591	591
q17	595	870	367	367
q18	7872	7357	7168	7168
q19	1552	1109	572	572
q20	328	337	227	227
q21	4009	3356	2471	2471
q22	1071	1036	979	979
Total cold run time: 116870 ms
Total hot run time: 34308 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5156	5042	5123	5042
q2	254	328	230	230
q3	2140	2638	2261	2261
q4	1405	1948	1543	1543
q5	4571	4436	4376	4376
q6	203	167	124	124
q7	1943	1857	1762	1762
q8	2606	2565	2494	2494
q9	7176	7202	7214	7202
q10	2976	3222	2732	2732
q11	575	509	489	489
q12	689	792	610	610
q13	3520	3906	3255	3255
q14	277	296	263	263
q15	526	475	464	464
q16	642	696	650	650
q17	1144	1479	1378	1378
q18	7842	7581	7509	7509
q19	818	858	826	826
q20	1975	1961	1825	1825
q21	5170	4745	4634	4634
q22	1080	1025	1004	1004
Total cold run time: 52688 ms
Total hot run time: 50673 ms

doris-robot · 2025-04-04T19:07:12Z

TPC-DS: Total hot run time: 186990 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a71bb35b8dc4106e0fceee7f6de71ebcbf2d93d4, data reload: false
query1	1013	463	468	463
query2	6558	1912	1935	1912
query3	6753	225	220	220
query4	26586	23640	23487	23487
query5	4285	609	452	452
query6	297	197	197	197
query7	4617	484	282	282
query8	283	230	244	230
query9	8646	2618	2611	2611
query10	505	327	269	269
query11	15314	15023	15214	15023
query12	176	111	108	108
query13	1656	518	397	397
query14	9463	6143	6216	6143
query15	208	191	164	164
query16	7253	611	481	481
query17	1200	748	570	570
query18	1965	397	295	295
query19	191	181	153	153
query20	123	118	118	118
query21	213	124	103	103
query22	4319	4403	4501	4403
query23	33856	33044	33084	33044
query24	8454	2358	2357	2357
query25	540	457	394	394
query26	1230	273	150	150
query27	2761	504	334	334
query28	4373	2407	2409	2407
query29	786	564	439	439
query30	286	218	193	193
query31	925	821	754	754
query32	74	63	62	62
query33	555	370	310	310
query34	787	871	514	514
query35	808	833	749	749
query36	931	992	874	874
query37	121	97	114	97
query38	4189	4090	3988	3988
query39	1449	1414	1392	1392
query40	215	118	107	107
query41	56	55	54	54
query42	115	103	105	103
query43	487	509	460	460
query44	1299	801	817	801
query45	172	172	168	168
query46	829	1032	632	632
query47	1773	1824	1728	1728
query48	378	411	311	311
query49	784	515	424	424
query50	637	670	406	406
query51	4130	4129	4053	4053
query52	104	104	95	95
query53	224	250	181	181
query54	572	581	506	506
query55	86	84	81	81
query56	305	298	325	298
query57	1138	1172	1065	1065
query58	269	253	260	253
query59	2627	2719	2626	2626
query60	341	314	308	308
query61	133	132	128	128
query62	793	733	667	667
query63	231	196	192	192
query64	4516	1015	683	683
query65	4253	4193	4265	4193
query66	1145	413	308	308
query67	15754	15694	15328	15328
query68	8109	828	525	525
query69	461	299	269	269
query70	1100	1112	1021	1021
query71	457	328	296	296
query72	5513	4825	4920	4825
query73	745	685	367	367
query74	8855	8889	8723	8723
query75	3852	3223	2702	2702
query76	3658	1193	755	755
query77	784	380	303	303
query78	9966	10155	9332	9332
query79	1969	817	561	561
query80	579	537	450	450
query81	473	258	224	224
query82	436	124	97	97
query83	258	322	235	235
query84	244	107	89	89
query85	785	349	309	309
query86	330	287	290	287
query87	4350	4375	4298	4298
query88	3387	2262	2268	2262
query89	395	307	287	287
query90	1964	220	220	220
query91	141	169	127	127
query92	76	61	61	61
query93	1200	951	580	580
query94	696	426	310	310
query95	378	287	294	287
query96	491	558	283	283
query97	3090	3249	3135	3135
query98	234	218	199	199
query99	1573	1370	1273	1273
Total cold run time: 273664 ms
Total hot run time: 186990 ms

doris-robot · 2025-04-04T19:12:31Z

ClickBench: Total hot run time: 31.16 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a71bb35b8dc4106e0fceee7f6de71ebcbf2d93d4, data reload: false
query1	0.04	0.04	0.03
query2	0.12	0.11	0.11
query3	0.24	0.19	0.19
query4	1.60	0.19	0.20
query5	0.59	0.57	0.63
query6	1.18	0.72	0.71
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.57	0.52	0.52
query10	0.57	0.58	0.57
query11	0.16	0.10	0.10
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	2.70	2.81	2.69
query15	0.94	0.84	0.85
query16	0.40	0.41	0.39
query17	0.99	1.04	1.04
query18	0.20	0.20	0.19
query19	1.93	1.94	1.82
query20	0.02	0.00	0.01
query21	15.38	0.87	0.54
query22	0.74	1.25	0.73
query23	14.79	1.38	0.65
query24	8.19	0.62	0.91
query25	0.49	0.34	0.15
query26	0.74	0.15	0.14
query27	0.05	0.05	0.05
query28	9.39	0.84	0.43
query29	12.55	3.95	3.29
query30	0.25	0.08	0.07
query31	2.82	0.60	0.38
query32	3.23	0.53	0.47
query33	2.97	3.11	3.08
query34	15.75	5.12	4.51
query35	4.57	4.56	4.59
query36	0.67	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.14
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 106.11 s
Total hot run time: 31.16 s

doris-robot · 2025-04-04T21:10:32Z

BE UT Coverage Report

Increment line coverage 50.00% (3/6) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.23% (13997/26799)
Line Coverage	40.97% (120590/294364)
Region Coverage	39.68% (61334/154566)
Branch Coverage	34.30% (30618/89262)

eldenmoon

LGTM

github-actions · 2025-04-05T03:44:53Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-04-05T03:44:55Z

PR approved by anyone and no changes requested.

…t value (#49810) ### What problem does this PR solve? Problem Summary: if null map value not init, the value can be random cause the wired bug ``` col_null_map_to = ColumnUInt8::create(size, 0); ``` By the way: maybe we should reconsider the api column create force the init value, but may cause the some performance problem

…have not init value #49810 (#49817) Cherry-picked from #49810 Co-authored-by: HappenLee <happenlee@selectdb.com>

…have not init value #49810 (#49816) Cherry-picked from #49810 Co-authored-by: HappenLee <happenlee@selectdb.com>

…t value (apache#49810) ### What problem does this PR solve? Problem Summary: if null map value not init, the value can be random cause the wired bug ``` col_null_map_to = ColumnUInt8::create(size, 0); ``` By the way: maybe we should reconsider the api column create force the init value, but may cause the some performance problem

[Bug][function] fix the string cast jsonb cause null map have not ini…
a71bb35
…t value

HappenLee added dev/2.1.x dev/3.0.x dev/2.0.x kind/fix Categorizes issue or PR as related to a bug. labels Apr 4, 2025

eldenmoon approved these changes Apr 5, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 5, 2025

github-actionsBot added the reviewed label Apr 5, 2025

yiguolei approved these changes Apr 5, 2025
View reviewed changes

yiguolei merged commit 3640f6c into apache:masterApr 5, 2025

yiguolei added the p0_c label Apr 5, 2025

github-actionsBot mentioned this pull request Apr 5, 2025
branch-3.0: [Bug][function] fix the string cast jsonb cause null map have not init value #49810 #49816
Merged

github-actionsBot mentioned this pull request Apr 5, 2025
branch-2.1: [Bug][function] fix the string cast jsonb cause null map have not init value #49810 #49817
Merged

yiguolei added the usercase Important user case type label label Apr 5, 2025

yiguolei pushed a commit that referenced this pull request Apr 6, 2025
branch-2.1: [Bug][function] fix the string cast jsonb cause null map …
0ea87fb
…have not init value #49810 (#49817) Cherry-picked from #49810 Co-authored-by: HappenLee <happenlee@selectdb.com>

yiguolei added dev/2.1.10-merged and removed dev/2.1.x labels Apr 6, 2025

dataroaring pushed a commit that referenced this pull request Apr 7, 2025
branch-3.0: [Bug][function] fix the string cast jsonb cause null map …
9ad7d6d
…have not init value #49810 (#49816) Cherry-picked from #49810 Co-authored-by: HappenLee <happenlee@selectdb.com>

dataroaring added dev/3.0.5-merged and removed dev/3.0.x labels Apr 7, 2025

gavinchou mentioned this pull request Apr 23, 2025
Release Notes 3.0.5 #50333
Closed

yiguolei mentioned this pull request May 13, 2025
2.1.10 Release Note #50853
Closed

morrySnow removed the dev/2.0.x label Jun 22, 2026

Navigation Menu

Uh oh!

[Bug][function] fix the string cast jsonb cause null map have not init value - #49810

[Bug][function] fix the string cast jsonb cause null map have not init value#49810
yiguolei merged 1 commit into
apache:masterfrom
HappenLee:docs

HappenLee commented Apr 4, 2025

Uh oh!

Thearas commented Apr 4, 2025

Uh oh!

HappenLee commented Apr 4, 2025

Uh oh!

doris-robot commented Apr 4, 2025

Uh oh!

doris-robot commented Apr 4, 2025

Uh oh!

doris-robot commented Apr 4, 2025

Uh oh!

doris-robot commented Apr 4, 2025

Uh oh!

eldenmoon left a comment

Uh oh!

github-actionsBot commented Apr 5, 2025

Uh oh!

github-actionsBot commented Apr 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

HappenLee commented Apr 4, 2025

What problem does this PR solve?

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Apr 4, 2025

Uh oh!

HappenLee commented Apr 4, 2025

Uh oh!

doris-robot commented Apr 4, 2025

Uh oh!

doris-robot commented Apr 4, 2025

Uh oh!

doris-robot commented Apr 4, 2025

Uh oh!

doris-robot commented Apr 4, 2025

BE UT Coverage Report

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 5, 2025

Uh oh!

github-actionsBot commented Apr 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants