Uh oh!
There was an error while loading. Please reload this page.
[fix](nereids) fix create view use null literal - #49881
Merged
Merged
Conversation
hello-stephen
commented
Apr 8, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
feiniaofeiafei
marked this pull request as draft
April 8, 2025 11:47
feiniaofeiafeiforce-pushed
the
fix_create_view_nulltype
branch
from
April 10, 2025 05:56
09fd48b to
e04340bComparefeiniaofeiafei
commented
Apr 10, 2025
CollaboratorAuthor
run buildall |
feiniaofeiafei
commented
Apr 10, 2025
CollaboratorAuthor
run performance |
feiniaofeiafei
marked this pull request as ready for review
April 10, 2025 08:46
doris-robot
commented
Apr 10, 2025
TPC-H: Total hot run time: 35033 ms |
doris-robot
commented
Apr 10, 2025
TPC-DS: Total hot run time: 193450 ms |
doris-robot
commented
Apr 10, 2025
ClickBench: Total hot run time: 31.45 s |
924060929
previously approved these changes
Apr 14, 2025
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
feiniaofeiafeiforce-pushed
the
fix_create_view_nulltype
branch
from
April 15, 2025 12:20
e04340b to
e044939Comparefeiniaofeiafei
commented
Apr 15, 2025
CollaboratorAuthor
run buildall |
doris-robot
commented
Apr 15, 2025
TPC-H: Total hot run time: 34053 ms |
doris-robot
commented
Apr 15, 2025
TPC-DS: Total hot run time: 194315 ms |
doris-robot
commented
Apr 15, 2025
ClickBench: Total hot run time: 31.39 s |
feiniaofeiafei
commented
Apr 17, 2025
CollaboratorAuthor
run buildall |
doris-robot
commented
Apr 17, 2025
TPC-H: Total hot run time: 33847 ms |
doris-robot
commented
Apr 17, 2025
TPC-DS: Total hot run time: 192182 ms |
doris-robot
commented
Apr 17, 2025
ClickBench: Total hot run time: 29.17 s |
feiniaofeiafeiforce-pushed
the
fix_create_view_nulltype
branch
from
May 14, 2025 10:33
6e174d4 to
aa5f827Comparefeiniaofeiafei
commented
May 14, 2025
CollaboratorAuthor
run buildall |
doris-robot
commented
May 14, 2025
TPC-H: Total hot run time: 33896 ms |
doris-robot
commented
May 14, 2025
TPC-DS: Total hot run time: 187244 ms |
doris-robot
commented
May 14, 2025
ClickBench: Total hot run time: 29.36 s |
feiniaofeiafeiforce-pushed
the
fix_create_view_nulltype
branch
from
May 16, 2025 03:26
174e92c to
f406a93Comparefeiniaofeiafei
commented
May 16, 2025
CollaboratorAuthor
run buildall |
doris-robot
commented
May 16, 2025
TPC-H: Total hot run time: 33867 ms |
doris-robot
commented
May 16, 2025
TPC-DS: Total hot run time: 192742 ms |
doris-robot
commented
May 16, 2025
ClickBench: Total hot run time: 28.67 s |
feiniaofeiafei
commented
May 16, 2025
CollaboratorAuthor
run cloud_p0 |
feiniaofeiafei
commented
May 16, 2025
CollaboratorAuthor
run external |
zy-kkk
approved these changes
May 16, 2025
Contributor
PR approved by at least one committer and no changes requested. |
morrySnow
approved these changes
May 16, 2025
github-actionsBot
pushed a commit
that referenced
this pull request
May 19, 2025
Related PR: #32743 Problem Summary: problem before this pr: 1. null type problem the type of NULL is null_type, this will lead to error when select this view through jdbc catalog. ```sql mysql> CREATE VIEW test_null COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.02 sec) mysql> desc test_null; +-------+-----------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+-----------+------+-------+---------+-------+ | col1 | null_type | Yes | false | NULL | | +-------+-----------+------+-------+---------+-------+ 1 row in set (0.00 sec) ``` after this pr, the type is changed to tinyint. mysql> CREATE VIEW test_null2 COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.03 sec) ```sql mysql> desc test_null2; +-------+---------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-------+---------+-------+ | col1 | tinyint | Yes | false | NULL | | +-------+---------+------+-------+---------+-------+ 1 row in set (0.01 sec) ``` 2. nullable problem Modify the internal elements of nested types returned by JDBC to always be null, in order to maintain consistency with Doris' internal implementation ### Release note
github-actionsBot
pushed a commit
that referenced
this pull request
May 19, 2025
Related PR: #32743 Problem Summary: problem before this pr: 1. null type problem the type of NULL is null_type, this will lead to error when select this view through jdbc catalog. ```sql mysql> CREATE VIEW test_null COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.02 sec) mysql> desc test_null; +-------+-----------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+-----------+------+-------+---------+-------+ | col1 | null_type | Yes | false | NULL | | +-------+-----------+------+-------+---------+-------+ 1 row in set (0.00 sec) ``` after this pr, the type is changed to tinyint. mysql> CREATE VIEW test_null2 COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.03 sec) ```sql mysql> desc test_null2; +-------+---------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-------+---------+-------+ | col1 | tinyint | Yes | false | NULL | | +-------+---------+------+-------+---------+-------+ 1 row in set (0.01 sec) ``` 2. nullable problem Modify the internal elements of nested types returned by JDBC to always be null, in order to maintain consistency with Doris' internal implementation ### Release note
This was referenced May 19, 2025
yiguolei pushed a commit
that referenced
this pull request
May 19, 2025
dataroaring pushed a commit
that referenced
this pull request
May 24, 2025
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
Related PR: apache#32743 Problem Summary: problem before this pr: 1. null type problem the type of NULL is null_type, this will lead to error when select this view through jdbc catalog. ```sql mysql> CREATE VIEW test_null COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.02 sec) mysql> desc test_null; +-------+-----------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+-----------+------+-------+---------+-------+ | col1 | null_type | Yes | false | NULL | | +-------+-----------+------+-------+---------+-------+ 1 row in set (0.00 sec) ``` after this pr, the type is changed to tinyint. mysql> CREATE VIEW test_null2 COMMENT '测试null类型' AS SELECT NULL AS `col1`; Query OK, 0 rows affected (0.03 sec) ```sql mysql> desc test_null2; +-------+---------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-------+---------+-------+ | col1 | tinyint | Yes | false | NULL | | +-------+---------+------+-------+---------+-------+ 1 row in set (0.01 sec) ``` 2. nullable problem Modify the internal elements of nested types returned by JDBC to always be null, in order to maintain consistency with Doris' internal implementation ### Release note
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #32743
Problem Summary:
problem before this pr:
the type of NULL is null_type, this will lead to error when select this view through jdbc catalog.
after this pr, the type is changed to tinyint.
mysql> CREATE VIEW test_null2 COMMENT '测试null类型' AS SELECT NULL AS
col1;Query OK, 0 rows affected (0.03 sec)
Modify the internal elements of nested types returned by JDBC to always be null, in order to maintain consistency with Doris' internal implementation
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)