Skip to content

[Bug] fix finished load jobs cost too much heap - #4993

Merged
EmmyMiao87 merged 2 commits into
apache:masterfrom
qidaye:finished_load_job_cost_too_much_heap
Dec 2, 2020
Merged

[Bug] fix finished load jobs cost too much heap #4993
EmmyMiao87 merged 2 commits into
apache:masterfrom
qidaye:finished_load_job_cost_too_much_heap

Conversation

@qidaye

@qidayeqidaye commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

Proposed changes

Since the plan is retained in the task, if the task is not cleaned up, the memory usage will be too large caused Memory leak or OOM.
When load job finished, there is no need to hold the tasks which are the biggest memory consumers.
Fixed#4992

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

@EmmyMiao87EmmyMiao87 added area/load Issues or PRs related to all kinds of load Memory Leak labels Dec 1, 2020
Comment threadfe/fe-core/src/test/java/org/apache/doris/load/loadv2/LoadJobTest.java Outdated

@EmmyMiao87EmmyMiao87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87EmmyMiao87 added the approved Indicates a PR has been approved by one committer. label Dec 1, 2020
@EmmyMiao87
EmmyMiao87 merged commit b4c1eab into apache:masterDec 2, 2020
@qidaye
qidaye deleted the finished_load_job_cost_too_much_heap branch December 3, 2020 02:12
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
levy5307 pushed a commit to levy5307/incubator-doris that referenced this pull request Nov 14, 2022
Since the plan is retained in the task, if the task is not cleaned up, the memory usage will be too large caused Memory leak or OOM.
When load job finished, there is no need to hold the tasks which are the biggest memory consumers.
Fixedapache#4992
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/loadIssues or PRs related to all kinds of loadMemory Leak

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] finished load jobs cost too much heap memory

2 participants

@qidaye@EmmyMiao87