[fix](iceberg) Fix the failure of creating a table in OBS by wuwenchi · Pull Request #49983 · apache/doris

wuwenchi · 2025-04-11T03:52:42Z

What problem does this PR solve?

Problem Summary:

When use JDK17 with obs, if drop an iceberg table, an error will occur:

Caused by: java.lang.IllegalAccessException: class com.obs.services.internal.xml.OBSXMLBuilder cannot access class com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl (in module java.xml) because module java.xml does not export com.sun.org.apache.xerces.internal.jaxp to unnamed module @50ad3bc1

so, we should add JVM config: --add-opens java.xml/com.sun.org.apache.xerces.internal.jaxp=ALL-UNNAMED

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-04-11T03:52:46Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

wuwenchi · 2025-04-11T03:52:52Z

run buildall

github-actions · 2025-04-11T04:23:57Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-04-11T04:23:59Z

PR approved by anyone and no changes requested.

doris-robot · 2025-04-11T04:41:53Z

TPC-H: Total hot run time: 33973 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a9f018c9771414ff7154cc72abb3c04a7132d821, data reload: false
------ Round 1 ----------------------------------
q1	25778	5021	4984	4984
q2	2062	297	186	186
q3	10375	1221	690	690
q4	10218	1043	538	538
q5	7518	2375	2318	2318
q6	193	159	131	131
q7	911	748	621	621
q8	9325	1272	1051	1051
q9	6883	5076	5061	5061
q10	6927	2318	1888	1888
q11	483	284	256	256
q12	344	357	219	219
q13	17789	3682	3092	3092
q14	216	224	205	205
q15	541	493	483	483
q16	617	608	575	575
q17	592	852	370	370
q18	7505	7125	7117	7117
q19	1628	944	539	539
q20	326	324	229	229
q21	3948	3422	2455	2455
q22	1067	1020	965	965
Total cold run time: 115246 ms
Total hot run time: 33973 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5171	5101	5069	5069
q2	242	319	229	229
q3	2155	2633	2272	2272
q4	1439	1821	1378	1378
q5	4453	4415	4406	4406
q6	219	168	128	128
q7	1968	1913	1755	1755
q8	2578	2482	2490	2482
q9	7283	7313	7213	7213
q10	3062	3209	2773	2773
q11	596	516	509	509
q12	725	788	626	626
q13	3675	3934	3321	3321
q14	292	306	274	274
q15	511	469	481	469
q16	632	684	650	650
q17	1142	1517	1408	1408
q18	7821	7503	7435	7435
q19	834	785	810	785
q20	1916	1966	1835	1835
q21	5247	4935	4722	4722
q22	1124	1041	1022	1022
Total cold run time: 53085 ms
Total hot run time: 50761 ms

doris-robot · 2025-04-11T04:54:13Z

TPC-DS: Total hot run time: 193589 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a9f018c9771414ff7154cc72abb3c04a7132d821, data reload: false
query1	1422	1063	1031	1031
query2	6280	1945	1883	1883
query3	10974	4470	4507	4470
query4	54680	25321	23266	23266
query5	5182	520	452	452
query6	353	201	203	201
query7	4955	501	293	293
query8	342	260	232	232
query9	6239	2557	2575	2557
query10	442	299	263	263
query11	15237	15155	14791	14791
query12	153	118	103	103
query13	1096	503	383	383
query14	10094	6227	6252	6227
query15	202	185	179	179
query16	7063	689	527	527
query17	1133	743	604	604
query18	1571	421	332	332
query19	210	211	196	196
query20	129	124	114	114
query21	207	134	120	120
query22	4391	4530	4419	4419
query23	34479	33605	33619	33605
query24	6763	2474	2424	2424
query25	506	533	405	405
query26	701	279	151	151
query27	2368	513	334	334
query28	3030	2450	2417	2417
query29	595	557	456	456
query30	273	222	196	196
query31	853	858	754	754
query32	74	63	62	62
query33	456	389	309	309
query34	784	876	543	543
query35	820	825	774	774
query36	933	968	909	909
query37	122	100	78	78
query38	4283	4235	4171	4171
query39	1512	1430	1465	1430
query40	219	122	111	111
query41	54	50	50	50
query42	123	104	103	103
query43	489	506	495	495
query44	1381	845	820	820
query45	188	176	169	169
query46	858	1081	653	653
query47	1920	1864	1817	1817
query48	397	428	309	309
query49	732	516	444	444
query50	708	723	412	412
query51	4257	4319	4254	4254
query52	117	124	104	104
query53	243	271	188	188
query54	596	607	535	535
query55	87	84	83	83
query56	324	326	294	294
query57	1159	1214	1133	1133
query58	267	266	268	266
query59	2753	2818	2703	2703
query60	345	330	305	305
query61	135	136	155	136
query62	724	744	695	695
query63	233	189	186	186
query64	1724	1071	775	775
query65	4433	4268	4283	4268
query66	724	395	307	307
query67	16026	15577	15320	15320
query68	6873	901	525	525
query69	527	290	258	258
query70	1210	1127	1131	1127
query71	495	315	295	295
query72	5909	4822	5020	4822
query73	1350	699	345	345
query74	9315	8917	9021	8917
query75	3784	3204	2681	2681
query76	4260	1246	806	806
query77	619	406	285	285
query78	10034	10092	9330	9330
query79	4271	824	558	558
query80	637	528	446	446
query81	493	255	224	224
query82	507	128	97	97
query83	384	263	245	245
query84	305	106	89	89
query85	816	374	323	323
query86	385	309	281	281
query87	4420	4516	4316	4316
query88	3705	2264	2257	2257
query89	440	322	289	289
query90	1831	216	219	216
query91	146	141	114	114
query92	77	60	56	56
query93	3126	952	582	582
query94	667	392	315	315
query95	377	320	294	294
query96	493	570	276	276
query97	3173	3271	3133	3133
query98	224	208	204	204
query99	1464	1403	1287	1287
Total cold run time: 304440 ms
Total hot run time: 193589 ms

doris-robot · 2025-04-11T04:59:33Z

ClickBench: Total hot run time: 31.5 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a9f018c9771414ff7154cc72abb3c04a7132d821, data reload: false
query1	0.04	0.04	0.03
query2	0.12	0.11	0.11
query3	0.25	0.19	0.19
query4	1.60	0.20	0.19
query5	0.60	0.59	0.58
query6	1.20	0.72	0.71
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.59	0.53	0.52
query10	0.58	0.58	0.57
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.60	0.60
query14	2.64	2.71	2.69
query15	0.93	0.87	0.86
query16	0.39	0.38	0.39
query17	1.06	1.05	1.07
query18	0.21	0.19	0.20
query19	1.95	1.98	1.83
query20	0.01	0.01	0.01
query21	15.35	0.91	0.59
query22	0.74	1.08	0.64
query23	15.04	1.39	0.61
query24	6.68	2.11	1.16
query25	0.52	0.36	0.07
query26	0.54	0.15	0.13
query27	0.05	0.05	0.05
query28	10.29	0.82	0.45
query29	12.55	3.97	3.26
query30	0.24	0.09	0.06
query31	2.83	0.59	0.39
query32	3.22	0.54	0.47
query33	3.01	3.05	3.06
query34	15.73	5.09	4.49
query35	4.48	4.50	4.48
query36	0.68	0.50	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.55 s
Total hot run time: 31.5 s

### What problem does this PR solve? Problem Summary: When use JDK17 with obs, if drop an iceberg table, an error will occur: ``` Caused by: java.lang.IllegalAccessException: class com.obs.services.internal.xml.OBSXMLBuilder cannot access class com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl (in module java.xml) because module java.xml does not export com.sun.org.apache.xerces.internal.jaxp to unnamed module @50ad3bc1 ``` so, we should add JVM config: --add-opens java.xml/com.sun.org.apache.xerces.internal.jaxp=ALL-UNNAMED

…49983 (#50018) Cherry-picked from #49983 Co-authored-by: wuwenchi <wuwenchi@selectdb.com>

### What problem does this PR solve? Problem Summary: When use JDK17 with obs, if drop an iceberg table, an error will occur: ``` Caused by: java.lang.IllegalAccessException: class com.obs.services.internal.xml.OBSXMLBuilder cannot access class com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl (in module java.xml) because module java.xml does not export com.sun.org.apache.xerces.internal.jaxp to unnamed module @50ad3bc1 ``` so, we should add JVM config: --add-opens java.xml/com.sun.org.apache.xerces.internal.jaxp=ALL-UNNAMED

fix
a9f018c

morningman added the dev/3.0.x label Apr 11, 2025

morningman approved these changes Apr 11, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 11, 2025

github-actionsBot added the reviewed label Apr 11, 2025

CalvinKirs approved these changes Apr 14, 2025
View reviewed changes

suxiaogang223 approved these changes Apr 14, 2025
View reviewed changes

morningman merged commit 54eda4b into apache:masterApr 14, 2025

github-actionsBot mentioned this pull request Apr 14, 2025
branch-3.0: [fix](iceberg) Fix the failure of creating a table in OBS #49983 #50018
Merged

dataroaring pushed a commit that referenced this pull request Apr 23, 2025
branch-3.0: [fix](iceberg) Fix the failure of creating a table in OBS#…
0577ffd
…49983 (#50018) Cherry-picked from #49983 Co-authored-by: wuwenchi <wuwenchi@selectdb.com>

dataroaring added dev/3.0.6-merged and removed dev/3.0.x labels Apr 23, 2025

Navigation Menu

Uh oh!

[fix](iceberg) Fix the failure of creating a table in OBS - #49983

[fix](iceberg) Fix the failure of creating a table in OBS#49983
morningman merged 1 commit into
apache:masterfrom
wuwenchi:fix-obs-jvm

wuwenchi commented Apr 11, 2025

Uh oh!

hello-stephen commented Apr 11, 2025

Uh oh!

wuwenchi commented Apr 11, 2025

Uh oh!

github-actionsBot commented Apr 11, 2025

Uh oh!

github-actionsBot commented Apr 11, 2025

Uh oh!

doris-robot commented Apr 11, 2025

Uh oh!

doris-robot commented Apr 11, 2025

Uh oh!

doris-robot commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

wuwenchi commented Apr 11, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Apr 11, 2025

Uh oh!

wuwenchi commented Apr 11, 2025

Uh oh!

github-actionsBot commented Apr 11, 2025

Uh oh!

github-actionsBot commented Apr 11, 2025

Uh oh!

doris-robot commented Apr 11, 2025

Uh oh!

doris-robot commented Apr 11, 2025

Uh oh!

doris-robot commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants