Uh oh!
There was an error while loading. Please reload this page.
branch-2.1-pick: [Opt](log) Add and fix logs for delete bitmaps - #50060
Merged
Conversation
1. remove rows check for newly generated block in publish in partial update. When the rowset has multi segments, newly generated segments of conflict rows on these segments will be flushed concurrently using the same rowset writer. So `rowset_writer->num_rows()` may be larger than `new_generated_rows`. 2. correct `rowset_ids to add:` size when calculate delete bitmap in publish phase. Include invisible rowsets for txn_load 3. add a config `enable_mow_verbose_log` to control whether to print verbose log for delete bitmap calculation.
…e#48930) Add more delete bitmap log for merge-on-write table
hello-stephen
commented
Apr 15, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bobhan1
commented
Apr 15, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Apr 15, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
bobhan1
commented
Apr 15, 2025
ContributorAuthor
run p0 |
1 similar comment
bobhan1
commented
Apr 16, 2025
ContributorAuthor
run p0 |
bobhan1
commented
Apr 16, 2025
ContributorAuthor
run buildall |
yiguolei
approved these changes
Apr 16, 2025
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
doris-robot
commented
Apr 16, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick #48523, #48930