[Fix](field) Fix potential memory leak and wrong binary reading about JsonbField by zclllyybb · Pull Request #50174 · apache/doris

zclllyybb · 2025-04-18T07:56:24Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

it's in JsonbField's copy constructor which we did not really use but required because of as Field's storage's type.
read_json_binary's implementation is WRONG. it didn't set anything before.

agg function with paremeter JSON is buggy( but we now dont support any). this PR fixed.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-04-18T07:56:31Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zclllyybb · 2025-04-18T07:56:40Z

run buildall

doris-robot · 2025-04-18T09:32:31Z

TPC-H: Total hot run time: 34093 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eacbb80f9d6deec73673f739502aa684d2a0d9e0, data reload: false
------ Round 1 ----------------------------------
q1	26304	5007	5024	5007
q2	2071	289	189	189
q3	10596	1248	701	701
q4	10252	1006	530	530
q5	7881	2467	2369	2369
q6	190	165	134	134
q7	904	740	613	613
q8	9321	1312	1187	1187
q9	6876	5118	5118	5118
q10	6816	2314	1899	1899
q11	476	287	268	268
q12	350	353	219	219
q13	17783	3660	3107	3107
q14	232	225	212	212
q15	534	474	474	474
q16	449	439	402	402
q17	602	876	361	361
q18	7640	7254	7115	7115
q19	1709	960	582	582
q20	341	349	219	219
q21	4218	3367	2417	2417
q22	1075	1010	970	970
Total cold run time: 116620 ms
Total hot run time: 34093 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5149	5091	5079	5079
q2	232	326	234	234
q3	2145	2653	2302	2302
q4	1421	1810	1557	1557
q5	4563	4460	4396	4396
q6	216	167	127	127
q7	1959	1860	1739	1739
q8	2608	2560	2481	2481
q9	7273	7131	7223	7131
q10	2971	3160	2771	2771
q11	576	508	483	483
q12	661	759	603	603
q13	3476	3920	3262	3262
q14	280	295	275	275
q15	525	481	475	475
q16	463	505	469	469
q17	1200	1576	1383	1383
q18	7669	7520	7460	7460
q19	794	861	900	861
q20	1977	2085	1842	1842
q21	5135	4704	4608	4608
q22	1063	1032	964	964
Total cold run time: 52356 ms
Total hot run time: 50502 ms

doris-robot · 2025-04-18T09:44:04Z

TPC-DS: Total hot run time: 185311 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eacbb80f9d6deec73673f739502aa684d2a0d9e0, data reload: false
query1	1016	470	507	470
query2	6593	1802	1802	1802
query3	6736	220	225	220
query4	25899	23655	23281	23281
query5	4332	642	462	462
query6	288	195	184	184
query7	4625	495	275	275
query8	321	251	255	251
query9	8633	2554	2570	2554
query10	485	313	270	270
query11	15585	15617	14772	14772
query12	172	111	108	108
query13	1666	508	400	400
query14	9687	6131	6035	6035
query15	208	196	158	158
query16	7330	623	492	492
query17	1171	727	586	586
query18	1974	419	301	301
query19	182	179	153	153
query20	121	110	114	110
query21	210	121	103	103
query22	4286	4287	4373	4287
query23	33804	32910	32699	32699
query24	8457	2345	2375	2345
query25	547	450	381	381
query26	1238	278	152	152
query27	2743	490	326	326
query28	4342	2081	2070	2070
query29	737	606	441	441
query30	285	214	188	188
query31	946	867	765	765
query32	72	64	64	64
query33	570	376	316	316
query34	793	848	516	516
query35	780	816	729	729
query36	952	981	871	871
query37	117	99	75	75
query38	4111	4132	4196	4132
query39	1465	1389	1429	1389
query40	210	120	105	105
query41	57	56	56	56
query42	124	105	102	102
query43	496	493	482	482
query44	1294	816	803	803
query45	182	169	167	167
query46	841	1033	611	611
query47	1766	1794	1728	1728
query48	363	407	301	301
query49	768	505	422	422
query50	649	670	386	386
query51	4152	4125	4146	4125
query52	110	102	97	97
query53	230	268	187	187
query54	568	566	485	485
query55	84	79	87	79
query56	319	323	292	292
query57	1142	1164	1087	1087
query58	262	250	253	250
query59	2661	2663	2551	2551
query60	321	324	291	291
query61	134	152	124	124
query62	797	740	683	683
query63	224	191	197	191
query64	4329	998	679	679
query65	4317	4269	4221	4221
query66	1162	425	326	326
query67	15960	15433	15476	15433
query68	6057	892	522	522
query69	476	316	277	277
query70	1190	1112	1086	1086
query71	421	333	301	301
query72	5741	4995	4676	4676
query73	664	600	343	343
query74	8982	8860	8698	8698
query75	3156	3182	2691	2691
query76	3252	1192	771	771
query77	479	394	277	277
query78	10031	10112	9301	9301
query79	2771	804	567	567
query80	1607	509	455	455
query81	570	247	316	247
query82	498	133	96	96
query83	348	247	232	232
query84	255	103	82	82
query85	842	364	306	306
query86	460	326	277	277
query87	4295	4450	4254	4254
query88	4066	2216	2199	2199
query89	397	315	272	272
query90	1929	206	210	206
query91	139	139	114	114
query92	75	62	58	58
query93	2548	949	579	579
query94	723	415	280	280
query95	367	291	283	283
query96	524	557	272	272
query97	3156	3249	3088	3088
query98	230	217	217	217
query99	1347	1424	1287	1287
Total cold run time: 274597 ms
Total hot run time: 185311 ms

doris-robot · 2025-04-18T09:49:26Z

ClickBench: Total hot run time: 29.82 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eacbb80f9d6deec73673f739502aa684d2a0d9e0, data reload: false
query1	0.04	0.04	0.03
query2	0.12	0.10	0.12
query3	0.25	0.19	0.19
query4	1.59	0.20	0.19
query5	0.59	0.59	0.57
query6	1.20	0.71	0.71
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.58	0.54	0.51
query10	0.58	0.58	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.60	0.60
query14	1.17	1.17	1.21
query15	0.87	0.86	0.88
query16	0.40	0.38	0.37
query17	1.01	1.02	1.03
query18	0.21	0.20	0.20
query19	1.92	1.81	1.82
query20	0.01	0.01	0.02
query21	15.43	0.91	0.53
query22	0.78	1.31	0.68
query23	14.79	1.42	0.61
query24	7.29	1.52	0.96
query25	0.51	0.17	0.09
query26	0.63	0.16	0.13
query27	0.06	0.05	0.05
query28	10.18	0.83	0.42
query29	12.62	4.03	3.42
query30	0.25	0.09	0.06
query31	2.83	0.58	0.39
query32	3.23	0.53	0.46
query33	3.08	2.98	3.08
query34	15.86	5.13	4.53
query35	4.57	4.56	4.55
query36	0.65	0.49	0.49
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 104.76 s
Total hot run time: 29.82 s

doris-robot · 2025-04-18T11:03:28Z

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	53.16% (14426/27137)
Line Coverage	42.01% (124960/297471)
Region Coverage	40.83% (63850/156377)
Branch Coverage	35.46% (32102/90532)

zclllyybb · 2025-04-18T15:20:49Z

run buildall

zclllyybb · 2025-04-18T15:22:37Z

run buildall

doris-robot · 2025-04-18T17:06:09Z

TPC-H: Total hot run time: 33916 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9cd53441668e5be77f09b8c3a84189f8a03d58c9, data reload: false
------ Round 1 ----------------------------------
q1	26053	5049	5025	5025
q2	2064	274	189	189
q3	10493	1232	699	699
q4	10231	1023	532	532
q5	7758	2477	2380	2380
q6	187	161	135	135
q7	926	734	610	610
q8	9301	1274	1064	1064
q9	6824	5122	5146	5122
q10	6799	2287	1880	1880
q11	494	288	265	265
q12	355	353	219	219
q13	17774	3649	3051	3051
q14	233	235	207	207
q15	525	481	495	481
q16	444	454	411	411
q17	585	873	360	360
q18	7659	7221	7105	7105
q19	1513	952	569	569
q20	333	341	231	231
q21	4066	2649	2412	2412
q22	1011	1035	969	969
Total cold run time: 115628 ms
Total hot run time: 33916 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5161	5111	5048	5048
q2	240	320	238	238
q3	2164	2653	2278	2278
q4	1440	1832	1393	1393
q5	4502	4575	4382	4382
q6	218	170	131	131
q7	2023	1953	1786	1786
q8	2591	2589	2554	2554
q9	7318	7299	6998	6998
q10	2982	3185	2731	2731
q11	578	510	487	487
q12	676	776	594	594
q13	3489	3874	3246	3246
q14	285	294	296	294
q15	549	487	481	481
q16	506	516	448	448
q17	1148	1542	1417	1417
q18	7761	7539	7441	7441
q19	800	803	874	803
q20	1991	2054	1879	1879
q21	5210	4850	4767	4767
q22	1086	1046	1010	1010
Total cold run time: 52718 ms
Total hot run time: 50406 ms

doris-robot · 2025-04-18T17:18:02Z

TPC-DS: Total hot run time: 192681 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9cd53441668e5be77f09b8c3a84189f8a03d58c9, data reload: false
query1	1407	1083	1062	1062
query2	6222	1873	1834	1834
query3	11026	4674	4631	4631
query4	25760	23729	23133	23133
query5	4804	617	451	451
query6	319	205	186	186
query7	4005	498	269	269
query8	298	255	247	247
query9	8506	2560	2568	2560
query10	488	307	254	254
query11	15343	15105	14750	14750
query12	158	108	110	108
query13	1555	536	397	397
query14	8882	6042	6076	6042
query15	205	200	176	176
query16	7594	619	502	502
query17	1152	763	630	630
query18	2073	429	328	328
query19	210	202	176	176
query20	133	124	128	124
query21	212	127	116	116
query22	4517	4577	4385	4385
query23	34549	33771	33516	33516
query24	8198	2402	2419	2402
query25	507	481	421	421
query26	968	266	166	166
query27	2706	502	326	326
query28	4631	2204	2156	2156
query29	634	598	447	447
query30	277	224	192	192
query31	909	882	801	801
query32	73	64	60	60
query33	524	368	306	306
query34	816	874	544	544
query35	837	865	782	782
query36	958	1002	910	910
query37	106	94	76	76
query38	4304	4222	4273	4222
query39	1526	1469	1457	1457
query40	207	127	104	104
query41	57	56	51	51
query42	127	114	109	109
query43	516	506	471	471
query44	1295	845	815	815
query45	187	174	171	171
query46	847	1023	638	638
query47	1864	1912	1831	1831
query48	395	403	302	302
query49	717	511	439	439
query50	686	690	400	400
query51	4311	4395	4309	4309
query52	111	104	97	97
query53	232	256	183	183
query54	568	582	501	501
query55	90	81	86	81
query56	306	306	268	268
query57	1166	1188	1130	1130
query58	257	262	258	258
query59	2825	2785	2764	2764
query60	342	326	291	291
query61	129	140	141	140
query62	783	734	743	734
query63	221	195	188	188
query64	3329	1017	700	700
query65	4454	4332	4369	4332
query66	826	413	316	316
query67	15915	15529	15499	15499
query68	8776	878	500	500
query69	489	296	267	267
query70	1239	1118	1122	1118
query71	459	330	294	294
query72	5295	4636	4592	4592
query73	703	562	415	415
query74	8910	9152	8846	8846
query75	4080	3177	2635	2635
query76	3690	1182	742	742
query77	788	366	272	272
query78	10009	10145	9199	9199
query79	2137	804	575	575
query80	575	555	480	480
query81	504	252	218	218
query82	480	134	94	94
query83	244	259	227	227
query84	249	107	88	88
query85	796	351	317	317
query86	372	320	300	300
query87	4417	4436	4368	4368
query88	3684	2213	2200	2200
query89	402	324	278	278
query90	1832	214	214	214
query91	135	135	114	114
query92	80	60	55	55
query93	1674	918	586	586
query94	668	411	284	284
query95	385	304	279	279
query96	481	560	273	273
query97	3158	3211	3112	3112
query98	233	212	204	204
query99	1595	1391	1268	1268
Total cold run time: 278694 ms
Total hot run time: 192681 ms

doris-robot · 2025-04-18T17:23:14Z

ClickBench: Total hot run time: 29.79 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9cd53441668e5be77f09b8c3a84189f8a03d58c9, data reload: false
query1	0.04	0.03	0.03
query2	0.13	0.10	0.12
query3	0.25	0.20	0.19
query4	1.59	0.20	0.19
query5	0.59	0.59	0.58
query6	1.17	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.56	0.52	0.51
query10	0.58	0.56	0.56
query11	0.16	0.11	0.11
query12	0.16	0.11	0.11
query13	0.61	0.60	0.60
query14	1.17	1.22	1.14
query15	0.88	0.86	0.85
query16	0.37	0.39	0.39
query17	1.03	1.02	1.05
query18	0.21	0.19	0.19
query19	1.93	1.77	1.79
query20	0.02	0.01	0.01
query21	15.39	0.93	0.55
query22	0.76	1.39	0.66
query23	14.76	1.42	0.63
query24	6.73	1.40	1.00
query25	0.48	0.25	0.09
query26	0.62	0.17	0.14
query27	0.05	0.06	0.05
query28	9.78	0.93	0.46
query29	12.55	4.12	3.35
query30	0.25	0.08	0.06
query31	2.86	0.59	0.37
query32	3.22	0.54	0.48
query33	3.04	3.02	3.09
query34	15.80	5.07	4.52
query35	4.50	4.49	4.55
query36	0.65	0.50	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.14
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.44 s
Total hot run time: 29.79 s

hello-stephen · 2025-04-18T18:39:06Z

BE UT Coverage Report

Increment line coverage 51.95% (40/77) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	53.17% (14429/27137)
Line Coverage	42.02% (125001/297494)
Region Coverage	40.84% (63873/156388)
Branch Coverage	35.46% (32104/90542)

zclllyybb · 2025-05-07T06:29:53Z

run buildall

doris-robot · 2025-05-07T08:06:58Z

TPC-H: Total hot run time: 33895 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d6a7c974d87ea7f0036120e7c8f453d4d9f74bb0, data reload: false
------ Round 1 ----------------------------------
q1	26398	5046	4975	4975
q2	2094	280	193	193
q3	10601	1289	730	730
q4	10258	1021	512	512
q5	7963	2414	2308	2308
q6	182	160	135	135
q7	929	745	620	620
q8	9341	1309	1129	1129
q9	6917	5074	5080	5074
q10	6857	2316	1893	1893
q11	495	289	266	266
q12	355	354	215	215
q13	17779	3665	3126	3126
q14	242	226	207	207
q15	553	482	485	482
q16	416	441	390	390
q17	607	871	349	349
q18	7612	7249	7073	7073
q19	1674	948	571	571
q20	331	324	215	215
q21	3963	2678	2463	2463
q22	1059	1021	969	969
Total cold run time: 116626 ms
Total hot run time: 33895 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5079	5007	5049	5007
q2	236	325	237	237
q3	2159	2670	2274	2274
q4	1375	1832	1361	1361
q5	4560	4427	4397	4397
q6	223	171	127	127
q7	1947	1859	1804	1804
q8	2567	2559	2497	2497
q9	7137	7206	7167	7167
q10	2967	3149	2743	2743
q11	570	508	496	496
q12	701	789	651	651
q13	3453	3880	3258	3258
q14	268	290	264	264
q15	525	484	473	473
q16	469	525	450	450
q17	1171	1582	1363	1363
q18	7841	7387	7473	7387
q19	808	813	959	813
q20	1942	2035	1862	1862
q21	5104	4636	4605	4605
q22	1031	1015	1001	1001
Total cold run time: 52133 ms
Total hot run time: 50237 ms

doris-robot · 2025-05-07T08:18:30Z

TPC-DS: Total hot run time: 185534 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d6a7c974d87ea7f0036120e7c8f453d4d9f74bb0, data reload: false
query1	1007	479	499	479
query2	6573	1870	1813	1813
query3	6757	215	223	215
query4	26805	23936	23089	23089
query5	4358	627	466	466
query6	309	206	196	196
query7	4625	496	294	294
query8	300	252	234	234
query9	8625	2573	2603	2573
query10	494	314	275	275
query11	15476	15088	14797	14797
query12	161	108	107	107
query13	1652	535	408	408
query14	8779	6163	6327	6163
query15	198	184	169	169
query16	7200	647	484	484
query17	1177	697	600	600
query18	1968	397	314	314
query19	206	182	160	160
query20	116	115	118	115
query21	205	136	102	102
query22	4030	4322	4066	4066
query23	33776	32958	32834	32834
query24	8419	2389	2397	2389
query25	542	470	380	380
query26	1241	270	154	154
query27	2762	504	327	327
query28	4325	2092	2078	2078
query29	798	540	430	430
query30	290	215	188	188
query31	911	861	767	767
query32	81	67	68	67
query33	576	403	311	311
query34	807	843	525	525
query35	772	836	745	745
query36	969	1003	906	906
query37	118	102	82	82
query38	4243	4125	4244	4125
query39	1471	1425	1401	1401
query40	217	125	115	115
query41	65	61	63	61
query42	122	109	115	109
query43	526	508	465	465
query44	1284	807	805	805
query45	186	189	174	174
query46	845	1030	642	642
query47	1756	1793	1730	1730
query48	377	416	351	351
query49	787	529	452	452
query50	655	682	396	396
query51	4120	4086	4077	4077
query52	112	112	100	100
query53	231	251	180	180
query54	585	573	503	503
query55	85	77	83	77
query56	341	294	275	275
query57	1111	1146	1099	1099
query58	284	264	252	252
query59	2707	2778	2600	2600
query60	326	317	315	315
query61	127	131	122	122
query62	789	733	655	655
query63	224	194	176	176
query64	4390	1013	674	674
query65	4252	4295	4260	4260
query66	1175	413	307	307
query67	15769	15634	15389	15389
query68	8245	883	513	513
query69	475	321	267	267
query70	1222	1102	1105	1102
query71	480	338	289	289
query72	5554	4612	4591	4591
query73	690	561	344	344
query74	8965	8836	8780	8780
query75	3731	3209	2732	2732
query76	3661	1210	767	767
query77	772	371	282	282
query78	9948	10130	9260	9260
query79	1910	819	561	561
query80	584	514	456	456
query81	476	253	214	214
query82	421	129	95	95
query83	271	258	231	231
query84	248	107	88	88
query85	855	370	310	310
query86	345	309	295	295
query87	4375	4447	4308	4308
query88	3175	2194	2221	2194
query89	390	310	281	281
query90	1912	210	206	206
query91	147	153	111	111
query92	84	65	59	59
query93	1122	947	574	574
query94	669	404	315	315
query95	376	281	286	281
query96	483	560	273	273
query97	3118	3238	3081	3081
query98	236	208	207	207
query99	1422	1433	1278	1278
Total cold run time: 272932 ms
Total hot run time: 185534 ms

doris-robot · 2025-05-07T08:23:42Z

ClickBench: Total hot run time: 28.69 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d6a7c974d87ea7f0036120e7c8f453d4d9f74bb0, data reload: false
query1	0.04	0.04	0.04
query2	0.12	0.11	0.11
query3	0.26	0.20	0.20
query4	1.59	0.19	0.11
query5	0.56	0.55	0.54
query6	1.18	0.72	0.74
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.59	0.52	0.50
query10	0.57	0.57	0.56
query11	0.16	0.12	0.11
query12	0.14	0.12	0.12
query13	0.61	0.59	0.60
query14	0.78	0.80	0.79
query15	0.87	0.88	0.84
query16	0.39	0.39	0.39
query17	1.04	1.03	1.02
query18	0.22	0.20	0.20
query19	1.89	1.75	1.80
query20	0.02	0.01	0.01
query21	15.40	0.89	0.55
query22	0.77	1.35	0.63
query23	14.80	1.41	0.65
query24	7.43	1.52	0.58
query25	0.47	0.26	0.05
query26	0.61	0.16	0.14
query27	0.05	0.05	0.05
query28	9.53	0.85	0.44
query29	12.54	4.04	3.29
query30	0.25	0.09	0.06
query31	2.83	0.59	0.38
query32	3.22	0.54	0.46
query33	2.98	3.00	3.08
query34	15.82	5.09	4.49
query35	4.49	4.51	4.48
query36	0.67	0.50	0.47
query37	0.08	0.06	0.06
query38	0.06	0.04	0.04
query39	0.02	0.02	0.02
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.03	0.02	0.03
query43	0.04	0.04	0.03
Total cold run time: 103.45 s
Total hot run time: 28.69 s

zclllyybb · 2025-05-07T13:33:50Z

run buildall

github-actions · 2025-05-07T13:38:50Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-05-07T13:38:52Z

PR approved by anyone and no changes requested.

doris-robot · 2025-05-07T15:09:33Z

TPC-H: Total hot run time: 33771 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ab3bd33d6693d214bce73f71f4c44a7f96c448d0, data reload: false
------ Round 1 ----------------------------------
q1	26215	5095	5010	5010
q2	2073	277	185	185
q3	10594	1289	709	709
q4	10261	1029	542	542
q5	7880	2391	2327	2327
q6	183	164	132	132
q7	910	746	618	618
q8	9327	1264	1109	1109
q9	6880	5061	5064	5061
q10	6806	2295	1865	1865
q11	492	283	264	264
q12	348	356	213	213
q13	17764	3691	3100	3100
q14	234	221	207	207
q15	515	479	493	479
q16	422	420	386	386
q17	604	845	388	388
q18	7621	7163	7062	7062
q19	1525	947	553	553
q20	324	331	216	216
q21	4006	2613	2383	2383
q22	1066	994	962	962
Total cold run time: 116050 ms
Total hot run time: 33771 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5232	5057	5081	5057
q2	234	331	241	241
q3	2144	2661	2324	2324
q4	1349	1803	1329	1329
q5	4594	4429	4439	4429
q6	221	165	123	123
q7	1967	1926	1748	1748
q8	2588	2587	2529	2529
q9	7138	7127	7056	7056
q10	2970	3173	2765	2765
q11	559	499	493	493
q12	667	760	595	595
q13	3502	3840	3382	3382
q14	279	294	266	266
q15	517	470	469	469
q16	444	488	434	434
q17	1143	1497	1407	1407
q18	7887	7594	7546	7546
q19	817	848	1069	848
q20	1965	2013	1880	1880
q21	5186	4647	4531	4531
q22	1049	982	1010	982
Total cold run time: 52452 ms
Total hot run time: 50434 ms

doris-robot · 2025-05-07T15:21:02Z

TPC-DS: Total hot run time: 185333 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ab3bd33d6693d214bce73f71f4c44a7f96c448d0, data reload: false
query1	1010	487	519	487
query2	6565	1834	1783	1783
query3	6759	228	218	218
query4	26298	23650	23360	23360
query5	4334	629	461	461
query6	309	218	194	194
query7	4633	495	277	277
query8	298	243	230	230
query9	8587	2510	2513	2510
query10	484	295	260	260
query11	15242	15137	14784	14784
query12	160	115	119	115
query13	1664	524	398	398
query14	9197	6122	6227	6122
query15	203	186	163	163
query16	7691	649	495	495
query17	1205	718	574	574
query18	2056	386	294	294
query19	180	183	148	148
query20	120	122	119	119
query21	210	125	102	102
query22	4316	4157	4128	4128
query23	33743	32933	32829	32829
query24	8431	2369	2380	2369
query25	519	451	380	380
query26	910	278	152	152
query27	2728	507	322	322
query28	4334	2050	2051	2050
query29	645	541	421	421
query30	275	211	178	178
query31	955	864	778	778
query32	77	64	64	64
query33	565	362	302	302
query34	783	845	495	495
query35	778	806	725	725
query36	967	994	889	889
query37	106	96	74	74
query38	4153	4145	4134	4134
query39	1444	1400	1401	1400
query40	221	118	105	105
query41	57	58	53	53
query42	122	102	122	102
query43	506	490	462	462
query44	1289	774	762	762
query45	181	173	169	169
query46	816	1003	634	634
query47	1776	1828	1752	1752
query48	366	397	309	309
query49	725	490	424	424
query50	628	675	390	390
query51	4073	4257	4065	4065
query52	106	108	103	103
query53	215	251	183	183
query54	580	553	488	488
query55	84	78	77	77
query56	286	285	288	285
query57	1155	1140	1088	1088
query58	263	264	253	253
query59	2572	2673	2573	2573
query60	312	324	319	319
query61	126	124	127	124
query62	769	716	656	656
query63	232	185	188	185
query64	3494	1009	738	738
query65	4325	4236	4243	4236
query66	902	408	350	350
query67	15502	15241	15211	15211
query68	7773	874	495	495
query69	471	319	259	259
query70	1087	1110	1113	1110
query71	462	310	293	293
query72	5621	4697	4922	4697
query73	691	648	336	336
query74	8846	9141	8781	8781
query75	3814	3189	2661	2661
query76	3466	1189	743	743
query77	805	365	301	301
query78	9889	10106	9356	9356
query79	1967	808	561	561
query80	570	509	435	435
query81	477	262	220	220
query82	304	126	94	94
query83	250	245	239	239
query84	301	109	87	87
query85	810	370	371	370
query86	329	290	277	277
query87	4413	4378	4262	4262
query88	3508	2189	2180	2180
query89	394	311	282	282
query90	1924	210	206	206
query91	135	142	115	115
query92	79	64	59	59
query93	1637	946	568	568
query94	621	407	294	294
query95	375	291	282	282
query96	485	564	277	277
query97	3115	3206	3119	3119
query98	238	206	201	201
query99	1344	1388	1293	1293
Total cold run time: 270818 ms
Total hot run time: 185333 ms

doris-robot · 2025-05-07T15:26:12Z

ClickBench: Total hot run time: 29.52 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ab3bd33d6693d214bce73f71f4c44a7f96c448d0, data reload: false
query1	0.04	0.03	0.03
query2	0.12	0.11	0.10
query3	0.25	0.19	0.19
query4	1.59	0.20	0.20
query5	0.60	0.58	0.56
query6	1.18	0.71	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.53	0.50
query10	0.57	0.57	0.57
query11	0.15	0.11	0.12
query12	0.15	0.11	0.12
query13	0.63	0.60	0.61
query14	0.78	0.80	0.82
query15	0.89	0.86	0.87
query16	0.37	0.38	0.38
query17	1.06	1.03	1.01
query18	0.20	0.20	0.21
query19	1.94	1.84	1.85
query20	0.01	0.01	0.01
query21	15.41	0.89	0.54
query22	0.79	1.21	0.69
query23	14.89	1.38	0.62
query24	6.77	1.65	1.04
query25	0.49	0.07	0.13
query26	0.53	0.16	0.15
query27	0.05	0.05	0.05
query28	9.88	0.86	0.43
query29	12.58	3.87	3.30
query30	0.25	0.09	0.06
query31	2.82	0.59	0.37
query32	3.22	0.56	0.48
query33	2.99	3.08	3.04
query34	15.71	5.17	4.54
query35	4.53	4.53	4.51
query36	0.66	0.49	0.48
query37	0.08	0.06	0.06
query38	0.06	0.03	0.03
query39	0.03	0.02	0.02
query40	0.18	0.13	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.24 s
Total hot run time: 29.52 s

doris-robot · 2025-05-07T16:56:46Z

BE UT Coverage Report

Increment line coverage 67.74% (42/62) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	55.60% (14871/26747)
Line Coverage	44.63% (131214/294029)
Region Coverage	43.35% (66837/154171)
Branch Coverage	37.93% (33725/88908)

… JsonbField (apache#50174)

…eading about JsonbField #50174 (#52555) Cherry-picked from 50174

…eading about JsonbField (#50174) (#52542) pick #50174

…eading about JsonbField (apache#50174) (apache#52542) pick apache#50174

… JsonbField (apache#50174) pick apache#50174

…eading about JsonbField (#50174) (#52693) pick #50174

…eading about JsonbField (apache#50174) (apache#52542) pick apache#50174

zclllyybb changed the title ~~[Fix](field) Fix potential memory leak from JsonbField~~[Fix](field) Fix potential memory leak and wrong binary reading about JsonbFieldApr 18, 2025

zclllyybb force-pushed the fix_jsonbfield branch from eacbb80 to 032beccCompare April 18, 2025 15:20

zclllyybb force-pushed the fix_jsonbfield branch from 032becc to 9cd5344Compare April 18, 2025 15:22

zclllyybb force-pushed the fix_jsonbfield branch from 9cd5344 to d6a7c97Compare May 7, 2025 06:29

zhangstar333 previously approved these changes May 7, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 7, 2025

github-actionsBot added the reviewed label May 7, 2025

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 8, 2025

yiguolei merged commit ed19dc1 into apache:masterMay 8, 2025

koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
[Fix](field) Fix potential memory leak and wrong binary reading about…
ffd1463
… JsonbField (apache#50174)

zclllyybb deleted the fix_jsonbfield branch June 30, 2025 09:23

zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jun 30, 2025
[Fix](field) Fix potential memory leak and wrong binary reading about…
3fdd2c7
… JsonbField (apache#50174)

zclllyybb mentioned this pull request Jun 30, 2025
branch-3.0: [Fix](field) Fix potential memory leak and wrong binary reading about JsonbField (#50174) #52542
Merged

zclllyybb added p0_b dev/3.0.x dev/3.1.x labels Jun 30, 2025

github-actionsBot added dev/3.0.x-conflict dev/3.1.x-conflict labels Jun 30, 2025

zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jun 30, 2025
[Fix](field) Fix potential memory leak and wrong binary reading about…
ea12503
… JsonbField (apache#50174)

zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jun 30, 2025
[Fix](field) Fix potential memory leak and wrong binary reading about…
73599ac
… JsonbField (apache#50174)

zclllyybb mentioned this pull request Jun 30, 2025
branch-3.1: [Fix](field) Fix potential memory leak and wrong binary reading about JsonbField #50174 #52555
Merged

morrySnow pushed a commit that referenced this pull request Jul 1, 2025
branch-3.1: [Fix](field) Fix potential memory leak and wrong binary r…
d994b4f
…eading about JsonbField #50174 (#52555) Cherry-picked from 50174

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Jul 1, 2025

dataroaring pushed a commit that referenced this pull request Jul 2, 2025
branch-3.0: [Fix](field) Fix potential memory leak and wrong binary r…
32ac14f
…eading about JsonbField (#50174) (#52542) pick #50174

dataroaring added dev/3.0.7-merged and removed dev/3.0.x dev/3.0.x-conflict labels Jul 2, 2025

zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jul 2, 2025
branch-3.0: [Fix](field) Fix potential memory leak and wrong binary r…
3a54c82
…eading about JsonbField (apache#50174) (apache#52542) pick apache#50174

zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jul 2, 2025
branch-3.0: [Fix](field) Fix potential memory leak and wrong binary r…
c7ed3be
…eading about JsonbField (apache#50174) (apache#52542) pick apache#50174

zclllyybb mentioned this pull request Jul 2, 2025
branch-2.1: [Fix](field) Fix potential memory leak and wrong binary reading about JsonbField (#50174) #52693
Merged

zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jul 2, 2025
[Fix](field) Fix potential memory leak and wrong binary reading about…
0e3a101
… JsonbField (apache#50174) pick apache#50174

zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jul 2, 2025
[Fix](field) Fix potential memory leak and wrong binary reading about…
c8bc111
… JsonbField (apache#50174) pick apache#50174

yiguolei pushed a commit that referenced this pull request Jul 3, 2025
branch-2.1: [Fix](field) Fix potential memory leak and wrong binary r…
fb70742
…eading about JsonbField (#50174) (#52693) pick #50174

yiguolei added the dev/2.1.11-merged label Jul 3, 2025

koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
branch-3.0: [Fix](field) Fix potential memory leak and wrong binary r…
c5d22b7
…eading about JsonbField (apache#50174) (apache#52542) pick apache#50174

Uh oh!

Conversation

zclllyybb commented Apr 18, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Apr 18, 2025

Uh oh!

zclllyybb commented Apr 18, 2025

Uh oh!

doris-robot commented Apr 18, 2025

Uh oh!

doris-robot commented Apr 18, 2025

Uh oh!

doris-robot commented Apr 18, 2025

Uh oh!

doris-robot commented Apr 18, 2025

BE UT Coverage Report

Uh oh!

zclllyybb commented Apr 18, 2025

Uh oh!

zclllyybb commented Apr 18, 2025

Uh oh!

doris-robot commented Apr 18, 2025

Uh oh!

doris-robot commented Apr 18, 2025

Uh oh!

doris-robot commented Apr 18, 2025

Uh oh!

hello-stephen commented Apr 18, 2025

BE UT Coverage Report

Uh oh!

zclllyybb commented May 7, 2025

Uh oh!

doris-robot commented May 7, 2025

Uh oh!

doris-robot commented May 7, 2025

Uh oh!

doris-robot commented May 7, 2025

Uh oh!

zclllyybb commented May 7, 2025

Uh oh!

github-actionsBot commented May 7, 2025

Uh oh!

github-actionsBot commented May 7, 2025

Uh oh!

doris-robot commented May 7, 2025

Uh oh!

doris-robot commented May 7, 2025

Uh oh!

doris-robot commented May 7, 2025

Uh oh!

doris-robot commented May 7, 2025

BE UT Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

zclllyybb commented Apr 18, 2025•
edited
Loading