Skip to content

Push down predicate on value column of unique table to base rowset - #5022

Merged
morningman merged 2 commits into
apache:masterfrom
yangzhg:push_down_unique
Dec 6, 2020
Merged

Push down predicate on value column of unique table to base rowset#5022
morningman merged 2 commits into
apache:masterfrom
yangzhg:push_down_unique

Conversation

@yangzhg

@yangzhgyangzhg commented Dec 4, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Proposed changes

implements #5024

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (FixPush down predicate on value column of unique table to base rowset #5024), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yangzhgyangzhg changed the title push down predicate on value columnpush down predicate on value column of unique table to base rowsetDec 4, 2020
@yangzhgyangzhg changed the title push down predicate on value column of unique table to base rowsetPush down predicate on value column of unique table to base rowsetDec 4, 2020
@morningmanmorningman added area/storage Issues or PRs related to storage engine kind/improvement labels Dec 4, 2020
morningman
morningman reviewed Dec 4, 2020
View reviewed changes
Comment threadbe/src/exec/olap_scanner.cpp
Comment threadbe/src/olap/rowset/rowset_reader_context.h Outdated
morningman
morningman approved these changes Dec 5, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Dec 5, 2020
@morningman
morningman merged commit b9dabc3 into apache:masterDec 6, 2020
yangzhg added a commit to yangzhg/doris that referenced this pull request Dec 7, 2020
@yangzhg
fix a core dump caused by prapache#5022
f726014
@yangzhgyangzhg mentioned this pull request Dec 7, 2020
Merged
2 tasks
yangzhg added a commit that referenced this pull request Dec 8, 2020
@yangzhg
Fix a core dump introduced by pr#5022(#5032)
eb0cb04
* fix a core dump caused by pr #5022
@yangzhg
yangzhg deleted the push_down_unique branch December 22, 2020 07:13
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Closed
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
@jacktengg
[fix](decimal256) fix unstable overflow error when casting decimal256…
d8625be
… to float (apache#5022)
## Proposed changes
Issue Number: close #xxx
apache#56848
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/storageIssues or PRs related to storage enginekind/improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Push down predicate on value column of unique table to base rowset

2 participants

@yangzhg@morningman