Skip to content

branch-3.0: [fix](lzo) fix lzo decompression failed (#49538) - #50323

Merged
dataroaring merged 2 commits into
apache:branch-3.0from
morningman:30_bp49538
Apr 24, 2025
Merged

branch-3.0: [fix](lzo) fix lzo decompression failed (#49538)#50323
dataroaring merged 2 commits into
apache:branch-3.0from
morningman:30_bp49538

Conversation

@morningman

@morningmanmorningman commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

@morningman
[fix](lzo) fix lzo decompression failed (apache#49538)
b4fb129
### What problem does this PR solve?
Problem Summary:
1.
If there is an empty block in lzo file, the decompress may fail:
`Lzo decompression failed: MalformedInputException at :13`
This is because if the next block's uncompressed size is 0,
we thought it is the last block, which is not right.
This PR fix it by removing the peek for the next block.
2.
Fix a bug that compressed size may be read wrong.
@Thearas

Thearas commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman

morningman commented Apr 23, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@morningman

morningman commented Apr 23, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Apr 23, 2025

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 0.00% (0/8) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage40.22% (10558/26248)
Line Coverage30.99% (89315/288214)
Region Coverage30.12% (46074/152974)
Branch Coverage26.63% (23552/88456)

@morningmanmorningman reopened this Apr 23, 2025
@morningmanmorningman changed the title [fix](lzo) fix lzo decompression failed (#49538)branch-3.0: [fix](lzo) fix lzo decompression failed (#49538)Apr 23, 2025
dataroaring
dataroaring approved these changes Apr 24, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 65a742b into apache:branch-3.0Apr 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morningman@Thearas@doris-robot@dataroaring