Skip to content

branch-2.1: [fix](geo) Fix ST_Contains behavior #50115 - #50569

Merged
yiguolei merged 1 commit into
branch-2.1from
auto-pick-50115-branch-2.1
May 3, 2025
Merged

branch-2.1: [fix](geo) Fix ST_Contains behavior #50115#50569
yiguolei merged 1 commit into
branch-2.1from
auto-pick-50115-branch-2.1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #50115

1. According to the OGC standard, a point lying exactly on the boundary
of a polygon no longer returns `true` for `ST_Contains`. This behavior
has been changed to return `false`.
2. Fix the inconsistency in `polygon Contains linestring` caused by
differing linestring directions.
3. Fixed a logical error in `multipolygon Contains multipolygon`
@linrrzqqq

Copy link
Copy Markdown
Collaborator

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 40.00% (14/35) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage38.87% (10276/26440)
Line Coverage29.91% (85338/285361)
Region Coverage28.56% (43993/154038)
Branch Coverage25.29% (22503/88986)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (35/35) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage76.18% (19844/26050)
Line Coverage71.55% (202891/283568)
Region Coverage69.27% (124246/179353)
Branch Coverage62.48% (62883/100644)

1 similar comment
@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (35/35) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage76.18% (19844/26050)
Line Coverage71.55% (202891/283568)
Region Coverage69.27% (124246/179353)
Branch Coverage62.48% (62883/100644)

@yiguoleiyiguolei closed this May 2, 2025
@yiguoleiyiguolei reopened this May 2, 2025
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 2, 2025
@github-actions

Copy link
Copy Markdown
ContributorAuthor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
ContributorAuthor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit af4195e into branch-2.1May 3, 2025
@github-actions
github-actionsBot deleted the auto-pick-50115-branch-2.1 branch May 3, 2025 14:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@linrrzqqq@hello-stephen@yiguolei