Uh oh!
There was an error while loading. Please reload this page.
[improve](load) introduce black list of backend when load job fetch meta to avoid jitter - #50587
Merged
Merged
Conversation
sollhui
requested review from
CalvinKirs, dataroaring and morningman
as code ownersMay 4, 2025 06:30
hello-stephen
commented
May 4, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
sollhui
commented
May 4, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 4, 2025
TPC-H: Total hot run time: 33555 ms |
doris-robot
commented
May 4, 2025
TPC-DS: Total hot run time: 192319 ms |
doris-robot
commented
May 4, 2025
ClickBench: Total hot run time: 29.15 s |
sollhui
commented
May 6, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 6, 2025
TPC-H: Total hot run time: 33544 ms |
doris-robot
commented
May 6, 2025
TPC-DS: Total hot run time: 191777 ms |
doris-robot
commented
May 6, 2025
ClickBench: Total hot run time: 29.05 s |
sollhui
commented
May 8, 2025
ContributorAuthor
run buildall |
sollhui
commented
May 8, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 8, 2025
TPC-H: Total hot run time: 33676 ms |
doris-robot
commented
May 8, 2025
TPC-DS: Total hot run time: 192259 ms |
doris-robot
commented
May 8, 2025
ClickBench: Total hot run time: 29.22 s |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
sollhui
commented
May 12, 2025
ContributorAuthor
run buildall |
sollhui
commented
May 14, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 14, 2025
TPC-H: Total hot run time: 33884 ms |
doris-robot
commented
May 14, 2025
TPC-DS: Total hot run time: 194463 ms |
doris-robot
commented
May 14, 2025
ClickBench: Total hot run time: 29.39 s |
hello-stephen
commented
May 14, 2025
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
sollhui
commented
May 15, 2025
ContributorAuthor
run buildall |
sollhui
commented
May 15, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 15, 2025
TPC-H: Total hot run time: 34042 ms |
doris-robot
commented
May 15, 2025
TPC-DS: Total hot run time: 194342 ms |
doris-robot
commented
May 15, 2025
ClickBench: Total hot run time: 29.36 s |
hello-stephen
commented
May 15, 2025
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
May 15, 2025
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
PR approved by at least one committer and no changes requested. |
github-actionsBot
pushed a commit
that referenced
this pull request
May 19, 2025
…eta to avoid jitter (#50587) ### What problem does this PR solve? Introduce black list of backend when load job fetch meta to avoid jitter: 1. Fetching meta operation would select one node randomly, If one node abnormal continuously, fetching meta operation will timeout and cause load speed jitter. 2. When will one backend added to the blacklist: - Fetch meta RPC failed. - Retry to other backend success. 3. When will one backend removed to the blacklist: - Two minutes automatic expiration. Other improvement of fetching meta retry: will not choose be failed in the same request.
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…eta to avoid jitter (apache#50587) ### What problem does this PR solve? Introduce black list of backend when load job fetch meta to avoid jitter: 1. Fetching meta operation would select one node randomly, If one node abnormal continuously, fetching meta operation will timeout and cause load speed jitter. 2. When will one backend added to the blacklist: - Fetch meta RPC failed. - Retry to other backend success. 3. When will one backend removed to the blacklist: - Two minutes automatic expiration. Other improvement of fetching meta retry: will not choose be failed in the same request.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Introduce black list of backend when load job fetch meta to avoid jitter:
Fetching meta operation would select one node randomly, If one node abnormal continuously, fetching meta operation will timeout and cause load speed jitter.
When will one backend added to the blacklist:
Other improvement of fetching meta retry: will not choose be failed in the same request.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)