Skip to content

[Enhancement] (nereids)implement adminSetReplicaVersionCommand in nereids - #50617

Merged
starocean999 merged 1 commit into
apache:masterfrom
codeDing18:AdminSetReplicaVersion-nereids
Jun 11, 2025
Merged

[Enhancement] (nereids)implement adminSetReplicaVersionCommand in nereids#50617
starocean999 merged 1 commit into
apache:masterfrom
codeDing18:AdminSetReplicaVersion-nereids

Conversation

@codeDing18

@codeDing18codeDing18 commented May 6, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close#42839

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented May 6, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@codeDing18
codeDing18force-pushed the AdminSetReplicaVersion-nereids branch from 84377b0 to efff727CompareJune 9, 2025 06:39
@codeDing18

codeDing18 commented Jun 9, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jun 9, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33780 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit efff7278cf7e3ee8155cdb63d6bf2ca863bdb528, data reload: false
------ Round 1 ----------------------------------
q1	25989	4954	4945	4945
q2	1933	290	193	193
q3	10277	1207	689	689
q4	10224	1016	528	528
q5	7534	2261	2371	2261
q6	176	158	130	130
q7	886	734	606	606
q8	9293	1282	1050	1050
q9	6941	5095	5071	5071
q10	6864	2277	1890	1890
q11	490	283	279	279
q12	336	346	221	221
q13	17780	3626	3116	3116
q14	242	228	208	208
q15	567	483	510	483
q16	428	433	374	374
q17	596	850	359	359
q18	7476	7061	7081	7061
q19	1607	950	542	542
q20	320	332	227	227
q21	3834	2609	2965	2609
q22	1032	1018	938	938
Total cold run time: 114825 ms
Total hot run time: 33780 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5097	5008	5022	5008
q2	237	314	221	221
q3	2154	2626	2286	2286
q4	1407	1856	1407	1407
q5	4403	4451	4539	4451
q6	232	174	133	133
q7	2043	1967	1832	1832
q8	2646	2635	2572	2572
q9	7261	7332	7122	7122
q10	3056	3226	2771	2771
q11	570	532	503	503
q12	706	786	616	616
q13	3475	3890	3375	3375
q14	274	299	274	274
q15	524	485	480	480
q16	462	500	460	460
q17	1153	1602	1358	1358
q18	7725	7570	7407	7407
q19	865	771	939	771
q20	1962	2105	1837	1837
q21	4779	4479	4457	4457
q22	1088	1050	1010	1010
Total cold run time: 52119 ms
Total hot run time: 50351 ms

@doris-robot

doris-robot commented Jun 9, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 192696 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit efff7278cf7e3ee8155cdb63d6bf2ca863bdb528, data reload: false
query1	1427	1076	1054	1054
query2	6235	1860	1805	1805
query3	10990	4447	4509	4447
query4	52908	25953	23144	23144
query5	5119	622	468	468
query6	355	211	196	196
query7	4880	497	290	290
query8	300	233	218	218
query9	5524	2603	2614	2603
query10	454	333	268	268
query11	14958	15500	14805	14805
query12	159	111	109	109
query13	1054	536	417	417
query14	10138	6525	6389	6389
query15	218	198	188	188
query16	7084	682	506	506
query17	1095	718	575	575
query18	1553	401	310	310
query19	192	192	163	163
query20	130	128	115	115
query21	207	127	113	113
query22	4471	4400	4293	4293
query23	34467	33625	33509	33509
query24	6778	2429	2439	2429
query25	450	481	403	403
query26	712	294	156	156
query27	2281	514	358	358
query28	2952	2158	2146	2146
query29	583	551	448	448
query30	276	215	197	197
query31	829	842	781	781
query32	71	63	59	59
query33	446	357	297	297
query34	794	889	541	541
query35	812	859	774	774
query36	981	992	908	908
query37	116	111	83	83
query38	4294	4272	4139	4139
query39	1494	1470	1436	1436
query40	217	124	109	109
query41	61	59	59	59
query42	124	112	110	110
query43	476	518	482	482
query44	1354	846	877	846
query45	193	184	178	178
query46	854	1023	661	661
query47	1842	1876	1817	1817
query48	401	426	346	346
query49	659	477	411	411
query50	658	705	408	408
query51	4258	4323	4147	4147
query52	114	108	106	106
query53	237	253	188	188
query54	592	584	530	530
query55	84	86	82	82
query56	300	294	306	294
query57	1182	1253	1183	1183
query58	272	269	252	252
query59	2657	2859	2700	2700
query60	327	318	321	318
query61	152	129	131	129
query62	770	762	680	680
query63	238	193	191	191
query64	1902	1051	732	732
query65	4286	4122	4128	4122
query66	724	402	308	308
query67	16231	15625	15665	15625
query68	6150	886	543	543
query69	537	313	268	268
query70	1208	1106	1108	1106
query71	461	322	297	297
query72	5896	4943	4811	4811
query73	1337	751	362	362
query74	9082	9238	8957	8957
query75	3176	3213	2734	2734
query76	3832	1209	799	799
query77	550	375	283	283
query78	10163	9942	9359	9359
query79	2664	813	576	576
query80	654	532	441	441
query81	479	264	219	219
query82	453	124	92	92
query83	258	248	232	232
query84	302	115	89	89
query85	769	357	320	320
query86	363	317	291	291
query87	4413	4504	4263	4263
query88	3430	2284	2263	2263
query89	396	328	280	280
query90	1646	206	201	201
query91	137	148	112	112
query92	73	59	58	58
query93	2154	935	588	588
query94	752	415	300	300
query95	363	302	280	280
query96	493	570	276	276
query97	2762	2769	2661	2661
query98	231	215	202	202
query99	1655	1405	1279	1279
Total cold run time: 295791 ms
Total hot run time: 192696 ms

@doris-robot

doris-robot commented Jun 9, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 28.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit efff7278cf7e3ee8155cdb63d6bf2ca863bdb528, data reload: false
query1	0.04	0.04	0.03
query2	0.13	0.11	0.11
query3	0.27	0.20	0.19
query4	1.59	0.19	0.19
query5	0.46	0.45	0.43
query6	1.18	0.66	0.66
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.59	0.52	0.50
query10	0.57	0.58	0.58
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.61	0.59	0.60
query14	0.79	0.81	0.80
query15	0.88	0.87	0.86
query16	0.39	0.38	0.39
query17	1.02	1.05	1.04
query18	0.23	0.21	0.21
query19	1.98	1.85	1.82
query20	0.02	0.01	0.01
query21	15.43	0.90	0.54
query22	0.75	1.34	0.66
query23	14.78	1.39	0.65
query24	6.92	1.18	0.43
query25	0.45	0.20	0.08
query26	0.66	0.18	0.14
query27	0.06	0.05	0.05
query28	9.19	0.95	0.45
query29	12.55	4.12	3.45
query30	0.25	0.10	0.07
query31	2.80	0.60	0.39
query32	3.24	0.54	0.47
query33	3.13	3.08	3.03
query34	15.75	5.09	4.47
query35	4.57	4.49	4.47
query36	0.65	0.49	0.50
query37	0.09	0.06	0.06
query38	0.06	0.05	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.12
query41	0.09	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 102.8 s
Total hot run time: 28.81 s

@github-actions

github-actionsBot commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 11, 2025
@github-actions

github-actionsBot commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jun 11, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starocean999
starocean999 merged commit dc37c86 into apache:masterJun 11, 2025
@codeDing18
codeDing18 deleted the AdminSetReplicaVersion-nereids branch June 23, 2025 07:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999starocean999starocean999 approved these changes
@dataroaringdataroaringdataroaring approved these changes
@CalvinKirsCalvinKirsAwaiting requested review from CalvinKirsCalvinKirs is a code owner
@morningmanmorningmanAwaiting requested review from morningmanmorningman is a code owner

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement adminSetReplicaVersionCommand in nereids

5 participants

@codeDing18@Thearas@doris-robot@starocean999@dataroaring