Skip to content

branch-2.1: [fix](binlog) Acquire migration lock before ingesting binlog #50663 - #50709

Merged
yiguolei merged 1 commit into
apache:branch-2.1from
w41ter:pick_50663_to_origin_branch-2.1
May 9, 2025
Merged

branch-2.1: [fix](binlog) Acquire migration lock before ingesting binlog #50663#50709
yiguolei merged 1 commit into
apache:branch-2.1from
w41ter:pick_50663_to_origin_branch-2.1

Conversation

@w41ter

Copy link
Copy Markdown
Contributor

cherry pick from #50663

@w41ter
w41ter requested a review from yiguolei as a code ownerMay 8, 2025 09:51
@w41ter

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage38.91% (10290/26444)
Line Coverage29.95% (85473/285371)
Region Coverage28.62% (44083/154031)
Branch Coverage25.35% (22556/88970)

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 8, 2025
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 45.45% (5/11) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage74.59% (19433/26052)
Line Coverage69.26% (196399/283579)
Region Coverage66.83% (119858/179344)
Branch Coverage59.87% (60250/100628)

@yiguolei
yiguolei merged commit 9422c97 into apache:branch-2.1May 9, 2025
@w41ter
w41ter deleted the pick_50663_to_origin_branch-2.1 branch May 9, 2025 06:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@w41ter@hello-stephen@yiguolei@dataroaring