Skip to content

[fix](join)Consider mark join when computing right_col_idx(#50720) - #50727

Merged
yiguolei merged 1 commit into
apache:branch-2.1from
mrhhsg:pick_fix_join
May 19, 2025
Merged

[fix](join)Consider mark join when computing right_col_idx(#50720)#50727
yiguolei merged 1 commit into
apache:branch-2.1from
mrhhsg:pick_fix_join

Conversation

@mrhhsg

Copy link
Copy Markdown
Member

What problem does this PR solve?

pick #50720

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@mrhhsg
mrhhsg requested a review from yiguolei as a code ownerMay 9, 2025 01:15
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg

Copy link
Copy Markdown
MemberAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage38.91% (10289/26445)
Line Coverage29.94% (85443/285368)
Region Coverage28.62% (44083/154036)
Branch Coverage25.35% (22557/88972)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage74.46% (19398/26053)
Line Coverage69.17% (196157/283573)
Region Coverage66.76% (119735/179349)
Branch Coverage59.83% (60205/100630)

@mrhhsg

Copy link
Copy Markdown
MemberAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/125) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage38.94% (10299/26449)
Line Coverage29.98% (85602/285493)
Region Coverage28.65% (44158/154119)
Branch Coverage25.39% (22602/89008)

@mrhhsg

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 0.00% (0/126) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage38.94% (10300/26449)
Line Coverage30.00% (85635/285493)
Region Coverage28.65% (44162/154117)
Branch Coverage25.41% (22615/89008)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 88.10% (111/126) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage74.51% (19413/26054)
Line Coverage69.21% (196350/283689)
Region Coverage66.74% (119757/179429)
Branch Coverage59.83% (60227/100664)

@mrhhsg

Copy link
Copy Markdown
MemberAuthor

run p0

@hello-stephen

Copy link
Copy Markdown
Contributor

run feut

@hello-stephen

Copy link
Copy Markdown
Contributor

run beut

@doris-robot

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 0.00% (0/130) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage39.03% (10323/26449)
Line Coverage30.04% (85771/285500)
Region Coverage28.70% (44237/154124)
Branch Coverage25.44% (22642/89012)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 88.46% (115/130) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage74.54% (19421/26054)
Line Coverage69.24% (196430/283688)
Region Coverage66.78% (119815/179429)
Branch Coverage59.82% (60222/100666)

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 19, 2025
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit 51b39d0 into apache:branch-2.1May 19, 2025
mrhhsg added a commit to mrhhsg/doris that referenced this pull request May 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mrhhsg@hello-stephen@doris-robot@BiteTheDDDDt@yiguolei