Skip to content

[Opt] (multi-catalog) opt max scanner thread number in batch split mode. - #50767

Merged
dataroaring merged 1 commit into
apache:branch-3.0from
kaka11chen:cherry-pick-44635_3.0
May 15, 2025
Merged

[Opt] (multi-catalog) opt max scanner thread number in batch split mode.#50767
dataroaring merged 1 commit into
apache:branch-3.0from
kaka11chen:cherry-pick-44635_3.0

Conversation

@kaka11chen

@kaka11chenkaka11chen commented May 9, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Release note

Cherry-pick #44635

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented May 9, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaka11chen

kaka11chen commented May 9, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@kaka11chen
[Opt] (multi-catalog) opt max scanner thread number in batch split mo…
1119687
…de. (apache#44635)
Problem Summary:
There's only one scan range for each backend in batch split mode. Each
backend only starts up one ScanNode instance. However, when calculating
the concurrency of scanners in the scan operator in batch split mode, it
is not divided by 1, but by `query_parallel_instance_num`, resulting in
poor performance of batch split mode.
@kaka11chen
kaka11chenforce-pushed the cherry-pick-44635_3.0 branch from 44f0658 to 1119687CompareMay 9, 2025 12:09
@kaka11chen

kaka11chen commented May 9, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented May 9, 2025

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 61.29% (19/31) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage40.94% (10795/26365)
Line Coverage31.81% (92168/289787)
Region Coverage30.87% (47558/154038)
Branch Coverage27.38% (24375/89018)

morningman
morningman approved these changes May 15, 2025
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 15, 2025
@github-actions

github-actionsBot commented May 15, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented May 15, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes May 15, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 49d0e72 into apache:branch-3.0May 15, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaka11chen@hello-stephen@morningman@dataroaring