Uh oh!
There was an error while loading. Please reload this page.
[Fix](cloud-mow) avoid calc delete bitmap tasks on same (txn_id, tablet_id) being executed concurrently - #50847
Conversation
Thearas
commented
May 13, 2025
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
9d515f4 to
b174c1bComparebobhan1
commented
May 13, 2025
run buildall |
doris-robot
commented
May 13, 2025
TPC-H: Total hot run time: 33931 ms |
doris-robot
commented
May 13, 2025
TPC-DS: Total hot run time: 193988 ms |
doris-robot
commented
May 13, 2025
ClickBench: Total hot run time: 29.69 s |
32959f9 to
5f80ddcComparehello-stephen
commented
May 13, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
bobhan1
commented
May 14, 2025
run p0 |
bobhan1
commented
May 14, 2025
run cloud_p0 |
bobhan1
commented
May 14, 2025
run p0 |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
zhannngchen
commented
May 14, 2025
run be ut |
zhannngchen
commented
May 14, 2025
run buildall |
doris-robot
commented
May 14, 2025
TPC-H: Total hot run time: 34087 ms |
doris-robot
commented
May 14, 2025
TPC-DS: Total hot run time: 186425 ms |
doris-robot
commented
May 14, 2025
ClickBench: Total hot run time: 29.38 s |
hello-stephen
commented
May 14, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
May 14, 2025
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
hello-stephen
commented
May 14, 2025
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
May 14, 2025
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
bobhan1
commented
May 15, 2025
run feut |
…et_id) being executed concurrently (apache#50847) After apache#50417, there may be multiple calc delete bitmap tasks with different signatures on the same (txn_id, tablet_id) load in same BE. We use _rowset_update_lock to avoid them being executed concurrently to avoid correctness problem. e.g. rowset meta and segment data object mismatches due to concurrent writes on same rowset with transient rowset writer in partial update publish phase ``` W20250513 15:50:55.371588 1049 file_reader.cpp:36] [NOT_FOUND]failed to read from : code=NOT_FOUND, type=16, request_id=failed to read W20250513 15:50:55.371667 1049 beta_rowset.cpp:202] failed to open segment. data/1747122561886/020000000000000125473fbacc484a4f8c46478ab6f64b90_2.dat under rowset 020000000000000125473fbacc484a4f8c46478ab6f64b90 : [NOT_FOUND]failed to read from : code=NOT_FOUND, type=16, request_id=failed to read ```
…et_id) being executed concurrently (apache#50847) ### What problem does this PR solve? After apache#50417, there may be multiple calc delete bitmap tasks with different signatures on the same (txn_id, tablet_id) load in same BE. We use _rowset_update_lock to avoid them being executed concurrently to avoid correctness problem. e.g. rowset meta and segment data object mismatches due to concurrent writes on same rowset with transient rowset writer in partial update publish phase ``` W20250513 15:50:55.371588 1049 file_reader.cpp:36] [NOT_FOUND]failed to read from : code=NOT_FOUND, type=16, request_id=failed to read W20250513 15:50:55.371667 1049 beta_rowset.cpp:202] failed to open segment. data/1747122561886/020000000000000125473fbacc484a4f8c46478ab6f64b90_2.dat under rowset 020000000000000125473fbacc484a4f8c46478ab6f64b90 : [NOT_FOUND]failed to read from : code=NOT_FOUND, type=16, request_id=failed to read ```
What problem does this PR solve?
After #50417, there may be multiple calc delete bitmap tasks with different signatures on the same (txn_id, tablet_id) load in same BE. We use _rowset_update_lock to avoid them being executed concurrently to avoid correctness problem.
e.g. rowset meta and segment data object mismatches due to concurrent writes on same rowset with transient rowset writer in partial update publish phase
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)