Uh oh!
There was an error while loading. Please reload this page.
[feat](refactor-param) refactor brokerLoad's code about fileformat - #50882
Merged
Conversation
BePPPower
requested review from
dataroaring, morningman, xiaokang and yiguolei
as code ownersMay 14, 2025 03:46
hello-stephen
commented
May 14, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
BePPPower
commented
May 14, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 14, 2025
TPC-H: Total hot run time: 34291 ms |
doris-robot
commented
May 14, 2025
TPC-DS: Total hot run time: 193146 ms |
doris-robot
commented
May 14, 2025
ClickBench: Total hot run time: 29.99 s |
BePPPower
commented
May 15, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 15, 2025
TPC-H: Total hot run time: 33898 ms |
doris-robot
commented
May 15, 2025
TPC-DS: Total hot run time: 185342 ms |
doris-robot
commented
May 15, 2025
ClickBench: Total hot run time: 29.22 s |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| getOrigStmt() != null ? getOrigStmt().originStmt : "", copyFromParam.getFileColumns(), | ||
| copyFromParam.getColumnMappingList(), copyFromParam.getFileFilterExpr()); | ||
| } | ||
| dataDescProperties.put(FileFormatProperties.PROP_COMPRESS_TYPE, copyIntoProperties.getCompression()); |
Contributor
There was a problem hiding this comment.
There are some format properties in copyIntoProperties. I think we should remove them too. But may be in next PR.
Uh oh!
There was an error while loading. Please reload this page.
BePPPower
commented
May 16, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 16, 2025
TPC-H: Total hot run time: 34298 ms |
doris-robot
commented
May 16, 2025
TPC-DS: Total hot run time: 193435 ms |
doris-robot
commented
May 16, 2025
ClickBench: Total hot run time: 28.92 s |
BePPPower
commented
May 19, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 19, 2025
TPC-H: Total hot run time: 33601 ms |
doris-robot
commented
May 19, 2025
TPC-DS: Total hot run time: 192319 ms |
doris-robot
commented
May 19, 2025
ClickBench: Total hot run time: 28.72 s |
BePPPower
commented
May 20, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 20, 2025
TPC-H: Total hot run time: 34431 ms |
doris-robot
commented
May 20, 2025
TPC-DS: Total hot run time: 192903 ms |
doris-robot
commented
May 20, 2025
ClickBench: Total hot run time: 29.17 s |
BePPPower
commented
May 20, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 20, 2025
TPC-H: Total hot run time: 34195 ms |
doris-robot
commented
May 20, 2025
TPC-DS: Total hot run time: 186551 ms |
morningmanforce-pushed
the
refactorBrokerLoad4
branch
from
May 24, 2025 02:44
ad81c8d to
3a0eccaComparemorningman
commented
May 24, 2025
Contributor
run buildall |
doris-robot
commented
May 24, 2025
TPC-H: Total hot run time: 34076 ms |
doris-robot
commented
May 24, 2025
TPC-DS: Total hot run time: 195464 ms |
doris-robot
commented
May 24, 2025
ClickBench: Total hot run time: 29.41 s |
BePPPower
commented
May 26, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 26, 2025
TPC-H: Total hot run time: 34440 ms |
doris-robot
commented
May 26, 2025
TPC-DS: Total hot run time: 185738 ms |
doris-robot
commented
May 26, 2025
ClickBench: Total hot run time: 29.15 s |
BePPPower
commented
May 27, 2025
ContributorAuthor
run external |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…pache#50882) Issue Number:apache#50238 Problem Summary: Previously, we refactored the code of the fileFormat attribute (apache#50225). However, we only added the relevant code without modifying the business code. This pull request modifies the code of the BrokerLoad feature that is related to the fileformat.
CalvinKirs pushed a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Jun 27, 2025
…leformat (apache#50882) apache#50882 (cherry picked from commit 0b95a4d)
morningman pushed a commit
to morningman/doris
that referenced
this pull request
Jul 12, 2025
…pache#50882) Issue Number:apache#50238 Problem Summary: Previously, we refactored the code of the fileFormat attribute (apache#50225). However, we only added the relevant code without modifying the business code. This pull request modifies the code of the BrokerLoad feature that is related to the fileformat.
This was referenced Jul 12, 2025
Merged
morrySnow pushed a commit
that referenced
this pull request
Jul 14, 2025
morningman added a commit
that referenced
this pull request
Jul 15, 2025
### What problem does this PR solve? Related PR: #50882
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number:#50238
Problem Summary:
Previously, we refactored the code of the fileFormat attribute (#50225). However, we only added the relevant code without modifying the business code. This pull request modifies the code of the BrokerLoad feature that is related to the fileformat.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)