Skip to content

[Bug](cancel) fix ctrl+c can not cancel query - #50916

Closed
BiteTheDDDDt wants to merge 8 commits into
apache:masterfrom
BiteTheDDDDt:fix_0514_4
Closed

[Bug](cancel) fix ctrl+c can not cancel query#50916
BiteTheDDDDt wants to merge 8 commits into
apache:masterfrom
BiteTheDDDDt:fix_0514_4

Conversation

@BiteTheDDDDt

@BiteTheDDDDtBiteTheDDDDt commented May 14, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

before

mysql>selectcount(*) from d_table;
+----------+
| count(*) |
+----------+
| 10000000 |
+----------+1 row inset (0.23 sec)
mysql>select*from d_table;
^C^C -- query aborted+---------+---------+---------+------+
| k1 | k2 | k3 | k4 |
+---------+---------+---------+------+
| 2 | 2 | 2 | a |
+---------+---------+---------+------+10000000 rows inset (1 min 6.28 sec)

after:

mysql>select*from d_table;
^C^C -- query aborted
ERROR 1105 (HY000): errCode =2, detailMessage = cancel query by user from127.0.0.1:53598

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@Thearas

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.32% (20833/26264)
Line Coverage72.50% (214326/295627)
Region Coverage70.67% (126057/178381)
Branch Coverage64.45% (65339/101386)

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage55.82% (14903/26698)
Line Coverage44.61% (131937/295750)
Region Coverage43.66% (66331/151920)
Branch Coverage38.27% (33983/88798)

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.25% (20813/26264)
Line Coverage72.46% (214270/295689)
Region Coverage70.65% (126065/178432)
Branch Coverage64.38% (65295/101414)

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage55.87% (14883/26641)
Line Coverage44.65% (131877/295362)
Region Coverage43.76% (66396/151731)
Branch Coverage38.36% (34020/88690)

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

This problem has been fixed in #50791, so close the PR

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@BiteTheDDDDt@Thearas@hello-stephen