Skip to content

[fix](iceberg)Table operations are not supported for catalogs of the dlf type for nereids - #50936

Merged
hello-stephen merged 1 commit into
apache:masterfrom
wuwenchi:fix-dlf2
May 15, 2025
Merged

[fix](iceberg)Table operations are not supported for catalogs of the dlf type for nereids#50936
hello-stephen merged 1 commit into
apache:masterfrom
wuwenchi:fix-dlf2

Conversation

@wuwenchi

@wuwenchiwuwenchi commented May 15, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

followUp: #50696

Problem Summary:

conflict with #50196

Table operations are not supported for catalogs of the dlf type for nereids.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented May 15, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wuwenchi

wuwenchi commented May 15, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented May 15, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33563 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6cbbb1c9c03ed1bb5ecceadc7178ebb1cd276370, data reload: false
------ Round 1 ----------------------------------
q1	25796	5075	4948	4948
q2	2070	279	193	193
q3	10386	1243	695	695
q4	10225	1005	513	513
q5	7524	2342	2308	2308
q6	175	163	131	131
q7	899	741	617	617
q8	9319	1284	1012	1012
q9	6946	5087	5121	5087
q10	6878	2297	1869	1869
q11	482	284	294	284
q12	338	352	217	217
q13	17776	3691	3107	3107
q14	227	225	227	225
q15	516	481	486	481
q16	419	427	375	375
q17	589	856	372	372
q18	7561	7204	7099	7099
q19	2054	962	555	555
q20	336	320	211	211
q21	3720	3103	2323	2323
q22	1048	977	941	941
Total cold run time: 115284 ms
Total hot run time: 33563 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5131	5035	5006	5006
q2	240	323	240	240
q3	2143	2638	2231	2231
q4	1348	1750	1363	1363
q5	4377	4410	4407	4407
q6	217	171	127	127
q7	1975	1925	1787	1787
q8	2572	2570	2452	2452
q9	7197	7173	7031	7031
q10	3007	3171	2739	2739
q11	581	512	500	500
q12	662	759	596	596
q13	3479	3866	3288	3288
q14	295	314	294	294
q15	533	478	469	469
q16	450	475	436	436
q17	1152	1528	1412	1412
q18	7621	7632	7402	7402
q19	781	846	1098	846
q20	1988	1971	1844	1844
q21	4738	4468	4404	4404
q22	1081	1046	992	992
Total cold run time: 51568 ms
Total hot run time: 49866 ms

@doris-robot

doris-robot commented May 15, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 193375 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6cbbb1c9c03ed1bb5ecceadc7178ebb1cd276370, data reload: false
query1	1417	1092	1055	1055
query2	6195	1784	1790	1784
query3	11027	4412	4618	4412
query4	51679	24098	23447	23447
query5	5255	585	472	472
query6	357	236	196	196
query7	4905	516	292	292
query8	338	268	245	245
query9	5630	2668	2659	2659
query10	445	323	283	283
query11	15119	15066	14952	14952
query12	160	113	108	108
query13	1040	522	429	429
query14	10025	6321	6257	6257
query15	212	195	188	188
query16	7050	666	530	530
query17	1090	770	586	586
query18	1547	404	327	327
query19	202	200	177	177
query20	130	133	128	128
query21	216	131	113	113
query22	4469	4484	4299	4299
query23	34448	33733	33338	33338
query24	6660	2374	2405	2374
query25	481	459	423	423
query26	756	274	155	155
query27	2393	543	356	356
query28	3005	2154	2144	2144
query29	651	577	434	434
query30	281	222	187	187
query31	889	849	772	772
query32	77	66	65	65
query33	471	362	302	302
query34	808	863	545	545
query35	790	817	769	769
query36	923	991	880	880
query37	133	102	74	74
query38	4243	4335	4218	4218
query39	1502	1485	1456	1456
query40	217	122	112	112
query41	54	54	50	50
query42	130	116	106	106
query43	507	511	484	484
query44	1324	855	828	828
query45	183	172	166	166
query46	860	1052	661	661
query47	1881	1899	1798	1798
query48	409	432	323	323
query49	718	539	451	451
query50	674	698	411	411
query51	4215	4370	4222	4222
query52	107	111	98	98
query53	226	263	193	193
query54	617	595	525	525
query55	87	86	85	85
query56	314	290	291	290
query57	1173	1202	1171	1171
query58	267	255	264	255
query59	2708	2798	2660	2660
query60	337	325	317	317
query61	135	129	129	129
query62	742	722	674	674
query63	228	187	195	187
query64	2599	1044	741	741
query65	4260	4239	4189	4189
query66	779	393	326	326
query67	15914	15640	15280	15280
query68	8387	887	530	530
query69	533	315	269	269
query70	1206	1126	1156	1126
query71	501	322	301	301
query72	5987	4879	4975	4879
query73	1435	718	364	364
query74	9017	9105	9064	9064
query75	4084	3246	2752	2752
query76	4166	1186	842	842
query77	752	373	280	280
query78	10040	10117	9395	9395
query79	4616	781	570	570
query80	632	516	446	446
query81	492	251	218	218
query82	570	130	99	99
query83	295	248	237	237
query84	297	104	81	81
query85	831	356	313	313
query86	380	301	285	285
query87	4391	4451	4240	4240
query88	3885	2250	2296	2250
query89	439	307	285	285
query90	1937	208	206	206
query91	144	142	110	110
query92	71	60	55	55
query93	3194	939	575	575
query94	664	387	320	320
query95	377	300	291	291
query96	511	576	282	282
query97	3165	3201	3106	3106
query98	237	207	194	194
query99	1429	1387	1247	1247
Total cold run time: 303349 ms
Total hot run time: 193375 ms

@doris-robot

doris-robot commented May 15, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 28.84 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6cbbb1c9c03ed1bb5ecceadc7178ebb1cd276370, data reload: false
query1	0.04	0.04	0.03
query2	0.11	0.10	0.11
query3	0.25	0.19	0.19
query4	1.59	0.18	0.18
query5	0.59	0.58	0.59
query6	1.16	0.72	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.58	0.51	0.51
query10	0.55	0.60	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.61	0.60
query14	0.79	0.79	0.83
query15	0.86	0.86	0.84
query16	0.39	0.39	0.38
query17	1.04	1.09	1.04
query18	0.22	0.21	0.21
query19	1.91	1.76	1.82
query20	0.01	0.01	0.01
query21	15.42	0.90	0.54
query22	0.76	1.19	0.74
query23	14.81	1.38	0.62
query24	7.61	1.54	0.37
query25	0.44	0.19	0.08
query26	0.74	0.16	0.13
query27	0.05	0.06	0.05
query28	8.92	0.94	0.45
query29	12.53	3.99	3.32
query30	0.27	0.10	0.07
query31	2.81	0.59	0.38
query32	3.23	0.55	0.48
query33	3.01	3.05	3.07
query34	15.70	5.09	4.49
query35	4.54	4.49	4.50
query36	0.64	0.49	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.14
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 103.04 s
Total hot run time: 28.84 s

@hello-stephen

hello-stephen commented May 15, 2025

Copy link
Copy Markdown
Contributor

skip buildall

hello-stephen
hello-stephen approved these changes May 15, 2025
View reviewed changes

@hello-stephenhello-stephen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 15, 2025
@github-actions

github-actionsBot commented May 15, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented May 15, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
hello-stephen merged commit 345cbd2 into apache:masterMay 15, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@wuwenchikoarz
[fix](iceberg)Table operations are not supported for catalogs of the …
140caef
…dlf type for nereids (apache#50936)
### What problem does this PR solve?
followUp: apache#50696
Problem Summary:
conflict with apache#50196
Table operations are not supported for catalogs of the dlf type for
nereids.
morningman pushed a commit to morningman/doris that referenced this pull request Jul 1, 2025
@wuwenchi@morningman
[fix](iceberg)Table operations are not supported for catalogs of the …
2f68bc4
…dlf type for nereids (apache#50936)
followUp: apache#50696
Problem Summary:
conflict with apache#50196
Table operations are not supported for catalogs of the dlf type for
nereids.
@morningmanmorningman mentioned this pull request Jul 1, 2025
Merged
morningman pushed a commit to morningman/doris that referenced this pull request Jul 1, 2025
@wuwenchi@morningman
[fix](iceberg)Table operations are not supported for catalogs of the …
2d11e21
…dlf type for nereids (apache#50936)
followUp: apache#50696
Problem Summary:
conflict with apache#50196
Table operations are not supported for catalogs of the dlf type for
nereids.
morningman pushed a commit to morningman/doris that referenced this pull request Jul 3, 2025
@wuwenchi@morningman
[fix](iceberg)Table operations are not supported for catalogs of the …
b027049
…dlf type for nereids (apache#50936)
followUp: apache#50696
Problem Summary:
conflict with apache#50196
Table operations are not supported for catalogs of the dlf type for
nereids.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDtBiteTheDDDDtBiteTheDDDDt approved these changes
@hello-stephenhello-stephenhello-stephen approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wuwenchi@Thearas@doris-robot@hello-stephen@BiteTheDDDDt@morningman