Skip to content

[Fix](ShortCircuit) fix crash when enable skip_delete_sign - #50941

Merged
eldenmoon merged 1 commit into
apache:masterfrom
eldenmoon:fix-skip_delete_sign
May 16, 2025
Merged

[Fix](ShortCircuit) fix crash when enable skip_delete_sign#50941
eldenmoon merged 1 commit into
apache:masterfrom
eldenmoon:fix-skip_delete_sign

Conversation

@eldenmoon

@eldenmooneldenmoon commented May 15, 2025

Copy link
Copy Markdown
Member

ignore delete sign when skip_delete_sign = true

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented May 15, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
[Fix](ShortCircuit) fix crash when enable skip_delete_sign
66ca5b3
ignore delete sign when `skip_delete_sign = true`
@eldenmoon
eldenmoonforce-pushed the fix-skip_delete_sign branch from a19e436 to 66ca5b3CompareMay 15, 2025 08:00
@eldenmoon

eldenmoon commented May 15, 2025

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

doris-robot commented May 15, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33988 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 66ca5b3ccdaea9cfe25e4e8586fcf78205058be8, data reload: false
------ Round 1 ----------------------------------
q1	26376	5192	5003	5003
q2	2079	275	197	197
q3	10379	1227	719	719
q4	10219	1018	550	550
q5	7545	2397	2351	2351
q6	183	164	132	132
q7	903	749	624	624
q8	9330	1327	1112	1112
q9	6833	5092	5261	5092
q10	6809	2314	1907	1907
q11	492	290	271	271
q12	343	347	221	221
q13	17744	3720	3101	3101
q14	219	223	220	220
q15	531	498	481	481
q16	433	442	377	377
q17	615	874	380	380
q18	7615	7235	7062	7062
q19	1218	958	576	576
q20	350	360	236	236
q21	4134	3176	2412	2412
q22	1083	1035	964	964
Total cold run time: 115433 ms
Total hot run time: 33988 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5444	5088	5123	5088
q2	237	330	226	226
q3	2277	2651	2334	2334
q4	1400	1872	1488	1488
q5	4566	4435	4387	4387
q6	211	178	128	128
q7	2034	1896	1751	1751
q8	2603	2587	2534	2534
q9	7121	7200	7086	7086
q10	2991	3171	2746	2746
q11	574	518	498	498
q12	686	779	605	605
q13	3453	3884	3291	3291
q14	291	305	278	278
q15	515	467	483	467
q16	431	488	452	452
q17	1149	1538	1369	1369
q18	7799	7466	7463	7463
q19	847	916	1053	916
q20	1960	2060	1898	1898
q21	4814	4276	4321	4276
q22	1107	1065	997	997
Total cold run time: 52510 ms
Total hot run time: 50278 ms

@doris-robot

doris-robot commented May 15, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 186851 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 66ca5b3ccdaea9cfe25e4e8586fcf78205058be8, data reload: false
query1	1002	484	495	484
query2	6566	1927	1877	1877
query3	6759	222	223	222
query4	26104	23761	24276	23761
query5	4626	617	461	461
query6	287	195	195	195
query7	4631	490	303	303
query8	283	254	234	234
query9	8639	2610	2625	2610
query10	475	328	274	274
query11	15437	15469	14790	14790
query12	152	111	110	110
query13	1644	520	390	390
query14	9205	6282	6129	6129
query15	202	190	164	164
query16	7172	624	490	490
query17	1179	718	572	572
query18	1989	388	296	296
query19	188	182	157	157
query20	128	118	117	117
query21	215	123	104	104
query22	4106	4191	3951	3951
query23	34052	33232	33197	33197
query24	8493	2366	2390	2366
query25	552	463	386	386
query26	1236	266	157	157
query27	2760	500	348	348
query28	4393	2086	2078	2078
query29	769	577	437	437
query30	283	220	193	193
query31	950	825	783	783
query32	75	71	67	67
query33	576	378	320	320
query34	791	866	526	526
query35	817	819	736	736
query36	938	978	900	900
query37	113	104	84	84
query38	4149	4135	4086	4086
query39	1483	1449	1429	1429
query40	218	128	118	118
query41	69	60	64	60
query42	131	115	112	112
query43	523	502	485	485
query44	1277	808	820	808
query45	180	172	170	170
query46	842	1037	659	659
query47	1797	1821	1734	1734
query48	394	434	306	306
query49	766	513	430	430
query50	666	699	403	403
query51	4148	4162	4080	4080
query52	108	105	98	98
query53	218	255	211	211
query54	580	567	490	490
query55	88	88	84	84
query56	311	306	280	280
query57	1142	1133	1101	1101
query58	275	255	258	255
query59	2667	2736	2599	2599
query60	329	333	306	306
query61	138	132	128	128
query62	823	727	656	656
query63	224	190	190	190
query64	4366	1020	673	673
query65	4373	4270	4261	4261
query66	1146	428	313	313
query67	16006	15585	15335	15335
query68	7225	869	522	522
query69	479	318	284	284
query70	1217	1145	1062	1062
query71	410	321	310	310
query72	5767	4844	4929	4844
query73	705	665	350	350
query74	9256	9224	8968	8968
query75	3183	3201	2736	2736
query76	3193	1194	741	741
query77	478	375	288	288
query78	9904	10163	9364	9364
query79	1429	842	572	572
query80	593	530	444	444
query81	496	258	273	258
query82	175	128	95	95
query83	261	254	237	237
query84	245	109	92	92
query85	761	354	306	306
query86	370	283	283	283
query87	4376	4450	4325	4325
query88	2886	2289	2303	2289
query89	387	310	286	286
query90	1870	211	214	211
query91	144	144	113	113
query92	75	58	59	58
query93	1204	953	646	646
query94	659	425	310	310
query95	380	286	287	286
query96	492	578	282	282
query97	2738	2731	2639	2639
query98	226	210	202	202
query99	1308	1396	1319	1319
Total cold run time: 270116 ms
Total hot run time: 186851 ms

@doris-robot

doris-robot commented May 15, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.43 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 66ca5b3ccdaea9cfe25e4e8586fcf78205058be8, data reload: false
query1	0.04	0.04	0.03
query2	0.13	0.11	0.11
query3	0.26	0.20	0.19
query4	1.58	0.20	0.10
query5	0.43	0.41	0.43
query6	1.17	0.65	0.66
query7	0.02	0.01	0.01
query8	0.05	0.03	0.03
query9	0.59	0.51	0.52
query10	0.57	0.58	0.57
query11	0.16	0.12	0.11
query12	0.14	0.12	0.12
query13	0.61	0.61	0.60
query14	0.79	0.80	0.82
query15	0.89	0.85	0.86
query16	0.39	0.38	0.38
query17	1.09	1.06	1.09
query18	0.22	0.21	0.22
query19	2.00	1.91	1.87
query20	0.02	0.01	0.01
query21	15.40	0.91	0.53
query22	0.77	1.28	0.77
query23	14.72	1.39	0.64
query24	6.92	1.89	0.98
query25	0.51	0.17	0.15
query26	0.56	0.17	0.15
query27	0.05	0.05	0.06
query28	9.84	0.92	0.44
query29	12.54	3.99	3.27
query30	0.25	0.10	0.08
query31	2.82	0.60	0.38
query32	3.23	0.54	0.46
query33	3.02	3.02	3.15
query34	15.89	5.14	4.52
query35	4.55	4.57	4.56
query36	0.69	0.50	0.48
query37	0.08	0.06	0.07
query38	0.05	0.05	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.05	0.03	0.03
Total cold run time: 103.41 s
Total hot run time: 29.43 s

@hello-stephen

hello-stephen commented May 15, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.33% (20834/26264)
Line Coverage72.51% (214416/295695)
Region Coverage70.67% (126105/178436)
Branch Coverage64.45% (65364/101418)

airborne12
airborne12 approved these changes May 16, 2025
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 16, 2025
@github-actions

github-actionsBot commented May 16, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented May 16, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

csun5285
csun5285 approved these changes May 16, 2025
View reviewed changes

@csun5285csun5285 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon
eldenmoon merged commit 7b259d3 into apache:masterMay 16, 2025
@eldenmoon
eldenmoon deleted the fix-skip_delete_sign branch May 16, 2025 02:33
github-actionsBot pushed a commit that referenced this pull request May 16, 2025
@eldenmoonYour Name
[Fix](ShortCircuit) fix crash when enableskip_delete_sign(#50941)
6b34d0d
ignore delete sign when `skip_delete_sign = true`
@github-actionsgithub-actionsBot mentioned this pull request May 16, 2025
Merged
dataroaring pushed a commit that referenced this pull request May 16, 2025
@github-actions@eldenmoon
branch-3.0: [Fix](ShortCircuit) fix crash when enable `skip_delete_si…
e3fcc87
…gn` #50941 (#50965)
Cherry-picked from #50941
Co-authored-by: lihangyu <lihangyu@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@eldenmoonkoarz
[Fix](ShortCircuit) fix crash when enableskip_delete_sign(apache#…
6fb9be1
…50941)
ignore delete sign when `skip_delete_sign = true`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12airborne12airborne12 approved these changes
@csun5285csun5285csun5285 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.6-mergedp0_breviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@eldenmoon@Thearas@doris-robot@hello-stephen@airborne12@csun5285@dataroaring