Uh oh!
There was an error while loading. Please reload this page.
[fix](mow) remove delete bitmap when remove unused rowsets - #50973
Conversation
hello-stephen
commented
May 16, 2025
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
99861a4 to
b61a0d4Comparemymeiyi
commented
May 19, 2025
run buildall |
doris-robot
commented
May 19, 2025
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
doris-robot
commented
May 19, 2025
TPC-H: Total hot run time: 33516 ms |
doris-robot
commented
May 19, 2025
TPC-DS: Total hot run time: 192162 ms |
doris-robot
commented
May 19, 2025
ClickBench: Total hot run time: 29.84 s |
doris-robot
commented
May 19, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
May 19, 2025
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
mymeiyi
commented
May 22, 2025
run buildall |
hello-stephen
commented
May 22, 2025
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
doris-robot
commented
May 22, 2025
TPC-H: Total hot run time: 34029 ms |
doris-robot
commented
May 22, 2025
TPC-DS: Total hot run time: 187204 ms |
doris-robot
commented
May 22, 2025
ClickBench: Total hot run time: 28.64 s |
90cacd7 to
793d140Comparemymeiyi
commented
May 30, 2025
run buildall |
doris-robot
commented
May 30, 2025
TPC-H: Total hot run time: 33799 ms |
doris-robot
commented
May 30, 2025
TPC-DS: Total hot run time: 185465 ms |
doris-robot
commented
May 30, 2025
ClickBench: Total hot run time: 29.36 s |
mymeiyi
commented
Jun 4, 2025
run buildall |
doris-robot
commented
Jun 4, 2025
TPC-H: Total hot run time: 35039 ms |
hello-stephen
commented
Jun 6, 2025
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
| << "tablet_id=" << tablet_id() | ||
| << ", rowset_id=" << rs->rowset_id().to_string() | ||
| << ", existed rowset=" << find_it->second->rowset_id().to_string(); | ||
| _unused_rowsets.emplace(find_it->second->rowset_id(), find_it->second); |
There was a problem hiding this comment.
does here need std::lock_guard < std::mutex > lock(_gc_mutex);?
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
What problem does this PR solve?
now, the delete bitmap is removed when move stale rowsets to unused rowsets, but if some queries is still read the stale rowsets, the query result may get duplicated keys.
this pr change the remove of delete bitmap when remove unused rowsets.
this pr is based on #49383
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)