Uh oh!
There was an error while loading. Please reload this page.
[refine](DataTypeSerDe) Remove the level variable from FormatOptions and use _nesting_level. - #50977
Merged
Merged
Conversation
Thearas
commented
May 16, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Mryange
commented
May 16, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 16, 2025
TPC-H: Total hot run time: 33814 ms |
doris-robot
commented
May 16, 2025
TPC-DS: Total hot run time: 186478 ms |
doris-robot
commented
May 16, 2025
ClickBench: Total hot run time: 29.67 s |
doris-robot
commented
May 16, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
May 16, 2025
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Gabriel39
approved these changes
May 20, 2025
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
BiteTheDDDDt
approved these changes
May 21, 2025
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…and use _nesting_level. (apache#50977) We don't need to maintain a separate level; we can achieve the functionality of this apache#49036 by directly using _nesting_level. ```C++ // This parameter indicates what level the serde belongs to and is mainly used for complex types // The default level is 1, and each time you nest, the level increases by 1, // for example: struct<string> // The _nesting_level of StructSerde is 1 // The _nesting_level of StringSerde is 2 int _nesting_level = 1; ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
We don't need to maintain a separate level; we can achieve the functionality of this #49036 by directly using _nesting_level.
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)