Skip to content

add BE udf bitmap xor - #5098

Merged
morningman merged 13 commits into
apache:masterfrom
lihuigang:master
Jan 4, 2021
Merged

add BE udf bitmap xor#5098
morningman merged 13 commits into
apache:masterfrom
lihuigang:master

Conversation

@lihuigang

@lihuiganglihuigang commented Dec 17, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

this function will return the xor result of inputs two bitmap .

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fixsupport bitmap xor #2536), and have described the bug/feature there in detail
  • [] Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

morningman
morningman reviewed Dec 18, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you please add document for this new function?

@morningmanmorningman added the area/sql/function Issues or PRs related to the SQL functions label Dec 18, 2020
@lihuigang

lihuigang commented Dec 19, 2020

Copy link
Copy Markdown
ContributorAuthor

Yes ,I'd like to

@lihuiganglihuigang reopened this Dec 23, 2020
@lihuigang

lihuigang commented Dec 26, 2020

Copy link
Copy Markdown
ContributorAuthor

hi,I've added documents

@lihuiganglihuigang reopened this Dec 26, 2020
morningman
morningman reviewed Dec 26, 2020
View reviewed changes
Comment threadbe/src/exprs/bitmap_function.cpp Outdated
Comment thread.rat-excludes
@@ -1,33 +0,0 @@
.*json

@morningmanmorningmanDec 26, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete this file?

@lihuiganglihuigangDec 26, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I accidentally deleted

@lihuiganglihuigangDec 28, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

您好，这个文件已经恢复了~

Comment threadbe/src/util/bitmap_value.h Outdated
lihuigangand others added 4 commits December 26, 2020 21:39
lihuigang
recover .rat-excludes
a5628a1
@lihuigang@morningman
Update be/src/util/bitmap_value.h
7e774c4
thanks
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
@lihuigang@morningman
Update be/src/exprs/bitmap_function.cpp
4a0bf8f
thanks
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
lihuigang
remove blank lines
ce69a11
@lihuiganglihuigang reopened this Dec 28, 2020
@lihuiganglihuigang reopened this Dec 28, 2020
@lihuiganglihuigang reopened this Dec 28, 2020
morningman
morningman approved these changes Jan 3, 2021
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Jan 3, 2021
@morningman
morningman merged commit 05ac7fc into apache:masterJan 4, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
@lihuigang@morningman-cmy
[Function] Add BE udf bitmap_xor (apache#5098)
da9acb4
this function will return the xor result of inputs two bitmap .
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Closed
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 30, 2025
@selectdb-robot@englefly
branch-selectdb-doris-3.0: [fix](nereids) partition topn optimization…
135dd1e
… requires all window expressions are in the same order apache#56622 (apache#5752)
cherry-picks from apache#56622
Related to apache#5098
Co-authored-by: minghong <zhouminghong@selectdb.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/sql/functionIssues or PRs related to the SQL functions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support bitmap xor

2 participants

@lihuigang@morningman