Skip to content

[improvement](jdbc catalog) Optimize the acquisition of indentity type in SQLServer - #51285

Merged
zy-kkk merged 3 commits into
apache:masterfrom
zy-kkk:sql_server_identity
May 28, 2025
Merged

[improvement](jdbc catalog) Optimize the acquisition of indentity type in SQLServer#51285
zy-kkk merged 3 commits into
apache:masterfrom
zy-kkk:sql_server_identity

Conversation

@zy-kkk

@zy-kkkzy-kkk commented May 27, 2025•
edited
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

1、In SQLServer, if a type is indentity, then the display of its original type may be changed, such as decimal -> decima(), so we get the string from subscript 0 to ( before as typename
2、For decimal, we should use the unified createDecimalOrStringType method to build the type

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zy-kkk

zy-kkk commented May 27, 2025

Copy link
Copy Markdown
MemberAuthor

run buildall

@zy-kkkzy-kkk added usercase Important user case type label dev/2.1.x dev/3.0.x labels May 27, 2025
@hello-stephen

hello-stephen commented May 27, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

morningman
morningman previously approved these changes May 27, 2025
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented May 27, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels May 27, 2025
@github-actions

github-actionsBot commented May 27, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented May 27, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 34117 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7c7a767a8f696a13cdf05733809297d16668f5d4, data reload: false
------ Round 1 ----------------------------------
q1	26445	5076	5107	5076
q2	2066	274	195	195
q3	10502	1293	716	716
q4	10233	1000	546	546
q5	7865	2418	2396	2396
q6	186	170	133	133
q7	924	751	617	617
q8	9320	1287	1161	1161
q9	6947	5103	5113	5103
q10	6873	2279	1898	1898
q11	494	342	284	284
q12	351	366	219	219
q13	17794	3702	3114	3114
q14	228	224	223	223
q15	547	478	497	478
q16	419	428	375	375
q17	608	863	368	368
q18	7684	7165	7059	7059
q19	1940	968	566	566
q20	329	332	224	224
q21	4038	3173	2384	2384
q22	1048	1013	982	982
Total cold run time: 116841 ms
Total hot run time: 34117 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5214	5090	5058	5058
q2	236	326	227	227
q3	2146	2669	2312	2312
q4	1375	1978	1532	1532
q5	4538	4442	4341	4341
q6	216	169	131	131
q7	1948	1902	1795	1795
q8	2867	2537	2530	2530
q9	7189	7068	7057	7057
q10	3012	3151	2748	2748
q11	567	516	493	493
q12	677	772	626	626
q13	3579	3969	3367	3367
q14	281	286	260	260
q15	530	489	483	483
q16	442	478	451	451
q17	1153	1543	1378	1378
q18	7742	7619	7460	7460
q19	807	908	983	908
q20	2012	2013	1796	1796
q21	4750	4300	4229	4229
q22	1098	1003	967	967
Total cold run time: 52379 ms
Total hot run time: 50149 ms

@doris-robot

doris-robot commented May 27, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 185743 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c7a767a8f696a13cdf05733809297d16668f5d4, data reload: false
query1	1020	494	482	482
query2	6552	1918	1871	1871
query3	6759	224	217	217
query4	26662	23262	22997	22997
query5	4412	639	506	506
query6	310	216	192	192
query7	4621	495	293	293
query8	296	252	242	242
query9	8642	2622	2632	2622
query10	479	334	268	268
query11	15530	15253	14971	14971
query12	160	112	106	106
query13	1663	542	425	425
query14	8731	6196	6436	6196
query15	218	192	165	165
query16	7131	615	486	486
query17	1184	717	583	583
query18	1994	391	300	300
query19	189	186	158	158
query20	117	116	118	116
query21	215	122	108	108
query22	4020	4267	4107	4107
query23	34103	33112	33066	33066
query24	8423	2406	2402	2402
query25	538	445	395	395
query26	1229	273	158	158
query27	2745	498	339	339
query28	4331	2112	2093	2093
query29	793	541	461	461
query30	287	212	183	183
query31	917	865	751	751
query32	75	65	63	63
query33	539	382	331	331
query34	805	875	516	516
query35	781	783	731	731
query36	928	994	892	892
query37	113	100	84	84
query38	4110	4108	4064	4064
query39	1536	1404	1408	1404
query40	215	123	107	107
query41	68	65	56	56
query42	123	116	107	107
query43	513	512	488	488
query44	1337	800	803	800
query45	175	183	168	168
query46	861	1034	645	645
query47	1746	1787	1695	1695
query48	389	426	314	314
query49	768	525	446	446
query50	642	690	405	405
query51	4184	4102	4194	4102
query52	114	117	99	99
query53	220	265	192	192
query54	581	571	521	521
query55	84	86	84	84
query56	315	313	312	312
query57	1125	1164	1107	1107
query58	270	267	258	258
query59	2661	2772	2615	2615
query60	340	332	319	319
query61	150	146	144	144
query62	827	731	678	678
query63	241	203	199	199
query64	4452	1039	656	656
query65	4328	4239	4276	4239
query66	1183	432	317	317
query67	16004	15747	15223	15223
query68	8051	878	516	516
query69	475	322	268	268
query70	1198	1105	1091	1091
query71	461	319	309	309
query72	5853	4746	4792	4746
query73	715	615	347	347
query74	8852	9143	8670	8670
query75	3891	3193	2692	2692
query76	3607	1182	796	796
query77	820	376	304	304
query78	10056	10113	9311	9311
query79	2776	806	576	576
query80	636	518	438	438
query81	467	254	219	219
query82	444	122	97	97
query83	285	253	225	225
query84	300	105	82	82
query85	784	364	374	364
query86	331	310	297	297
query87	4448	4427	4271	4271
query88	3219	2263	2259	2259
query89	417	319	288	288
query90	1869	211	210	210
query91	145	161	114	114
query92	78	63	55	55
query93	1764	948	573	573
query94	685	419	277	277
query95	372	291	280	280
query96	490	561	278	278
query97	2703	2778	2669	2669
query98	246	218	225	218
query99	1439	1399	1263	1263
Total cold run time: 274951 ms
Total hot run time: 185743 ms

@doris-robot

doris-robot commented May 27, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.21 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c7a767a8f696a13cdf05733809297d16668f5d4, data reload: false
query1	0.04	0.04	0.03
query2	0.12	0.11	0.10
query3	0.25	0.20	0.20
query4	1.59	0.20	0.19
query5	0.45	0.43	0.46
query6	1.48	0.66	0.66
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.59	0.52	0.50
query10	0.56	0.57	0.57
query11	0.16	0.10	0.11
query12	0.15	0.11	0.12
query13	0.62	0.60	0.61
query14	0.80	0.81	0.80
query15	0.87	0.85	0.87
query16	0.38	0.38	0.38
query17	1.04	1.04	1.02
query18	0.23	0.21	0.22
query19	1.97	1.82	1.88
query20	0.02	0.01	0.01
query21	15.42	0.93	0.55
query22	0.76	1.12	0.60
query23	15.08	1.41	0.61
query24	7.21	1.33	0.92
query25	0.42	0.23	0.08
query26	0.58	0.16	0.14
query27	0.06	0.06	0.05
query28	9.58	0.91	0.45
query29	12.53	3.91	3.33
query30	0.25	0.09	0.07
query31	2.82	0.61	0.40
query32	3.24	0.55	0.48
query33	3.02	3.16	3.11
query34	15.83	5.13	4.49
query35	4.52	4.53	4.50
query36	0.66	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.03	0.04	0.03
Total cold run time: 103.85 s
Total hot run time: 29.21 s

@zy-kkk

zy-kkk commented May 27, 2025

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label May 27, 2025
@doris-robot

doris-robot commented May 27, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33786 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 39447441a8226114132917f7f71a9ad8e1af6acb, data reload: false
------ Round 1 ----------------------------------
q1	26384	5113	5015	5015
q2	2082	289	193	193
q3	10657	1287	723	723
q4	10247	1004	509	509
q5	8106	2383	2355	2355
q6	186	166	134	134
q7	911	752	613	613
q8	9342	1303	1091	1091
q9	6836	5188	5044	5044
q10	6867	2322	1895	1895
q11	505	288	268	268
q12	341	360	213	213
q13	17776	3710	3056	3056
q14	230	228	215	215
q15	543	505	496	496
q16	428	441	370	370
q17	602	864	371	371
q18	7750	7169	7096	7096
q19	1609	964	573	573
q20	337	356	227	227
q21	4070	2699	2343	2343
q22	1064	1045	986	986
Total cold run time: 116873 ms
Total hot run time: 33786 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5176	5088	5036	5036
q2	231	318	229	229
q3	2112	2648	2354	2354
q4	1338	1806	1407	1407
q5	4458	4477	4413	4413
q6	220	170	129	129
q7	1968	1939	1731	1731
q8	2596	2625	2537	2537
q9	7207	7120	7049	7049
q10	3004	3185	2746	2746
q11	591	516	493	493
q12	678	743	625	625
q13	3541	3942	3306	3306
q14	286	306	290	290
q15	555	517	491	491
q16	459	483	451	451
q17	1197	1545	1423	1423
q18	7965	7573	7442	7442
q19	795	867	953	867
q20	1952	2005	1932	1932
q21	5014	4410	4414	4410
q22	1084	1087	1022	1022
Total cold run time: 52427 ms
Total hot run time: 50383 ms

@doris-robot

doris-robot commented May 27, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 192286 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 39447441a8226114132917f7f71a9ad8e1af6acb, data reload: false
query1	1422	1101	1055	1055
query2	6405	1893	1892	1892
query3	11106	4600	4756	4600
query4	25790	23887	23163	23163
query5	3621	621	477	477
query6	311	211	201	201
query7	3994	505	287	287
query8	315	264	249	249
query9	8489	2631	2638	2631
query10	450	326	272	272
query11	15837	15012	14759	14759
query12	164	115	111	111
query13	1570	539	399	399
query14	9009	6146	6174	6146
query15	198	196	171	171
query16	7159	628	492	492
query17	1173	696	552	552
query18	1971	409	303	303
query19	204	205	163	163
query20	128	150	119	119
query21	207	122	112	112
query22	4547	4591	4182	4182
query23	34564	33927	33546	33546
query24	8577	2450	2426	2426
query25	525	514	408	408
query26	1343	269	149	149
query27	2907	519	342	342
query28	4353	2195	2139	2139
query29	746	558	461	461
query30	277	219	192	192
query31	922	867	805	805
query32	73	64	70	64
query33	552	378	306	306
query34	807	871	538	538
query35	839	869	770	770
query36	1007	985	868	868
query37	111	102	81	81
query38	4220	4254	4183	4183
query39	1521	1482	1468	1468
query40	214	128	112	112
query41	56	54	52	52
query42	125	114	110	110
query43	523	530	499	499
query44	1328	827	821	821
query45	185	175	169	169
query46	850	1032	641	641
query47	1836	1864	1790	1790
query48	399	428	326	326
query49	775	528	415	415
query50	678	693	452	452
query51	4217	4248	4286	4248
query52	108	106	111	106
query53	228	256	191	191
query54	599	566	509	509
query55	85	82	82	82
query56	305	314	280	280
query57	1176	1214	1139	1139
query58	261	258	261	258
query59	2791	2796	2770	2770
query60	321	313	309	309
query61	124	117	124	117
query62	771	729	668	668
query63	223	186	187	186
query64	4052	1142	745	745
query65	4316	4281	4256	4256
query66	1027	394	305	305
query67	15624	15509	15355	15355
query68	7988	865	511	511
query69	455	301	262	262
query70	1176	1114	1094	1094
query71	409	323	291	291
query72	5605	4836	4814	4814
query73	658	629	356	356
query74	8840	8987	8810	8810
query75	3306	3233	2691	2691
query76	3402	1190	752	752
query77	641	432	296	296
query78	9966	10060	9326	9326
query79	2421	778	573	573
query80	666	506	438	438
query81	500	251	218	218
query82	420	127	101	101
query83	257	257	236	236
query84	253	100	83	83
query85	733	348	312	312
query86	372	297	281	281
query87	4412	4424	4352	4352
query88	3743	2264	2246	2246
query89	387	317	287	287
query90	1882	208	205	205
query91	142	139	110	110
query92	81	69	60	60
query93	2666	914	572	572
query94	655	408	307	307
query95	364	305	335	305
query96	491	558	276	276
query97	2675	2766	2627	2627
query98	238	210	209	209
query99	1323	1403	1292	1292
Total cold run time: 277738 ms
Total hot run time: 192286 ms

@doris-robot

doris-robot commented May 27, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.08 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 39447441a8226114132917f7f71a9ad8e1af6acb, data reload: false
query1	0.03	0.04	0.03
query2	0.12	0.10	0.12
query3	0.25	0.20	0.19
query4	1.59	0.19	0.19
query5	0.46	0.44	0.45
query6	1.17	0.66	0.66
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.59	0.51	0.52
query10	0.57	0.58	0.58
query11	0.16	0.10	0.11
query12	0.16	0.12	0.12
query13	0.62	0.60	0.59
query14	0.79	0.82	0.81
query15	0.88	0.85	0.87
query16	0.38	0.40	0.39
query17	1.06	1.02	1.04
query18	0.23	0.22	0.21
query19	1.97	1.88	1.91
query20	0.01	0.01	0.01
query21	15.40	0.90	0.54
query22	0.76	1.16	0.65
query23	15.00	1.42	0.64
query24	7.28	1.78	0.56
query25	0.47	0.23	0.08
query26	0.56	0.16	0.15
query27	0.05	0.05	0.05
query28	9.54	0.93	0.48
query29	12.56	4.03	3.32
query30	0.26	0.09	0.06
query31	2.81	0.59	0.39
query32	3.24	0.56	0.47
query33	3.06	3.10	3.11
query34	15.68	5.14	4.49
query35	4.51	4.58	4.60
query36	0.66	0.50	0.49
query37	0.09	0.07	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.04	0.03
Total cold run time: 103.44 s
Total hot run time: 29.08 s

@zy-kkk
zy-kkkforce-pushed the sql_server_identity branch from 3944744 to 9c107beCompareMay 27, 2025 12:48
@zy-kkk

zy-kkk commented May 27, 2025

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

doris-robot commented May 27, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33645 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9c107bedccb8764d3e3b00a0e4878f8c0dd308c9, data reload: false
------ Round 1 ----------------------------------
q1	25945	5007	5022	5007
q2	2065	277	180	180
q3	10395	1288	701	701
q4	10388	1033	542	542
q5	7639	2421	2324	2324
q6	180	166	135	135
q7	920	744	613	613
q8	9310	1294	1078	1078
q9	7242	5060	5108	5060
q10	6853	2314	1906	1906
q11	500	280	282	280
q12	360	346	218	218
q13	17779	3716	3066	3066
q14	233	224	219	219
q15	533	490	480	480
q16	406	429	368	368
q17	591	834	367	367
q18	7442	7022	7162	7022
q19	1751	943	538	538
q20	338	326	221	221
q21	3643	3155	2360	2360
q22	1037	1034	960	960
Total cold run time: 115550 ms
Total hot run time: 33645 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5167	5041	5093	5041
q2	235	317	224	224
q3	2146	2637	2271	2271
q4	1334	1763	1339	1339
q5	4436	4330	4431	4330
q6	212	169	128	128
q7	2016	1889	1785	1785
q8	2594	2554	2536	2536
q9	7114	7153	6939	6939
q10	3047	3167	2738	2738
q11	598	505	495	495
q12	679	770	610	610
q13	3477	3866	3310	3310
q14	296	302	267	267
q15	510	483	488	483
q16	452	490	428	428
q17	1151	1573	1357	1357
q18	7793	7435	7379	7379
q19	801	835	943	835
q20	2016	2066	1858	1858
q21	4799	4461	4438	4438
q22	1072	1033	1034	1033
Total cold run time: 51945 ms
Total hot run time: 49824 ms

@doris-robot

doris-robot commented May 27, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 191976 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9c107bedccb8764d3e3b00a0e4878f8c0dd308c9, data reload: false
query1	1414	1095	1085	1085
query2	6399	1884	1857	1857
query3	11001	4536	4437	4437
query4	53725	24813	23113	23113
query5	5022	516	460	460
query6	361	210	195	195
query7	4920	521	285	285
query8	315	243	229	229
query9	5903	2613	2615	2613
query10	440	316	259	259
query11	15043	15050	15334	15050
query12	165	116	111	111
query13	1066	512	408	408
query14	10119	6243	6117	6117
query15	203	206	177	177
query16	7064	660	497	497
query17	1089	748	589	589
query18	1531	433	330	330
query19	201	203	179	179
query20	132	130	120	120
query21	210	135	114	114
query22	4488	4374	4436	4374
query23	34164	33724	33247	33247
query24	6720	2436	2452	2436
query25	494	491	457	457
query26	729	266	156	156
query27	2277	508	356	356
query28	2999	2156	2114	2114
query29	574	580	431	431
query30	265	231	189	189
query31	874	819	767	767
query32	74	64	68	64
query33	464	365	315	315
query34	849	872	537	537
query35	805	820	737	737
query36	950	1000	881	881
query37	116	103	83	83
query38	4234	4357	4122	4122
query39	1528	1638	1464	1464
query40	224	118	116	116
query41	56	53	53	53
query42	129	113	112	112
query43	527	524	489	489
query44	1349	848	840	840
query45	177	181	166	166
query46	854	1036	659	659
query47	1854	1857	1787	1787
query48	393	424	313	313
query49	703	562	453	453
query50	683	704	405	405
query51	4206	4308	4168	4168
query52	116	113	101	101
query53	229	258	185	185
query54	606	582	529	529
query55	84	83	90	83
query56	314	302	302	302
query57	1156	1187	1123	1123
query58	267	262	260	260
query59	2812	2941	2842	2842
query60	323	332	314	314
query61	128	125	128	125
query62	732	715	665	665
query63	230	199	196	196
query64	1808	1031	736	736
query65	4292	4272	4223	4223
query66	710	411	297	297
query67	15826	15625	15356	15356
query68	7073	879	502	502
query69	532	308	267	267
query70	1214	1136	1086	1086
query71	510	336	295	295
query72	5930	4719	4772	4719
query73	1396	644	351	351
query74	8918	9111	8658	8658
query75	3888	3185	2744	2744
query76	4315	1187	756	756
query77	606	386	271	271
query78	10127	10069	9405	9405
query79	2607	802	579	579
query80	624	495	451	451
query81	486	260	225	225
query82	436	121	92	92
query83	370	308	233	233
query84	296	106	85	85
query85	785	353	302	302
query86	377	311	294	294
query87	4391	4378	4387	4378
query88	3523	2258	2250	2250
query89	406	330	288	288
query90	1821	211	208	208
query91	144	142	113	113
query92	72	60	61	60
query93	1885	956	575	575
query94	678	396	302	302
query95	368	298	283	283
query96	494	557	282	282
query97	2740	2784	2612	2612
query98	226	205	195	195
query99	1443	1401	1262	1262
Total cold run time: 298396 ms
Total hot run time: 191976 ms

@doris-robot

doris-robot commented May 27, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.33 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9c107bedccb8764d3e3b00a0e4878f8c0dd308c9, data reload: false
query1	0.03	0.04	0.03
query2	0.12	0.11	0.11
query3	0.25	0.20	0.19
query4	1.59	0.19	0.19
query5	0.44	0.44	0.46
query6	1.17	0.65	0.68
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.53
query10	0.57	0.58	0.57
query11	0.15	0.10	0.10
query12	0.15	0.11	0.11
query13	0.61	0.61	0.60
query14	0.78	0.81	0.82
query15	0.85	0.86	0.85
query16	0.36	0.38	0.39
query17	1.03	1.04	1.04
query18	0.23	0.21	0.21
query19	1.89	1.89	1.79
query20	0.01	0.01	0.02
query21	15.39	0.90	0.54
query22	0.75	1.18	0.69
query23	14.93	1.38	0.64
query24	6.79	1.13	1.02
query25	0.52	0.14	0.16
query26	0.66	0.16	0.14
query27	0.05	0.04	0.05
query28	10.09	0.92	0.45
query29	12.57	3.95	3.32
query30	0.25	0.08	0.06
query31	2.82	0.59	0.38
query32	3.23	0.54	0.46
query33	3.13	3.02	3.09
query34	15.63	5.11	4.50
query35	4.53	4.49	4.51
query36	0.66	0.50	0.48
query37	0.08	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.35 s
Total hot run time: 29.33 s

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 28, 2025
@github-actions

github-actionsBot commented May 28, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@zy-kkk
zy-kkk merged commit 144ddbf into apache:masterMay 28, 2025
@zy-kkk
zy-kkk deleted the sql_server_identity branch May 28, 2025 06:12
github-actionsBot pushed a commit that referenced this pull request May 28, 2025
@zy-kkkYour Name
[improvement](jdbc catalog) Optimize the acquisition of indentity typ…
be58abd
…e in SQLServer (#51285)
1、In SQLServer, if a type is indentity, then the display of its original
type may be changed, such as decimal -> decima(), so we get the string
from subscript 0 to ( before as typename
2、For decimal, we should use the unified createDecimalOrStringType
method to build the type
@github-actionsgithub-actionsBot mentioned this pull request May 28, 2025
Merged
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@zy-kkkkoarz
[improvement](jdbc catalog) Optimize the acquisition of indentity typ…
9089ee0
…e in SQLServer (apache#51285)
1、In SQLServer, if a type is indentity, then the display of its original
type may be changed, such as decimal -> decima(), so we get the string
from subscript 0 to ( before as typename
2、For decimal, we should use the unified createDecimalOrStringType
method to build the type
dataroaring pushed a commit that referenced this pull request Jun 11, 2025
@github-actions@zy-kkk
branch-3.0: [improvement](jdbc catalog) Optimize the acquisition of i…
8e31467
…ndentity type in SQLServer #51285 (#51317)
Cherry-picked from #51285
Co-authored-by: zy-kkk <zhongyk10@gmail.com>
zy-kkk added a commit to zy-kkk/doris that referenced this pull request Jun 12, 2025
@zy-kkk
[improvement](jdbc catalog) Optimize the acquisition of indentity typ…
fa0c32c
…e in SQLServer (apache#51285)
1、In SQLServer, if a type is indentity, then the display of its original
type may be changed, such as decimal -> decima(), so we get the string
from subscript 0 to ( before as typename
2、For decimal, we should use the unified createDecimalOrStringType
method to build the type
@zy-kkkzy-kkk mentioned this pull request Jun 12, 2025
Merged
yiguolei pushed a commit that referenced this pull request Jun 16, 2025
@zy-kkk
branch-2.1: [improvement](jdbc catalog) Optimize the acquisition of i…
3a1e95c
…ndentity type in SQLServer (#51659)
pick #51285
@yiguoleiyiguolei mentioned this pull request Aug 11, 2025
Closed
@gavinchougavinchou mentioned this pull request Aug 15, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@CalvinKirsCalvinKirsCalvinKirs approved these changes
@hubgeterhubgeterhubgeter approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.11-mergeddev/3.0.7-mergeddev/3.1.0-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@zy-kkk@hello-stephen@doris-robot@morningman@CalvinKirs@hubgeter@yiguolei@dataroaring@morrySnow