[bug](function) fix split_by_regexp meet empty string return error by zhangstar333 · Pull Request #51293 · apache/doris

zhangstar333 · 2025-05-27T09:29:17Z

What problem does this PR solve?

Problem Summary:
when pattern is empty, it's should split all alone , not return error msg
mysql> select id,name,score, k,v from table_test lateral view posexplode(split_by_regexp(name,'')) tmp as k,v order by id; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.2)[RUNTIME_ERROR]Invalid pattern:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-05-27T09:29:22Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zhangstar333 · 2025-05-27T09:29:47Z

run buildall

doris-robot · 2025-05-27T09:49:43Z

TPC-H: Total hot run time: 33843 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fd068a84e45c7dcb4d72052ba21fa2d289ede4ee, data reload: false
------ Round 1 ----------------------------------
q1	26577	5143	4991	4991
q2	2076	295	185	185
q3	10433	1273	723	723
q4	10263	1010	543	543
q5	8414	2345	2322	2322
q6	202	164	132	132
q7	895	756	607	607
q8	9306	1303	1043	1043
q9	6977	5119	5205	5119
q10	6821	2302	1915	1915
q11	476	295	268	268
q12	344	359	220	220
q13	17791	3682	3101	3101
q14	230	228	216	216
q15	536	482	485	482
q16	425	434	371	371
q17	594	863	365	365
q18	7798	7180	7188	7180
q19	1573	958	544	544
q20	334	339	231	231
q21	3854	3130	2325	2325
q22	1043	1026	960	960
Total cold run time: 116962 ms
Total hot run time: 33843 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5135	5035	5123	5035
q2	233	324	232	232
q3	2155	2668	2295	2295
q4	1372	1797	1534	1534
q5	4506	4432	4342	4342
q6	211	177	130	130
q7	1970	1910	1700	1700
q8	2569	2572	2577	2572
q9	7141	7182	7140	7140
q10	2995	3147	2816	2816
q11	587	519	487	487
q12	665	759	615	615
q13	3456	3868	3264	3264
q14	280	309	286	286
q15	529	482	478	478
q16	449	488	455	455
q17	1152	1536	1393	1393
q18	7738	7550	7303	7303
q19	805	837	913	837
q20	1957	2047	1897	1897
q21	4821	4362	4203	4203
q22	1043	1017	972	972
Total cold run time: 51769 ms
Total hot run time: 49986 ms

doris-robot · 2025-05-27T10:01:17Z

TPC-DS: Total hot run time: 185488 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fd068a84e45c7dcb4d72052ba21fa2d289ede4ee, data reload: false
query1	1034	467	511	467
query2	6568	1911	1922	1911
query3	6752	220	228	220
query4	26624	23206	22989	22989
query5	4378	617	469	469
query6	304	196	202	196
query7	4635	477	279	279
query8	298	238	225	225
query9	8588	2609	2588	2588
query10	483	330	274	274
query11	15851	15022	14804	14804
query12	152	109	104	104
query13	1647	533	402	402
query14	8951	6122	6094	6094
query15	211	207	167	167
query16	7151	644	488	488
query17	1182	700	564	564
query18	1950	390	287	287
query19	185	191	162	162
query20	121	128	119	119
query21	211	134	108	108
query22	4137	4132	4053	4053
query23	34060	33218	33008	33008
query24	8498	2380	2360	2360
query25	574	477	429	429
query26	1249	274	153	153
query27	2744	490	340	340
query28	4354	2113	2092	2092
query29	792	572	456	456
query30	285	215	186	186
query31	944	856	777	777
query32	76	68	66	66
query33	563	378	323	323
query34	793	895	516	516
query35	760	818	710	710
query36	941	972	879	879
query37	118	100	83	83
query38	4136	4159	4033	4033
query39	1472	1421	1394	1394
query40	229	121	110	110
query41	59	56	54	54
query42	126	108	106	106
query43	514	505	476	476
query44	1271	815	852	815
query45	189	167	166	166
query46	830	1012	625	625
query47	1768	1789	1709	1709
query48	391	429	304	304
query49	778	518	413	413
query50	620	666	400	400
query51	4121	4141	4194	4141
query52	109	106	97	97
query53	221	251	181	181
query54	578	563	498	498
query55	91	80	79	79
query56	320	314	300	300
query57	1148	1164	1098	1098
query58	268	255	253	253
query59	2705	2745	2654	2654
query60	326	319	297	297
query61	123	123	124	123
query62	832	713	642	642
query63	223	187	184	184
query64	4369	1010	663	663
query65	4347	4291	4241	4241
query66	1167	415	309	309
query67	15774	15784	15322	15322
query68	8846	890	517	517
query69	473	362	268	268
query70	1175	1131	1042	1042
query71	444	322	308	308
query72	5344	4697	4672	4672
query73	715	586	412	412
query74	8901	9082	9056	9056
query75	4155	3184	2706	2706
query76	3634	1182	737	737
query77	783	372	284	284
query78	10268	10170	9229	9229
query79	2533	839	571	571
query80	626	509	451	451
query81	493	256	219	219
query82	477	120	104	104
query83	287	255	241	241
query84	295	106	84	84
query85	825	361	318	318
query86	387	316	292	292
query87	4395	4507	4382	4382
query88	3486	2285	2277	2277
query89	392	311	287	287
query90	1829	207	206	206
query91	144	142	109	109
query92	80	57	57	57
query93	1807	942	572	572
query94	673	416	306	306
query95	382	292	285	285
query96	485	573	277	277
query97	2808	2771	2654	2654
query98	235	205	211	205
query99	1472	1411	1325	1325
Total cold run time: 276118 ms
Total hot run time: 185488 ms

doris-robot · 2025-05-27T10:06:36Z

ClickBench: Total hot run time: 29.15 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fd068a84e45c7dcb4d72052ba21fa2d289ede4ee, data reload: false
query1	0.04	0.05	0.03
query2	0.13	0.10	0.11
query3	0.26	0.19	0.19
query4	1.60	0.19	0.20
query5	0.45	0.43	0.45
query6	1.17	0.66	0.66
query7	0.02	0.02	0.01
query8	0.05	0.03	0.04
query9	0.60	0.53	0.53
query10	0.56	0.57	0.55
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.61
query14	0.78	0.81	0.81
query15	0.89	0.86	0.86
query16	0.38	0.37	0.40
query17	1.01	1.00	1.05
query18	0.23	0.22	0.21
query19	1.92	1.84	1.77
query20	0.01	0.01	0.02
query21	15.45	0.90	0.55
query22	0.76	1.23	0.79
query23	14.73	1.41	0.62
query24	7.17	0.92	0.82
query25	0.44	0.14	0.08
query26	0.62	0.17	0.13
query27	0.05	0.05	0.05
query28	9.25	0.91	0.45
query29	12.62	3.96	3.31
query30	0.26	0.09	0.07
query31	2.82	0.63	0.39
query32	3.23	0.55	0.47
query33	3.07	3.07	3.03
query34	15.76	5.07	4.50
query35	4.51	4.49	4.49
query36	0.68	0.50	0.51
query37	0.09	0.07	0.07
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.18	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.04
Total cold run time: 102.97 s
Total hot run time: 29.15 s

zhangstar333 · 2025-05-28T02:44:33Z

run p0

zhangstar333 · 2025-05-30T01:51:35Z

run buildall

doris-robot · 2025-05-30T02:31:07Z

TPC-H: Total hot run time: 33814 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fd068a84e45c7dcb4d72052ba21fa2d289ede4ee, data reload: false
------ Round 1 ----------------------------------
q1	26007	5035	5056	5035
q2	1950	267	176	176
q3	10312	1227	698	698
q4	10209	994	515	515
q5	7759	2262	2316	2262
q6	174	159	131	131
q7	927	770	654	654
q8	9341	1303	1065	1065
q9	6975	5210	5211	5210
q10	6914	2318	1925	1925
q11	491	286	287	286
q12	350	357	230	230
q13	18092	3688	3103	3103
q14	228	247	241	241
q15	554	488	488	488
q16	426	436	379	379
q17	579	852	360	360
q18	7499	7237	7009	7009
q19	1889	957	553	553
q20	327	334	223	223
q21	3922	2648	2325	2325
q22	1043	995	946	946
Total cold run time: 115968 ms
Total hot run time: 33814 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5192	5124	5075	5075
q2	243	321	219	219
q3	2172	2631	2312	2312
q4	1357	1797	1353	1353
q5	4449	4370	4400	4370
q6	214	166	134	134
q7	1986	1915	1776	1776
q8	2576	2573	2478	2478
q9	7233	7199	6984	6984
q10	3030	3195	2752	2752
q11	565	522	483	483
q12	663	741	623	623
q13	3518	3865	3359	3359
q14	294	329	292	292
q15	523	470	467	467
q16	441	497	430	430
q17	1248	1520	1380	1380
q18	7666	7525	7448	7448
q19	805	804	823	804
q20	2007	1973	1838	1838
q21	4826	4521	4345	4345
q22	1096	1037	1026	1026
Total cold run time: 52104 ms
Total hot run time: 49948 ms

doris-robot · 2025-05-30T02:43:16Z

TPC-DS: Total hot run time: 192840 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fd068a84e45c7dcb4d72052ba21fa2d289ede4ee, data reload: false
query1	1462	1091	1084	1084
query2	6238	1831	1789	1789
query3	10994	4371	4490	4371
query4	53487	25508	22996	22996
query5	4996	501	465	465
query6	321	227	198	198
query7	4899	549	294	294
query8	285	235	216	216
query9	5303	2664	2622	2622
query10	449	325	281	281
query11	14974	15090	14959	14959
query12	159	109	106	106
query13	1057	535	408	408
query14	10187	6482	6531	6482
query15	207	200	186	186
query16	7151	640	494	494
query17	1095	751	575	575
query18	1583	420	315	315
query19	201	190	173	173
query20	129	128	119	119
query21	202	133	110	110
query22	4360	4352	4357	4352
query23	34292	33600	33624	33600
query24	6733	2425	2425	2425
query25	466	492	412	412
query26	674	273	154	154
query27	2294	513	351	351
query28	2960	2177	2142	2142
query29	583	565	438	438
query30	270	214	191	191
query31	872	889	774	774
query32	73	64	66	64
query33	423	371	306	306
query34	805	884	543	543
query35	804	844	757	757
query36	963	1015	921	921
query37	124	98	77	77
query38	4250	4246	4302	4246
query39	1557	1445	1453	1445
query40	207	122	106	106
query41	61	62	91	62
query42	130	114	116	114
query43	507	488	491	488
query44	1367	851	847	847
query45	180	177	172	172
query46	872	1059	682	682
query47	1811	1865	1802	1802
query48	400	442	329	329
query49	634	529	414	414
query50	649	700	405	405
query51	4295	4178	4209	4178
query52	111	109	108	108
query53	233	262	223	223
query54	585	579	524	524
query55	87	85	80	80
query56	327	309	292	292
query57	1157	1187	1101	1101
query58	272	268	268	268
query59	2686	2746	2649	2649
query60	353	333	327	327
query61	126	125	123	123
query62	759	775	710	710
query63	238	195	191	191
query64	1489	1020	711	711
query65	4300	4141	4109	4109
query66	725	402	319	319
query67	15867	15570	15493	15493
query68	6388	845	543	543
query69	566	310	278	278
query70	1165	1142	1137	1137
query71	483	350	297	297
query72	5927	4778	4811	4778
query73	1346	640	360	360
query74	8919	9051	8892	8892
query75	3472	3209	2703	2703
query76	3800	1208	769	769
query77	533	378	299	299
query78	10209	10170	9391	9391
query79	2496	818	599	599
query80	665	613	437	437
query81	492	251	222	222
query82	453	124	97	97
query83	378	253	244	244
query84	296	107	87	87
query85	787	349	324	324
query86	420	312	286	286
query87	4401	4439	4319	4319
query88	3390	2354	2302	2302
query89	418	314	288	288
query90	1879	210	212	210
query91	140	149	111	111
query92	74	66	61	61
query93	1849	927	584	584
query94	671	422	293	293
query95	383	296	284	284
query96	506	583	285	285
query97	2736	2771	2650	2650
query98	232	207	196	196
query99	1419	1378	1246	1246
Total cold run time: 295203 ms
Total hot run time: 192840 ms

doris-robot · 2025-05-30T02:48:29Z

ClickBench: Total hot run time: 29.28 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fd068a84e45c7dcb4d72052ba21fa2d289ede4ee, data reload: false
query1	0.03	0.04	0.04
query2	0.12	0.11	0.11
query3	0.25	0.20	0.19
query4	1.59	0.19	0.11
query5	0.46	0.42	0.43
query6	1.15	0.67	0.67
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.59	0.51	0.51
query10	0.56	0.57	0.57
query11	0.15	0.11	0.11
query12	0.16	0.12	0.12
query13	0.62	0.60	0.61
query14	0.78	0.80	0.82
query15	0.88	0.87	0.85
query16	0.37	0.38	0.38
query17	1.04	1.04	1.05
query18	0.22	0.20	0.21
query19	1.99	1.80	1.78
query20	0.01	0.01	0.02
query21	15.42	0.93	0.55
query22	0.75	1.10	0.65
query23	15.02	1.41	0.67
query24	6.83	1.73	0.98
query25	0.50	0.14	0.09
query26	0.58	0.18	0.14
query27	0.06	0.05	0.05
query28	10.03	0.92	0.46
query29	12.63	3.97	3.34
query30	0.25	0.10	0.07
query31	2.82	0.60	0.41
query32	3.23	0.56	0.47
query33	3.06	3.04	3.13
query34	15.87	5.11	4.48
query35	4.50	4.50	4.53
query36	0.67	0.49	0.48
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.02	0.02	0.02
query40	0.17	0.14	0.14
query41	0.08	0.03	0.03
query42	0.03	0.03	0.03
query43	0.04	0.03	0.02
Total cold run time: 103.74 s
Total hot run time: 29.28 s

doris-robot · 2025-05-30T03:55:24Z

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	56.16% (15026/26758)
Line Coverage	45.07% (134132/297620)
Region Coverage	44.18% (67497/152760)
Branch Coverage	38.74% (34572/89232)

hello-stephen · 2025-05-30T04:02:39Z

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

hello-stephen · 2025-05-30T05:06:56Z

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

hello-stephen · 2025-05-30T05:10:25Z

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	79.48% (20936/26342)
Line Coverage	72.70% (216371/297609)
Region Coverage	70.84% (127279/179665)
Branch Coverage	64.55% (65858/102032)

github-actions · 2025-05-30T09:06:44Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-05-30T09:06:46Z

PR approved by anyone and no changes requested.

HappenLee

LGTM

…pache#51293) when pattern is empty, it's should split all alone , not return error msg `mysql> select id,name,score, k,v from table_test lateral view posexplode(split_by_regexp(name,'')) tmp as k,v order by id; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.2)[RUNTIME_ERROR]Invalid pattern:`

…50272) bp (#38259) (#47676) also need pick #51293 --------- Co-authored-by: James <lijibing@selectdb.com>

…pache#51293) when pattern is empty, it's should split all alone , not return error msg `mysql> select id,name,score, k,v from table_test lateral view posexplode(split_by_regexp(name,'')) tmp as k,v order by id; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.2)[RUNTIME_ERROR]Invalid pattern:`

… error (#51293) (#51862) Problem Summary: cherry-pick from master #51293

…pache#51293) when pattern is empty, it's should split all alone , not return error msg `mysql> select id,name,score, k,v from table_test lateral view posexplode(split_by_regexp(name,'')) tmp as k,v order by id; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.2)[RUNTIME_ERROR]Invalid pattern:`

pick from master #38259 #47676 #51293 #49381 Co-authored-by: James <lijibing@selectdb.com>

[bug](function) fix split_by_regexp meet empty string return error
fd068a8

dataroaring added dev/3.0.x usercase Important user case type label labels May 28, 2025

zhangstar333 mentioned this pull request May 28, 2025
[cherry-pick](branch-30) support split_by_regexp (#38259) (#47676) #50272
Merged

yiguolei approved these changes May 30, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 30, 2025

github-actionsBot added the reviewed label May 30, 2025

HappenLee approved these changes Jun 1, 2025
View reviewed changes

HappenLee merged commit f138847 into apache:masterJun 2, 2025

github-actionsBot added the dev/3.0.x-conflict label Jun 2, 2025

dataroaring pushed a commit that referenced this pull request Jun 18, 2025
[cherry-pick](branch-30) support split_by_regexp (#38259) (#47676) (#…
d499904
…50272) bp (#38259) (#47676) also need pick #51293 --------- Co-authored-by: James <lijibing@selectdb.com>

zhangstar333 removed dev/3.0.x dev/3.0.x-conflict labels Jun 18, 2025

zhangstar333 added the dev/3.0.x label Jun 18, 2025

github-actionsBot added the dev/3.0.x-conflict label Jun 18, 2025

zhangstar333 mentioned this pull request Jun 18, 2025
[cherry-pick](branch-30) fix split_by_regexp meet empty string return error (#51293) #51862
Merged
16 tasks

dataroaring pushed a commit that referenced this pull request Jun 19, 2025
[cherry-pick](branch-30) fix split_by_regexp meet empty string return…
945f776
… error (#51293) (#51862) Problem Summary: cherry-pick from master #51293

dataroaring added dev/3.0.7-merged and removed dev/3.0.x dev/3.0.x-conflict labels Jun 19, 2025

morrySnow added the dev/3.1.x label Jun 19, 2025

github-actionsBot added the dev/3.1.x-conflict label Jun 19, 2025

zhangstar333 mentioned this pull request Jun 20, 2025
[cherry-pick](branch-31) pick (#38259) (#47676) (#51293) (#49381) #52005
Merged
16 tasks

morrySnow pushed a commit that referenced this pull request Jun 20, 2025
[cherry-pick](branch-31) pick 4 prs#38259#47676#51293#49381(#52005)
d538b6f
pick from master #38259 #47676 #51293 #49381 Co-authored-by: James <lijibing@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Jun 20, 2025

gavinchou mentioned this pull request Aug 15, 2025
Release Note 3.0.7 #54868
Closed

Uh oh!

Conversation

zhangstar333 commented May 27, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented May 27, 2025

Uh oh!

zhangstar333 commented May 27, 2025

Uh oh!

doris-robot commented May 27, 2025

Uh oh!

doris-robot commented May 27, 2025

Uh oh!

doris-robot commented May 27, 2025

Uh oh!

zhangstar333 commented May 28, 2025

Uh oh!

zhangstar333 commented May 30, 2025

Uh oh!

doris-robot commented May 30, 2025

Uh oh!

doris-robot commented May 30, 2025

Uh oh!

doris-robot commented May 30, 2025

Uh oh!

doris-robot commented May 30, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented May 30, 2025

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented May 30, 2025

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented May 30, 2025

BE Regression && UT Coverage Report

Uh oh!

github-actionsBot commented May 30, 2025

Uh oh!

github-actionsBot commented May 30, 2025

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zhangstar333 commented May 27, 2025•
edited
Loading