Skip to content

[Load] support ignoring eovercrowded when tablet sink - #5156

Merged
morningman merged 4 commits into
apache:masterfrom
vagetablechicken:issue-5147
Jan 9, 2021
Merged

[Load] support ignoring eovercrowded when tablet sink#5156
morningman merged 4 commits into
apache:masterfrom
vagetablechicken:issue-5147

Conversation

@vagetablechicken

@vagetablechickenvagetablechicken commented Dec 28, 2020

Copy link
Copy Markdown
Member

Proposed changes

If adding the ignore_eovercrowded flag, the PTabletWriterAddBatchRequest won't failed on EOVERCROWDED to avoid load jobs failed in this error. It only effects the NodeChannel(the load job), other rpc requests will still check if overcrowded.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

Comment threadbe/src/exec/tablet_sink.cpp
@morningmanmorningman self-assigned this Jan 3, 2021
@morningmanmorningman added the area/config Issues or PRs related to configuration label Jan 3, 2021
@kangkaisen

Copy link
Copy Markdown
Contributor

@vagetablechicken LGTM. please update the doc for the new config.

@vagetablechicken

Copy link
Copy Markdown
MemberAuthor

@vagetablechicken LGTM. please update the doc for the new config.

Done. And I found opening tablet writer may be failed too. So I add ignore option to all the rpc requests in tablet_sink.

@vagetablechickenvagetablechicken changed the title [Load] support ignoring eovercrowded when adding batch[Load] support ignoring eovercrowded when tablet sinkJan 5, 2021
kangkaisen
kangkaisen previously approved these changes Jan 6, 2021

@kangkaisenkangkaisen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen

Copy link
Copy Markdown
Contributor

@vagetablechicken Hi, please fix the conficts.

@kangkaisenkangkaisen added the approved Indicates a PR has been approved by one committer. label Jan 6, 2021
@morningman
morningman merged commit 5d6a1a7 into apache:masterJan 9, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
If adding the ignore_eovercrowded flag, the `PTabletWriterAddBatchRequest`
won't failed on `EOVERCROWDED` to avoid load jobs failed in this error.
It only effects the NodeChannel(the load job), other rpc requests will still check if overcrowded.
levy5307 pushed a commit to levy5307/incubator-doris that referenced this pull request Nov 14, 2022
If adding the ignore_eovercrowded flag, the `PTabletWriterAddBatchRequest`
won't failed on `EOVERCROWDED` to avoid load jobs failed in this error.
It only effects the NodeChannel(the load job), other rpc requests will still check if overcrowded.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/configIssues or PRs related to configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] support ignoring eovercrowded when adding batch

3 participants

@vagetablechicken@kangkaisen@morningman