Skip to content

[BUG] Follower shouldn't forward non-query statement to master repeatedly - #5160

Merged
caiconghui merged 1 commit into
apache:masterfrom
924060929:lanhuajian-dev
Dec 29, 2020
Merged

[BUG] Follower shouldn't forward non-query statement to master repeatedly#5160
caiconghui merged 1 commit into
apache:masterfrom
924060929:lanhuajian-dev

Conversation

@924060929

@924060929924060929 commented Dec 28, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Follower shouldn't forward non-query statement to master repeatedly

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

None

@924060929924060929 changed the title [BUG] Follower should forward non-query statement to master repeatedly[BUG] Follower shouldn't forward non-query statement to master repeatedlyDec 28, 2020
@caiconghuicaiconghui added api-review Categorizes an issue or PR as actively needing an API review. kind/fix Categorizes issue or PR as related to a bug. and removed api-review Categorizes an issue or PR as actively needing an API review. labels Dec 28, 2020
@caiconghui

caiconghui commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

plz add an issue related to this PR

@924060929

924060929 commented Dec 28, 2020

Copy link
Copy Markdown
ContributorAuthor

plz add an issue related to this PR

done, see #5161

@caiconghui

caiconghui commented Dec 28, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

plz add an issue related to this PR

done, see #5161

what exception will transfer operation throw, when network problem occur and it it not a timeout exception?

@924060929

924060929 commented Dec 28, 2020

Copy link
Copy Markdown
ContributorAuthor

plz add an issue related to this PR

done, see #5161
what exception will transfer operation throw, when network problem occur and it it not a timeout exception?

TTransportException.UNKNOWN

caiconghui
caiconghui reviewed Dec 28, 2020
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/MasterOpExecutor.java
caiconghui
caiconghui approved these changes Dec 28, 2020
View reviewed changes

@caiconghuicaiconghui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caiconghuicaiconghui added the approved Indicates a PR has been approved by one committer. label Dec 28, 2020
@caiconghui
caiconghui merged commit cd865c9 into apache:masterDec 29, 2020
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
@924060929lanhuajian@morningman-cmy
Follower don't forward non-query statement to master repeatedly (apac…
d85b58f
…he#5160)
Co-authored-by: lanhuajian <lanhuajian@sankuai.com>
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caiconghuicaiconghuicaiconghui approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.kind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@924060929@caiconghui