Skip to content

branch-2.1:[fix](cooldown)No need to rdlock inside get_cooldown_tablets, there's enough rdlock inside tablet internal function calls.#39211 - #51611

Merged
yiguolei merged 1 commit into
apache:branch-2.1from
dtkavin:fix_0610
Jun 20, 2025

Conversation

@dtkavin

Copy link
Copy Markdown
Contributor

cherry-pick: #39211

… enough rdlock inside tablet internal function calls
@dtkavin
dtkavin requested a review from yiguolei as a code ownerJune 10, 2025 08:53
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dtkavin

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage39.03% (10326/26457)
Line Coverage30.03% (85770/285652)
Region Coverage28.69% (44259/154270)
Branch Coverage25.42% (22652/89126)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage74.58% (19435/26061)
Line Coverage69.24% (196515/283808)
Region Coverage66.83% (120003/179559)
Branch Coverage59.87% (60328/100758)

@felixwluofelixwluo changed the title [fix](cooldown)No need to rdlock inside get_cooldown_tablets, there's…branch-2.1:[fix](cooldown)No need to rdlock inside get_cooldown_tablets, there's enough rdlock inside tablet internal function calls.#39211Jun 10, 2025

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 18, 2025
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit 0230d60 into apache:branch-2.1Jun 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dtkavin@hello-stephen@yiguolei@dataroaring