Skip to content

[Load Parallel][2/3] Support parallel flushing memtable during load - #5163

Merged
morningman merged 5 commits into
apache:masterfrom
morningman:flush_paral
Jan 24, 2021
Merged

[Load Parallel][2/3] Support parallel flushing memtable during load#5163
morningman merged 5 commits into
apache:masterfrom
morningman:flush_paral

Conversation

@morningman

@morningmanmorningman commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

Proposed changes

In the previous implementation, in an load job,
multiple memtables of the same tablet are written to disk sequentially.
In fact, multiple memtables can be written out of order in parallel,
only need to ensure that each memtable uses a dependent segment writer.

This is 2nd part of improving load performance.

#5281

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@morningmanmorningman reopened this Dec 28, 2020
@morningman
morningman marked this pull request as draft December 28, 2020 12:02
In the previous implementation, in an load job,
multiple memtables of the same tablet are written to disk sequentially.
In fact, multiple memtables can be written out of order in parallel,
only need to ensure that each memtable uses a different segment writer.
@morningman
morningman marked this pull request as ready for review January 21, 2021 15:27
@morningmanmorningman changed the title [Refactor] Support parallel flushing memtable during load[Load Parallel][1/3] Support parallel flushing memtable during loadJan 21, 2021
@morningmanmorningman changed the title [Load Parallel][1/3] Support parallel flushing memtable during load[Load Parallel][2/3] Support parallel flushing memtable during loadJan 21, 2021
@morningmanmorningman self-assigned this Jan 21, 2021
@morningmanmorningman added area/load Issues or PRs related to all kinds of load kind/improvement labels Jan 21, 2021

@yangzhgyangzhg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhgyangzhg added the approved Indicates a PR has been approved by one committer. label Jan 23, 2021
@morningman
morningman merged commit ab06e92 into apache:masterJan 24, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
…pache#5163)
In the previous implementation, in an load job,
multiple memtables of the same tablet are written to disk sequentially.
In fact, multiple memtables can be written out of order in parallel,
only need to ensure that each memtable uses a different segment writer.
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/loadIssues or PRs related to all kinds of loadkind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@morningman@yangzhg@morningman-cmy