Skip to content

branch-2.1:[improvement](statistics)Eliminate null values while sample analyzing ndv. (#50574) - #51648

Merged
yiguolei merged 1 commit into
apache:branch-2.1from
Jibing-Li:null2.1
Jun 13, 2025
Merged

branch-2.1:[improvement](statistics)Eliminate null values while sample analyzing ndv. (#50574)#51648
yiguolei merged 1 commit into
apache:branch-2.1from
Jibing-Li:null2.1

Conversation

@Jibing-Li

@Jibing-LiJibing-Li commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

backport: #50574

@hello-stephen

hello-stephen commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li
Jibing-Li marked this pull request as ready for review June 11, 2025 12:07
@Jibing-Li
Jibing-Li requested a review from yiguolei as a code ownerJune 11, 2025 12:07
@Jibing-Li

Jibing-Li commented Jun 11, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@Jibing-Li
[improvement](statistics)Eliminate null values while sample analyzing…
41045b9
… ndv. (apache#50574)
1. Eliminate null values while sample analyzing ndv.
For example, if the values of col1 in table1 are all NULL, the ndv of
col1 should be 0, not 1.
2. If ndv=0 and min/max not null and null_num == rowCount, we keep this
stats info but set to unknown in stats calculator. This is probably
because sampled an all-null tablet.
@Jibing-Li

Jibing-Li commented Jun 11, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@Jibing-Li

Jibing-Li commented Jun 12, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

6 similar comments
@Jibing-Li

Jibing-Li commented Jun 12, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

@Jibing-Li

Jibing-Li commented Jun 12, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

@Jibing-Li

Jibing-Li commented Jun 12, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

@Jibing-Li

Jibing-Li commented Jun 12, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

@Jibing-Li

Jibing-Li commented Jun 12, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

@Jibing-Li

Jibing-Li commented Jun 12, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

@Jibing-Li

Jibing-Li commented Jun 12, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

1 similar comment
@Jibing-Li

Jibing-Li commented Jun 13, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@Jibing-Li

Jibing-Li commented Jun 13, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

2 similar comments
@Jibing-Li

Jibing-Li commented Jun 13, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

@Jibing-Li

Jibing-Li commented Jun 13, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

@yiguolei
yiguolei merged commit 1a16493 into apache:branch-2.1Jun 13, 2025
@Jibing-Li
Jibing-Li deleted the null2.1 branch June 13, 2025 07:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jibing-Li@hello-stephen@yiguolei