[enhance](meta-service)add bvar for ms kv get del put count by koarz · Pull Request #51708 · apache/doris

koarz · 2025-06-13T10:33:49Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-06-13T10:33:53Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

koarz · 2025-06-18T09:20:17Z

run buildall

koarz · 2025-06-18T09:46:41Z

run buildall

koarz · 2025-06-18T09:51:23Z

run buildall

koarz · 2025-06-18T10:49:52Z

run buildall

koarz · 2025-06-19T02:48:49Z

run buildall

koarz · 2025-06-19T09:53:25Z

run buildall

koarz · 2025-06-25T07:35:52Z

run buildall

hello-stephen · 2025-06-25T07:46:58Z

Cloud UT Coverage Report

Increment line coverage 97.36% (258/265) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	83.93% (1154/1375)
Line Coverage	67.37% (19689/29224)
Region Coverage	67.70% (10113/14937)
Branch Coverage	56.92% (5282/9280)

github-actions · 2025-06-26T02:32:31Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-06-26T02:32:33Z

PR approved by anyone and no changes requested.

dataroaring

LGTM

…1708)

#51708 (#52482) Cherry-picked from #51708

…nt (#52714) pick: #51708

[enhance](meta-service)add bvar for ms kv read write count
e17fd49

koarz requested review from dataroaring, gavinchou and w41ter as code owners June 13, 2025 10:33

koarz marked this pull request as draft June 13, 2025 10:34

gavinchou added dev/3.0.x cloud labels Jun 16, 2025

gavinchou reviewed Jun 16, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp

gavinchou reviewed Jun 16, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated

Merge branch 'master' into kv_bvar
6680c5e

gavinchou reviewed Jun 16, 2025
View reviewed changes

Comment threadcloud/src/meta-service/mem_txn_kv.h Outdated
Comment threadcloud/src/common/bvars.cpp
Comment threadcloud/src/meta-service/meta_service_helper.h Outdated

update
490aac0

koarz changed the title ~~[enhance](meta-service)add bvar for ms kv read write count~~[enhance](meta-service)add bvar for ms kv get del put countJun 18, 2025

koarz added 2 commits June 18, 2025 17:05

remove useless code
62de960

format
2bd4d2a

koarz added 2 commits June 18, 2025 17:34

fix
97f7da5

1
9413cb8

koarz added 2 commits June 18, 2025 17:50

format
41f92f0

Merge branch 'master' into kv_bvar
fa5ee64

fix
f2c7e36

koarz added 2 commits June 19, 2025 10:07

fix
ff92fdf

fix
eaba369

fix
b665bf0

gavinchou reviewed Jun 24, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service_schema.cpp Outdated

gavinchou reviewed Jun 24, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service_txn.cpp

gavinchou reviewed Jun 24, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service_txn.cpp Outdated

gavinchou reviewed Jun 24, 2025
View reviewed changes

Comment threadcloud/src/meta-service/txn_kv.cpp Outdated

koarz added 2 commits June 25, 2025 15:15

fix
3efdecc

format
2cb9a85

gavinchou approved these changes Jun 26, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 26, 2025

github-actionsBot added the reviewed label Jun 26, 2025

dataroaring approved these changes Jun 26, 2025
View reviewed changes

dataroaring merged commit b6f4cd2 into apache:masterJun 26, 2025

github-actionsBot added the dev/3.0.x-conflict label Jun 26, 2025

koarz deleted the kv_bvar branch June 26, 2025 02:56

gavinchou added the dev/3.1.x label Jun 26, 2025

github-actionsBot added the dev/3.1.x-conflict label Jun 26, 2025

koarz pushed a commit to koarz/doris that referenced this pull request Jun 30, 2025
[enhance](meta-service)add bvar for ms kv get del put count (apache#5…
bc40634
…1708)

koarz mentioned this pull request Jun 30, 2025
branch-3.1 [enhance](meta-service)add bvar for ms kv get del put count #52482
Merged

morrySnow pushed a commit that referenced this pull request Jun 30, 2025
branch-3.1: [enhance](meta-service)add bvar for ms kv get del put count
c988e82
#51708 (#52482) Cherry-picked from #51708

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Jun 30, 2025

koarz mentioned this pull request Jul 3, 2025
branch-3.0: [enhance](meta-service)add bvar for ms kv get del put count #52714
Merged

dataroaring pushed a commit that referenced this pull request Jul 8, 2025
branch-3.0: [enhance](meta-service)add bvar for ms kv get del put cou…
9a45101
…nt (#52714) pick: #51708

dataroaring added dev/3.0.7-merged and removed dev/3.0.x dev/3.0.x-conflict labels Jul 8, 2025

Uh oh!

Conversation

koarz commented Jun 13, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jun 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koarz commented Jun 18, 2025

Uh oh!

koarz commented Jun 18, 2025

Uh oh!

koarz commented Jun 18, 2025

Uh oh!

koarz commented Jun 18, 2025

Uh oh!

koarz commented Jun 19, 2025

Uh oh!

koarz commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koarz commented Jun 25, 2025

Uh oh!

hello-stephen commented Jun 25, 2025

Cloud UT Coverage Report

Uh oh!

github-actionsBot commented Jun 26, 2025

Uh oh!

github-actionsBot commented Jun 26, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants