Skip to content

[cherry-pick](branch-21) fix array_map cause coredump as NULL (#51618) - #51742

Merged
yiguolei merged 2 commits into
apache:branch-2.1from
zhangstar333:branch-2.1-0616
Jun 16, 2025
Merged

[cherry-pick](branch-21) fix array_map cause coredump as NULL (#51618)#51742
yiguolei merged 2 commits into
apache:branch-2.1from
zhangstar333:branch-2.1-0616

Conversation

@zhangstar333

@zhangstar333zhangstar333 commented Jun 16, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Problem Summary:
cherry-pick from #51618

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zhangstar333
[bug](function) fix array_map cause coredump as NULL (apache#51618)
ffd38e1
if column_array is NULL, we know the array_data_column will not write
any data,
so the column is empty. eg : (x) -> concat('|',x + "1"). if still
execute the lambda function, will cause the bolck rows are not equal.
the x column is empty, but "|" is const literal, size of column is 1, so
the block rows is 1, but the x column is empty, will be coredump.
@hello-stephen

hello-stephen commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333

zhangstar333 commented Jun 16, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@zhangstar333

zhangstar333 commented Jun 16, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jun 16, 2025

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 0.00% (0/27) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage39.02% (10328/26468)
Line Coverage30.04% (85826/285751)
Region Coverage28.70% (44290/154298)
Branch Coverage25.42% (22660/89138)

@hello-stephen

hello-stephen commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (27/27) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage74.61% (19455/26074)
Line Coverage69.43% (197127/283928)
Region Coverage67.00% (120332/179594)
Branch Coverage60.11% (60575/100774)

@yiguolei
yiguolei merged commit 56d87c7 into apache:branch-2.1Jun 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhangstar333@hello-stephen@doris-robot@yiguolei