Skip to content

branch-3.0: [fix](filecache) fix load_cache_info_into_memory crash #51684 - #51904

Merged
dataroaring merged 1 commit into
branch-3.0from
auto-pick-51684-branch-3.0
Jun 19, 2025
Merged

branch-3.0: [fix](filecache) fix load_cache_info_into_memory crash #51684#51904
dataroaring merged 1 commit into
branch-3.0from
auto-pick-51684-branch-3.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Cherry-picked from #51684

@freemandealerYour Name
[fix](filecache) fix load_cache_info_into_memory crash (#51684)
c6a04d0
keep _storage last so it will deconstruct first
otherwise, load_cache_info_into_memory might crash coz it will use other
members of BlockFileCache
so join this async load thread first
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@Thearas

Thearas commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Thearas

Thearas commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

doris-robot commented Jun 18, 2025

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage41.16% (10902/26487)
Line Coverage31.97% (93256/291696)
Region Coverage31.05% (48091/154897)
Branch Coverage27.51% (24626/89528)

dataroaring
dataroaring approved these changes Jun 19, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 5970c82 into branch-3.0Jun 19, 2025
@github-actions
github-actionsBot deleted the auto-pick-51684-branch-3.0 branch June 19, 2025 08:25
@gavinchougavinchou mentioned this pull request Aug 15, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas@doris-robot@dataroaring@freemandealer