Skip to content

branch-3.0 [fix](nereids) fix bug in LogicalIntersect datatrait OutofBounds exception - #52170

Merged
dataroaring merged 1 commit into
apache:branch-3.0from
englefly:intersect-datatrait-3.0
Jul 7, 2025
Merged

branch-3.0 [fix](nereids) fix bug in LogicalIntersect datatrait OutofBounds exception#52170
dataroaring merged 1 commit into
apache:branch-3.0from
englefly:intersect-datatrait-3.0

Conversation

@englefly

@engleflyenglefly commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

pick part of #49947
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
englefly changed the base branch from master to branch-3.0June 24, 2025 02:57
@englefly

englefly commented Jun 24, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2025
@github-actions

github-actionsBot commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Jun 24, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 39686 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 67105360f48e2784a780b8b8fea2e7d1e3615f51, data reload: false
------ Round 1 ----------------------------------
q1	17915	7880	6585	6585
q2	2065	178	180	178
q3	8703	1157	1185	1157
q4	10136	723	750	723
q5	7768	2867	2787	2787
q6	211	133	134	133
q7	994	623	609	609
q8	9329	1977	1995	1977
q9	6629	6417	6408	6408
q10	7041	2257	2288	2257
q11	475	261	268	261
q12	403	222	212	212
q13	11111	2957	3003	2957
q14	245	224	214	214
q15	523	468	468	468
q16	493	396	369	369
q17	979	591	583	583
q18	7382	6577	6719	6577
q19	1394	1046	1052	1046
q20	453	203	203	203
q21	3901	2981	3080	2981
q22	1111	1001	1002	1001
Total cold run time: 99261 ms
Total hot run time: 39686 ms
----- Round 2, with runtime_filter_mode=off -----
q1	6615	6544	6589	6544
q2	332	227	234	227
q3	2887	2808	2771	2771
q4	1946	1774	1699	1699
q5	5496	5632	5656	5632
q6	206	124	124	124
q7	2198	1811	1818	1811
q8	3311	3453	3516	3453
q9	8863	8924	9032	8924
q10	3608	3519	3529	3519
q11	602	501	495	495
q12	829	597	579	579
q13	6852	3015	3178	3015
q14	289	286	268	268
q15	510	471	465	465
q16	460	435	433	433
q17	1880	1660	1572	1572
q18	8334	7815	7701	7701
q19	1690	1617	1692	1617
q20	2109	1909	1860	1860
q21	5164	4939	4949	4939
q22	1158	1060	1061	1060
Total cold run time: 65339 ms
Total hot run time: 58708 ms

@doris-robot

doris-robot commented Jun 24, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 191586 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 67105360f48e2784a780b8b8fea2e7d1e3615f51, data reload: false
query1	926	409	362	362
query2	6508	1887	1911	1887
query3	6528	217	216	216
query4	33290	23473	23935	23473
query5	4333	446	460	446
query6	280	168	176	168
query7	4634	312	321	312
query8	273	206	206	206
query9	9555	2542	2554	2542
query10	479	254	259	254
query11	18353	15139	15545	15139
query12	155	104	101	101
query13	1643	418	403	403
query14	9295	7256	7036	7036
query15	249	172	180	172
query16	8112	474	492	474
query17	1510	606	555	555
query18	2189	302	311	302
query19	281	147	159	147
query20	125	114	115	114
query21	204	100	105	100
query22	4764	4531	4502	4502
query23	35117	34744	34093	34093
query24	11695	2923	2923	2923
query25	681	451	417	417
query26	1466	176	171	171
query27	3150	341	342	341
query28	8056	2154	2141	2141
query29	964	468	475	468
query30	322	159	161	159
query31	1158	800	836	800
query32	97	60	58	58
query33	799	313	303	303
query34	1304	530	512	512
query35	862	723	713	713
query36	1101	953	951	951
query37	131	70	71	70
query38	4113	4001	4008	4001
query39	1542	1487	1458	1458
query40	286	104	104	104
query41	54	50	49	49
query42	123	111	98	98
query43	502	451	479	451
query44	1277	780	787	780
query45	183	160	168	160
query46	1151	718	712	712
query47	1952	1833	1893	1833
query48	465	391	380	380
query49	1114	418	411	411
query50	822	411	416	411
query51	7402	7202	7200	7200
query52	103	91	90	90
query53	254	184	184	184
query54	1255	475	485	475
query55	80	81	76	76
query56	294	258	251	251
query57	1262	1169	1163	1163
query58	233	215	214	214
query59	3026	2872	2867	2867
query60	289	273	258	258
query61	151	142	104	104
query62	850	658	654	654
query63	212	183	183	183
query64	5311	632	598	598
query65	3292	3166	3176	3166
query66	1219	297	279	279
query67	15982	15653	15625	15625
query68	4909	556	547	547
query69	445	268	263	263
query70	1214	1088	1125	1088
query71	353	254	254	254
query72	6380	4108	4085	4085
query73	746	348	340	340
query74	9478	9048	8983	8983
query75	3381	2585	2689	2585
query76	2898	1077	1017	1017
query77	447	272	280	272
query78	10638	9551	9548	9548
query79	1550	590	592	590
query80	1154	432	423	423
query81	538	226	222	222
query82	894	90	84	84
query83	235	141	146	141
query84	268	82	82	82
query85	1411	303	287	287
query86	397	290	284	284
query87	4448	4282	4238	4238
query88	3675	2402	2344	2344
query89	388	295	286	286
query90	1993	186	182	182
query91	183	147	149	147
query92	60	49	50	49
query93	1229	562	567	562
query94	961	277	296	277
query95	356	258	255	255
query96	613	280	276	276
query97	3286	3141	3138	3138
query98	213	199	195	195
query99	1517	1276	1278	1276
Total cold run time: 301646 ms
Total hot run time: 191586 ms

@doris-robot

doris-robot commented Jun 24, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 30 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 67105360f48e2784a780b8b8fea2e7d1e3615f51, data reload: false
query1	0.03	0.03	0.03
query2	0.08	0.03	0.04
query3	0.23	0.06	0.06
query4	1.61	0.10	0.10
query5	0.54	0.50	0.52
query6	1.14	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.02	0.03
query9	0.56	0.50	0.51
query10	0.56	0.56	0.55
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.59
query14	0.75	0.80	0.81
query15	0.83	0.82	0.83
query16	0.37	0.38	0.37
query17	1.04	1.00	1.05
query18	0.25	0.23	0.23
query19	1.94	1.88	1.87
query20	0.01	0.01	0.01
query21	15.39	0.58	0.57
query22	2.36	1.76	1.79
query23	17.11	0.92	0.95
query24	3.06	0.69	1.37
query25	0.12	0.15	0.07
query26	0.59	0.14	0.14
query27	0.04	0.04	0.04
query28	10.38	0.48	0.52
query29	12.60	3.22	3.22
query30	0.25	0.06	0.06
query31	2.89	0.39	0.38
query32	3.23	0.47	0.46
query33	2.95	3.01	3.02
query34	16.98	4.52	4.43
query35	4.55	4.59	4.55
query36	0.65	0.50	0.48
query37	0.08	0.06	0.07
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.14
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.5 s
Total hot run time: 30 s

@englefly

englefly commented Jul 1, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

@engleflyenglefly changed the title [fix](nereids) fix bug in LogicalIntersect datatrait OutofBounds exceptionbranch-3.0 [fix](nereids) fix bug in LogicalIntersect datatrait OutofBounds exceptionJul 4, 2025
dataroaring
dataroaring approved these changes Jul 7, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 3a6a2b6 into apache:branch-3.0Jul 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes
@morrySnowmorrySnowmorrySnow approved these changes
@gavinchougavinchouAwaiting requested review from gavinchou
@w41terw41terAwaiting requested review from w41ter
@morningmanmorningmanAwaiting requested review from morningman
@yiguoleiyiguoleiAwaiting requested review from yiguolei
@xiaokangxiaokangAwaiting requested review from xiaokang
@CalvinKirsCalvinKirsAwaiting requested review from CalvinKirs
@BiteTheDDDDtBiteTheDDDDtAwaiting requested review from BiteTheDDDDt

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@englefly@hello-stephen@doris-robot@dataroaring@morrySnow