Skip to content

[fix](cloud) fix filecache warmup crash due to memory corruption#52394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XLPE wants to merge 4 commits into from
Closed

[fix](cloud) fix filecache warmup crash due to memory corruption #52394

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60cba3e
fix coredump
Jun 27, 2025
80842ea
Merge branch 'master' into fix-warmupjob
XLPE Jun 27, 2025
4796535
format
Jun 27, 2025
f9ab15e
line by line
Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions be/src/cloud/cloud_warm_up_manager.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -122,11 +122,6 @@ void CloudWarmUpManager::handle_jobs() {
cur_job = _pending_job_metas.front();
}

if (!cur_job) {
LOG_WARNING("Warm up job is null");
continue;
}

std::shared_ptr<bthread::CountdownEvent> wait =
std::make_shared<bthread::CountdownEvent>(0);

Expand DownExpand Up@@ -212,8 +207,11 @@ void CloudWarmUpManager::handle_jobs() {
}
{
std::unique_lock lock(_mtx);
_finish_job.push_back(cur_job);
_pending_job_metas.pop_front();
// If it is empty, it means the job has been cleared during the lock release period.
if (!_pending_job_metas.empty()) {
_finish_job.push_back(cur_job);
_pending_job_metas.pop_front();
}
}
}
#endif
Expand DownExpand Up@@ -296,6 +294,9 @@ std::tuple<int64_t, int64_t, int64_t, int64_t> CloudWarmUpManager::get_current_j
Status CloudWarmUpManager::clear_job(int64_t job_id) {
std::lock_guard lock(_mtx);
Status st = Status::OK();
if (_cur_job_id == 0) {
return st;
}
if (job_id == _cur_job_id) {
_cur_job_id = 0;
_cur_batch_id = -1;
Expand Down