[enhance](meta-service)collect fdb kv meta range info as metrics by koarz · Pull Request #52430 · apache/doris

koarz · 2025-06-27T07:51:16Z

such as these key:

recycle|default_instance_id|txn: 1
meta|default_instance_id|tablet_index: 1
meta|default_instance_id|rowset_tmp: 1

collect to result:

fdb_kv_ranges_count{category="recycle",instance_id="default_instance_id",sub_category="txn"} 1
fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="tablet_index"} 1
fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="rowset_tmp"} 1

hello-stephen · 2025-06-27T07:51:34Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

koarz · 2025-06-27T07:52:21Z

run buildall

koarz · 2025-06-27T08:15:38Z

run buildall

koarz · 2025-06-27T10:28:29Z

run buildall

koarz · 2025-06-28T06:24:10Z

run buildall

doris-robot · 2025-06-28T06:44:42Z

Cloud UT Coverage Report

Increment line coverage 11.59% (8/69) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	83.48% (1172/1404)
Line Coverage	67.37% (20665/30676)
Region Coverage	67.00% (10271/15329)
Branch Coverage	56.25% (5374/9554)

koarz · 2025-06-29T08:12:04Z

run buildall

hello-stephen · 2025-06-29T08:30:52Z

Cloud UT Coverage Report

Increment line coverage 10.67% (8/75) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	83.48% (1172/1404)
Line Coverage	67.41% (20659/30646)
Region Coverage	67.01% (10261/15313)
Branch Coverage	56.31% (5373/9542)

koarz · 2025-06-29T14:47:14Z

run cloud_p0

koarz · 2025-06-30T02:30:10Z

run buildall

hello-stephen · 2025-06-30T02:37:14Z

Cloud UT Coverage Report

Increment line coverage 10.81% (8/74) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	83.48% (1172/1404)
Line Coverage	67.36% (20644/30645)
Region Coverage	67.01% (10261/15313)
Branch Coverage	56.28% (5370/9542)

koarz · 2025-07-03T03:54:48Z

run buildall

doris-robot · 2025-07-03T04:06:24Z

Cloud UT Coverage Report

Increment line coverage 8.16% (8/98) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	82.51% (1189/1441)
Line Coverage	67.26% (20747/30847)
Region Coverage	66.87% (10317/15429)
Branch Coverage	56.19% (5392/9596)

github-actions · 2025-07-11T04:59:53Z

PR approved by anyone and no changes requested.

hello-stephen · 2025-07-11T05:15:44Z

Cloud UT Coverage Report

Increment line coverage 10.13% (8/79) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.98% (1269/1548)
Line Coverage	67.69% (21616/31936)
Region Coverage	67.36% (10732/15932)
Branch Coverage	56.87% (5652/9938)

dataroaring

LGTM

koarz · 2025-07-11T06:18:21Z

run buildall

doris-robot · 2025-07-11T06:41:19Z

Cloud UT Coverage Report

Increment line coverage 10.13% (8/79) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	82.02% (1273/1552)
Line Coverage	67.83% (21749/32062)
Region Coverage	67.43% (10762/15960)
Branch Coverage	56.97% (5671/9954)

github-actions · 2025-07-11T07:59:57Z

PR approved by at least one committer and no changes requested.

) API show_meta_ranges http response ```text recycle|default_instance_id|txn: 1 meta|default_instance_id|tablet_index: 1 meta|default_instance_id|rowset_tmp: 1 ``` metrics ```text fdb_kv_ranges_count{category="recycle",instance_id="default_instance_id",sub_category="txn"} 1 fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="tablet_index"} 1 fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="rowset_tmp"} 1 ```

…metrics #52430 (#53116) Cherry-picked from #52430 Co-authored-by: koarz <lihao@selectdb.com>

…che#52430) API show_meta_ranges http response ```text recycle|default_instance_id|txn: 1 meta|default_instance_id|tablet_index: 1 meta|default_instance_id|rowset_tmp: 1 ``` metrics ```text fdb_kv_ranges_count{category="recycle",instance_id="default_instance_id",sub_category="txn"} 1 fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="tablet_index"} 1 fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="rowset_tmp"} 1 ```

…metrics #52430 (#53179) picked from #52430

koarz requested review from dataroaring, gavinchou and w41ter as code owners June 27, 2025 07:51

gavinchou requested changes Jul 1, 2025
View reviewed changes

Comment threadcloud/src/common/metric.cpp Outdated
Comment threadcloud/src/common/metric.cpp Outdated
Comment threadcloud/src/common/metric.cpp

gavinchou added dev/3.0.x dev/3.1.x cloud labels Jul 3, 2025

gavinchou reviewed Jul 3, 2025
View reviewed changes

Comment threadcloud/src/meta-service/keys.cpp

gavinchou reviewed Jul 3, 2025
View reviewed changes

Comment threadcloud/src/common/metric.cpp Outdated

koarzand others added 8 commits July 4, 2025 14:45

1
b7c8534

[enhance](meta-service)collect meta range info as metrics
0b70919

fix
8774fa4

fix
75fb948

use dynamic cast
ef05f11

code
40cf760

remove msg
a631b09

fix
8e266bd

github-actionsBot added the reviewed label Jul 11, 2025

dataroaring previously approved these changes Jul 11, 2025
View reviewed changes

Merge branch 'master' into show_meta_ranges
f6637fe

koarz dismissed stale reviews from dataroaring and gavinchou via f6637feJuly 11, 2025 06:18

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jul 11, 2025

gavinchou approved these changes Jul 11, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 11, 2025

Hastyshell approved these changes Jul 11, 2025
View reviewed changes

gavinchou changed the title ~~[enhance](meta-service)collect meta range info as metrics~~[enhance](meta-service)collect fdb kv meta range info as metricsJul 11, 2025

gavinchou merged commit 5ad2b74 into apache:masterJul 11, 2025

github-actionsBot mentioned this pull request Jul 11, 2025
branch-3.0: [enhance](meta-service)collect fdb kv meta range info as metrics #52430 #53116
Merged

github-actionsBot added the dev/3.1.x-conflict label Jul 11, 2025

koarz deleted the show_meta_ranges branch July 11, 2025 08:59

dataroaring pushed a commit that referenced this pull request Jul 12, 2025
branch-3.0: [enhance](meta-service)collect fdb kv meta range info as …
358c2aa
…metrics #52430 (#53116) Cherry-picked from #52430 Co-authored-by: koarz <lihao@selectdb.com>

dataroaring added dev/3.0.7-merged and removed dev/3.0.x labels Jul 12, 2025

koarz mentioned this pull request Jul 14, 2025
branch-3.1: [enhance](meta-service)collect fdb kv meta range info as metrics #52430 #53179
Merged

morrySnow pushed a commit that referenced this pull request Jul 14, 2025
branch-3.1: [enhance](meta-service)collect fdb kv meta range info as …
a90c803
…metrics #52430 (#53179) picked from #52430

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Jul 14, 2025

gavinchou mentioned this pull request Aug 15, 2025
Release Note 3.0.7 #54868
Closed

Uh oh!

Conversation

koarz commented Jun 27, 2025• edited by gavinchou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hello-stephen commented Jun 27, 2025

Uh oh!

koarz commented Jun 27, 2025

Uh oh!

koarz commented Jun 27, 2025

Uh oh!

koarz commented Jun 27, 2025

Uh oh!

koarz commented Jun 28, 2025

Uh oh!

doris-robot commented Jun 28, 2025

Cloud UT Coverage Report

Uh oh!

koarz commented Jun 29, 2025

Uh oh!

hello-stephen commented Jun 29, 2025

Cloud UT Coverage Report

Uh oh!

koarz commented Jun 29, 2025

Uh oh!

koarz commented Jun 30, 2025

Uh oh!

hello-stephen commented Jun 30, 2025

Cloud UT Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koarz commented Jul 3, 2025

Uh oh!

doris-robot commented Jul 3, 2025

Cloud UT Coverage Report

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Jul 11, 2025

Uh oh!

hello-stephen commented Jul 11, 2025

Cloud UT Coverage Report

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

koarz commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

Cloud UT Coverage Report

Uh oh!

github-actionsBot commented Jul 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

koarz commented Jun 27, 2025•
edited by gavinchou
Loading