Skip to content

[Opt](cloud-mow) Do fast retry when commit compaction job for mow tablet - #52476

Merged
dataroaring merged 4 commits into
apache:masterfrom
bobhan1:fast-retry-for-mow-compaction-job-commit
Jul 7, 2025
Merged

[Opt](cloud-mow) Do fast retry when commit compaction job for mow tablet#52476
dataroaring merged 4 commits into
apache:masterfrom
bobhan1:fast-retry-for-mow-compaction-job-commit

Conversation

@bobhan1

@bobhan1bobhan1 commented Jun 30, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Before:

image

After

image

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
bobhan1force-pushed the fast-retry-for-mow-compaction-job-commit branch from 922e0ed to 142bae5CompareJune 30, 2025 02:40
@bobhan1

bobhan1 commented Jun 30, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 79.03% (49/62) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage83.51% (1170/1401)
Line Coverage67.40% (20616/30586)
Region Coverage67.02% (10256/15302)
Branch Coverage56.23% (5362/9536)

@bobhan1
bobhan1 marked this pull request as ready for review June 30, 2025 07:52
@bobhan1
bobhan1force-pushed the fast-retry-for-mow-compaction-job-commit branch 2 times, most recently from 97ee8a6 to abde7f0CompareJuly 1, 2025 02:30
zhannngchen
zhannngchen previously approved these changes Jul 1, 2025
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 1, 2025
@github-actions

github-actionsBot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring reviewed Jul 1, 2025
View reviewed changes
Comment threadcloud/src/meta-service/meta_service_job.cpp Outdated
return;
}
for (int retry = 0; retry <= 1; retry++) {
response->Clear();

@dataroaringdataroaringJul 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msg should be empty.

mymeiyi
mymeiyi reviewed Jul 1, 2025
View reviewed changes
Comment threadcloud/src/meta-service/meta_service_job.cpp Outdated
}
}

if (retry == 0 && !request->job().compaction().empty() &&

@mymeiyimymeiyiJul 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast retry only when the err is TxnErrorCode::TXN_CONFLICT?

@bobhan1
bobhan1force-pushed the fast-retry-for-mow-compaction-job-commit branch from abde7f0 to 233e234CompareJuly 1, 2025 08:21
@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jul 1, 2025
@bobhan1

bobhan1 commented Jul 1, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jul 1, 2025

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 75.38% (49/65) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage83.51% (1170/1401)
Line Coverage67.42% (20622/30589)
Region Coverage67.02% (10256/15302)
Branch Coverage56.25% (5364/9536)

zhannngchen
zhannngchen approved these changes Jul 4, 2025
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 4, 2025
@github-actions

github-actionsBot commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

dataroaring
dataroaring approved these changes Jul 7, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 285b1e4 into apache:masterJul 7, 2025
github-actionsBot pushed a commit that referenced this pull request Jul 7, 2025
@bobhan1Your Name
[Opt](cloud-mow) Do fast retry when commit compaction job for mow tab…
0d83189
…let (#52476)
### What problem does this PR solve?
#### Before:
![image](https://github.com/user-attachments/assets/7494627e-f13b-4293-8eba-43e08dffd427)
#### After
![image](https://github.com/user-attachments/assets/e03de5b7-8ddd-403c-bd1d-79d57fc22d6d)
@github-actionsgithub-actionsBot mentioned this pull request Jul 7, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 7, 2025
@github-actions@bobhan1
branch-3.1: [Opt](cloud-mow) Do fast retry when commit compaction job…
a236d1f
… for mow tablet #52476 (#52843)
Cherry-picked from #52476
Co-authored-by: bobhan1 <baohan@selectdb.com>
etah000 pushed a commit to etah000/doris that referenced this pull request Jul 7, 2025
@github-actions@bobhan1@etah000
branch-3.1: [Opt](cloud-mow) Do fast retry when commit compaction job…
37c8e96
… for mow tablet apache#52476 (apache#52843)
Cherry-picked from apache#52476
Co-authored-by: bobhan1 <baohan@selectdb.com>
bobhan1 added a commit to bobhan1/doris that referenced this pull request Jul 8, 2025
@bobhan1
[Opt](cloud-mow) Do fast retry when commit compaction job for mow tab…
3345841
…let (apache#52476)
![image](https://github.com/user-attachments/assets/7494627e-f13b-4293-8eba-43e08dffd427)
![image](https://github.com/user-attachments/assets/e03de5b7-8ddd-403c-bd1d-79d57fc22d6d)
@bobhan1bobhan1 mentioned this pull request Jul 8, 2025
Merged
bobhan1 added a commit to bobhan1/doris that referenced this pull request Jul 8, 2025
@bobhan1
[Opt](cloud-mow) Do fast retry when commit compaction job for mow tab…
67021d6
…let (apache#52476)
![image](https://github.com/user-attachments/assets/7494627e-f13b-4293-8eba-43e08dffd427)
![image](https://github.com/user-attachments/assets/e03de5b7-8ddd-403c-bd1d-79d57fc22d6d)
dataroaring pushed a commit that referenced this pull request Jul 9, 2025
@bobhan1
branch-3.0; [Opt](cloud-mow) Do fast retry when commit compaction job…
9c5e721
… for mow tablet (#52476) (#52952)
pick #52476
@gavinchougavinchou mentioned this pull request Aug 15, 2025
Closed
csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025
@bobhan1
(hubspot 4.0.5) [Opt](cloud-mow) Do fast retry when commit compaction…
e9fe181
… job for mow tablet apache#52476 (apache#4149)
pick apache#52476
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mymeiyimymeiyimymeiyi approved these changes
@zhannngchenzhannngchenzhannngchen approved these changes
@dataroaringdataroaringdataroaring approved these changes
@gavinchougavinchouAwaiting requested review from gavinchougavinchou is a code owner
@w41terw41terAwaiting requested review from w41ter

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.7-mergeddev/3.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bobhan1@Thearas@hello-stephen@doris-robot@mymeiyi@zhannngchen@dataroaring@morrySnow