[fix](be) Fix `check_storage_vault` deadlock by swjtu-zhanglei · Pull Request #52541 · apache/doris

swjtu-zhanglei · 2025-06-30T09:57:15Z

[feat](storage vault) Check storage vault connectivity for BE when starting #51175 introduced a deadlock problem:
1. the sync_storage_vault() func wait for heartbeat thread to set config::meta_service_endpoint
2. the heartbeat thread wait for the sync_storage_vault() func success to start

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

swjtu-zhanglei · 2025-06-30T09:57:35Z

run buildall

Thearas · 2025-06-30T09:58:18Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

swjtu-zhanglei · 2025-06-30T10:52:13Z

run performance

doris-robot · 2025-06-30T11:49:02Z

BE UT Coverage Report

Increment line coverage 0.00% (0/12) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.08% (15346/26885)
Line Coverage	46.16% (139397/301964)
Region Coverage	45.47% (70648/155376)
Branch Coverage	40.24% (37311/92716)

doris-robot · 2025-06-30T12:23:58Z

TPC-H: Total hot run time: 34005 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 75d87ce932f2d189b2040e80db1149508c1ae6b2, data reload: false
------ Round 1 ----------------------------------
q1	17586	5158	5003	5003
q2	1949	286	210	210
q3	10337	1310	726	726
q4	10228	1039	524	524
q5	7662	2435	2386	2386
q6	182	162	128	128
q7	905	747	604	604
q8	9335	1351	1049	1049
q9	7065	5289	5155	5155
q10	6888	2405	1979	1979
q11	474	292	273	273
q12	353	347	211	211
q13	17770	3664	3114	3114
q14	223	238	217	217
q15	530	482	480	480
q16	423	442	385	385
q17	604	858	355	355
q18	7583	7094	7168	7094
q19	1206	971	561	561
q20	333	344	221	221
q21	3834	3142	2362	2362
q22	1033	1007	968	968
Total cold run time: 106503 ms
Total hot run time: 34005 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5149	5079	5130	5079
q2	238	322	214	214
q3	2143	2670	2309	2309
q4	1382	1842	1364	1364
q5	4257	4453	4522	4453
q6	218	170	124	124
q7	2015	1951	1769	1769
q8	2684	2573	2621	2573
q9	7121	7247	7158	7158
q10	3074	3329	2818	2818
q11	567	506	494	494
q12	660	766	640	640
q13	3524	3888	3259	3259
q14	284	305	261	261
q15	509	476	467	467
q16	445	481	422	422
q17	1189	1614	1359	1359
q18	7737	7452	7713	7452
q19	832	836	967	836
q20	1931	2114	1948	1948
q21	4938	4539	4324	4324
q22	1095	1054	966	966
Total cold run time: 51992 ms
Total hot run time: 50289 ms

doris-robot · 2025-06-30T12:35:33Z

TPC-DS: Total hot run time: 185892 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 75d87ce932f2d189b2040e80db1149508c1ae6b2, data reload: false
query1	995	387	385	385
query2	6534	1719	1699	1699
query3	6755	210	207	207
query4	26410	23499	23431	23431
query5	4378	580	432	432
query6	306	226	199	199
query7	4624	507	314	314
query8	272	221	213	213
query9	8653	2652	2664	2652
query10	453	322	265	265
query11	15711	15137	14816	14816
query12	153	104	103	103
query13	1655	517	379	379
query14	8930	5603	5609	5603
query15	201	184	177	177
query16	7228	653	494	494
query17	1172	707	551	551
query18	1974	394	297	297
query19	187	186	165	165
query20	123	114	117	114
query21	206	123	108	108
query22	4115	4038	4126	4038
query23	34162	33238	33192	33192
query24	8491	2378	2396	2378
query25	536	463	389	389
query26	1241	272	154	154
query27	2752	513	337	337
query28	4324	2137	2121	2121
query29	774	603	466	466
query30	279	214	184	184
query31	950	832	746	746
query32	69	64	60	60
query33	549	363	303	303
query34	791	852	525	525
query35	779	844	742	742
query36	958	938	875	875
query37	116	105	77	77
query38	4212	4115	4030	4030
query39	1471	1418	1422	1418
query40	210	116	103	103
query41	61	54	52	52
query42	120	105	103	103
query43	476	497	484	484
query44	1311	845	807	807
query45	180	172	163	163
query46	855	1027	632	632
query47	1792	1786	1731	1731
query48	384	420	323	323
query49	736	463	389	389
query50	619	702	421	421
query51	4155	4159	4213	4159
query52	106	105	99	99
query53	227	251	183	183
query54	576	562	508	508
query55	82	82	81	81
query56	318	282	303	282
query57	1222	1192	1125	1125
query58	295	256	278	256
query59	2567	2787	2562	2562
query60	323	323	292	292
query61	125	120	121	120
query62	809	712	697	697
query63	224	187	185	185
query64	4311	1000	700	700
query65	4294	4197	4200	4197
query66	1155	423	345	345
query67	16084	15598	15676	15598
query68	5801	896	546	546
query69	498	330	273	273
query70	1145	1096	1086	1086
query71	401	327	281	281
query72	5770	4994	5076	4994
query73	704	680	350	350
query74	9025	9101	8870	8870
query75	3187	3201	2736	2736
query76	3215	1160	724	724
query77	488	378	285	285
query78	10106	10194	9336	9336
query79	2768	817	600	600
query80	1621	500	571	500
query81	575	256	229	229
query82	718	126	93	93
query83	313	252	230	230
query84	256	103	80	80
query85	820	355	314	314
query86	464	294	289	289
query87	4450	4482	4380	4380
query88	3899	2288	2283	2283
query89	383	310	276	276
query90	1901	210	203	203
query91	132	145	110	110
query92	78	58	54	54
query93	2571	936	595	595
query94	763	464	306	306
query95	374	291	280	280
query96	499	576	281	281
query97	2681	2759	2636	2636
query98	233	210	200	200
query99	1352	1425	1236	1236
Total cold run time: 274297 ms
Total hot run time: 185892 ms

doris-robot · 2025-06-30T12:40:49Z

ClickBench: Total hot run time: 29.83 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 75d87ce932f2d189b2040e80db1149508c1ae6b2, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.24	0.08	0.08
query4	1.61	0.11	0.10
query5	0.44	0.43	0.43
query6	1.16	0.66	0.67
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.59	0.52	0.53
query10	0.58	0.57	0.58
query11	0.16	0.10	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.62
query14	0.83	0.82	0.82
query15	0.91	0.88	0.87
query16	0.38	0.39	0.38
query17	1.08	1.11	1.06
query18	0.22	0.21	0.21
query19	1.94	1.78	1.88
query20	0.01	0.01	0.01
query21	15.40	0.89	0.54
query22	0.75	1.14	0.74
query23	14.91	1.40	0.62
query24	6.83	1.62	0.90
query25	0.50	0.15	0.15
query26	0.66	0.16	0.13
query27	0.07	0.05	0.05
query28	10.00	0.89	0.44
query29	12.53	3.91	3.31
query30	0.26	0.10	0.07
query31	2.82	0.59	0.39
query32	3.24	0.56	0.48
query33	3.02	3.12	3.17
query34	15.89	5.43	4.75
query35	4.84	4.88	4.85
query36	0.66	0.50	0.49
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.14	0.14
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 104 s
Total hot run time: 29.83 s

swjtu-zhanglei · 2025-07-01T01:49:01Z

run buildall

doris-robot · 2025-07-01T02:12:24Z

TPC-H: Total hot run time: 33629 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fe913406aeac184876f2684d3f5e8c5dd53b1365, data reload: false
------ Round 1 ----------------------------------
q1	17672	5233	5058	5058
q2	1953	286	193	193
q3	10474	1272	724	724
q4	10309	1024	533	533
q5	8640	2387	2276	2276
q6	185	156	125	125
q7	889	742	618	618
q8	9312	1282	1082	1082
q9	6731	5081	5046	5046
q10	6867	2364	2010	2010
q11	467	292	272	272
q12	336	350	207	207
q13	17751	3628	3071	3071
q14	241	226	221	221
q15	553	467	480	467
q16	417	420	360	360
q17	576	850	342	342
q18	7560	7158	7032	7032
q19	1241	958	522	522
q20	321	330	216	216
q21	3785	2522	2299	2299
q22	1060	1018	955	955
Total cold run time: 107340 ms
Total hot run time: 33629 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5098	5068	5249	5068
q2	233	321	214	214
q3	2158	2664	2324	2324
q4	1357	1769	1367	1367
q5	4187	4455	4366	4366
q6	212	164	122	122
q7	1980	1895	1711	1711
q8	2548	2607	2571	2571
q9	7090	7082	7068	7068
q10	3037	3283	2813	2813
q11	567	524	488	488
q12	723	798	630	630
q13	3497	3794	3256	3256
q14	299	290	262	262
q15	522	479	470	470
q16	424	479	422	422
q17	1163	1520	1311	1311
q18	7312	7231	6919	6919
q19	747	738	809	738
q20	1898	1959	1826	1826
q21	4810	4328	4298	4298
q22	1038	1008	964	964
Total cold run time: 50900 ms
Total hot run time: 49208 ms

doris-robot · 2025-07-01T02:23:59Z

TPC-DS: Total hot run time: 185057 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fe913406aeac184876f2684d3f5e8c5dd53b1365, data reload: false
query1	1012	389	387	387
query2	6540	1742	1740	1740
query3	6740	209	210	209
query4	26703	23615	23357	23357
query5	4373	590	442	442
query6	297	215	212	212
query7	4630	497	285	285
query8	260	214	209	209
query9	8644	2669	2670	2669
query10	488	349	267	267
query11	15887	15067	15026	15026
query12	162	107	104	104
query13	1654	531	408	408
query14	9529	5645	5631	5631
query15	204	198	168	168
query16	7630	635	475	475
query17	1204	730	591	591
query18	2031	412	312	312
query19	199	191	159	159
query20	122	122	111	111
query21	218	136	117	117
query22	4126	4060	3944	3944
query23	34157	33089	33114	33089
query24	8438	2353	2394	2353
query25	510	458	393	393
query26	1221	273	151	151
query27	2748	510	347	347
query28	4275	2124	2108	2108
query29	729	542	451	451
query30	283	213	192	192
query31	916	841	762	762
query32	73	63	62	62
query33	563	351	310	310
query34	788	831	529	529
query35	768	786	715	715
query36	946	960	890	890
query37	111	103	80	80
query38	4144	4173	4073	4073
query39	1458	1396	1429	1396
query40	204	117	101	101
query41	55	52	50	50
query42	121	112	108	108
query43	493	500	492	492
query44	1301	834	801	801
query45	176	165	165	165
query46	830	1021	631	631
query47	1770	1793	1707	1707
query48	379	421	312	312
query49	739	500	401	401
query50	627	683	412	412
query51	4130	4149	4103	4103
query52	112	103	100	100
query53	221	247	186	186
query54	568	590	493	493
query55	81	79	80	79
query56	315	295	285	285
query57	1174	1206	1125	1125
query58	267	245	252	245
query59	2603	2723	2509	2509
query60	322	329	299	299
query61	129	122	121	121
query62	808	717	635	635
query63	213	181	181	181
query64	4280	1017	662	662
query65	4268	4172	4167	4167
query66	1055	397	310	310
query67	15971	15470	15361	15361
query68	8067	889	535	535
query69	461	306	266	266
query70	1196	1069	1121	1069
query71	445	320	287	287
query72	5572	4673	4773	4673
query73	733	593	431	431
query74	9361	9307	8778	8778
query75	3729	3186	2699	2699
query76	3630	1135	709	709
query77	787	376	357	357
query78	10101	10061	9348	9348
query79	2748	816	586	586
query80	660	498	426	426
query81	469	251	225	225
query82	457	121	93	93
query83	284	250	235	235
query84	293	101	78	78
query85	779	349	317	317
query86	339	308	306	306
query87	4456	4370	4340	4340
query88	3254	2261	2278	2261
query89	406	310	290	290
query90	1975	211	210	210
query91	135	139	110	110
query92	68	57	61	57
query93	1756	973	586	586
query94	669	400	309	309
query95	382	296	283	283
query96	493	572	276	276
query97	2698	2844	2643	2643
query98	245	206	203	203
query99	1451	1404	1306	1306
Total cold run time: 276092 ms
Total hot run time: 185057 ms

doris-robot · 2025-07-01T02:29:14Z

ClickBench: Total hot run time: 29.35 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fe913406aeac184876f2684d3f5e8c5dd53b1365, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.05	0.04
query3	0.24	0.07	0.07
query4	1.61	0.10	0.10
query5	0.45	0.40	0.44
query6	1.17	0.66	0.66
query7	0.03	0.02	0.02
query8	0.05	0.03	0.03
query9	0.58	0.50	0.52
query10	0.57	0.60	0.55
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.62	0.61
query14	0.78	0.80	0.80
query15	0.90	0.87	0.86
query16	0.39	0.38	0.39
query17	1.05	1.04	1.07
query18	0.23	0.21	0.21
query19	1.98	1.90	1.84
query20	0.01	0.01	0.02
query21	15.39	0.90	0.54
query22	0.75	1.31	0.76
query23	14.73	1.37	0.62
query24	7.75	0.72	0.54
query25	0.51	0.24	0.08
query26	0.64	0.17	0.15
query27	0.07	0.05	0.05
query28	9.06	0.86	0.45
query29	12.54	3.97	3.34
query30	0.26	0.09	0.06
query31	2.84	0.59	0.38
query32	3.23	0.57	0.46
query33	3.06	3.10	3.10
query34	16.04	5.40	4.79
query35	4.83	4.83	4.83
query36	0.69	0.50	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.15	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.04
Total cold run time: 103.98 s
Total hot run time: 29.35 s

* apache#51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start

swjtu-zhanglei · 2025-07-01T03:05:56Z

run buildall

dataroaring

LGTM

github-actions · 2025-07-01T04:11:14Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-07-01T04:11:17Z

PR approved by anyone and no changes requested.

doris-robot · 2025-07-01T04:15:14Z

TPC-H: Total hot run time: 34647 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 637b2ae92b829ba87136f306f2cec2e75ad9a992, data reload: false
------ Round 1 ----------------------------------
q1	17611	5280	5144	5144
q2	1944	293	187	187
q3	10434	1368	736	736
q4	10297	1039	563	563
q5	8470	2315	2429	2315
q6	187	159	131	131
q7	913	755	622	622
q8	9335	1324	1186	1186
q9	7143	5219	5182	5182
q10	6910	2414	1987	1987
q11	494	293	297	293
q12	364	358	241	241
q13	17811	3679	3176	3176
q14	236	243	230	230
q15	551	510	486	486
q16	442	440	407	407
q17	647	891	394	394
q18	7674	7287	7089	7089
q19	1227	963	583	583
q20	359	364	233	233
q21	4233	3336	2474	2474
q22	1114	1019	988	988
Total cold run time: 108396 ms
Total hot run time: 34647 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5209	5171	5175	5171
q2	259	322	229	229
q3	2179	2689	2287	2287
q4	1438	1769	1362	1362
q5	4522	4580	4576	4576
q6	221	172	125	125
q7	2020	1948	1856	1856
q8	2711	2623	2574	2574
q9	7359	7309	7416	7309
q10	3143	3415	2891	2891
q11	587	521	494	494
q12	714	775	598	598
q13	3356	3726	3127	3127
q14	263	298	274	274
q15	515	473	476	473
q16	428	480	424	424
q17	1159	1535	1329	1329
q18	7412	7403	7062	7062
q19	847	855	879	855
q20	2015	2023	1874	1874
q21	4931	4402	4404	4402
q22	1100	1063	1005	1005
Total cold run time: 52388 ms
Total hot run time: 50297 ms

doris-robot · 2025-07-01T04:27:01Z

TPC-DS: Total hot run time: 189799 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 637b2ae92b829ba87136f306f2cec2e75ad9a992, data reload: false
query1	996	398	390	390
query2	6551	1873	1865	1865
query3	6760	229	218	218
query4	26798	23553	23321	23321
query5	4359	620	492	492
query6	314	227	218	218
query7	4632	520	309	309
query8	279	252	225	225
query9	8635	2903	2928	2903
query10	471	349	301	301
query11	16000	15185	15028	15028
query12	186	114	110	110
query13	1652	606	447	447
query14	9976	5912	5940	5912
query15	205	205	182	182
query16	7660	648	470	470
query17	1204	762	618	618
query18	2047	425	321	321
query19	216	213	196	196
query20	125	126	121	121
query21	221	132	109	109
query22	4239	4355	4258	4258
query23	34490	33616	33504	33504
query24	8385	2459	2431	2431
query25	551	486	417	417
query26	1061	289	156	156
query27	2676	547	365	365
query28	4262	2361	2329	2329
query29	674	577	470	470
query30	290	228	198	198
query31	955	842	768	768
query32	74	59	62	59
query33	559	377	348	348
query34	840	901	564	564
query35	818	823	752	752
query36	1006	1025	941	941
query37	124	103	78	78
query38	4237	4293	4156	4156
query39	1506	1632	1426	1426
query40	218	119	108	108
query41	56	61	51	51
query42	135	125	115	115
query43	535	556	506	506
query44	1444	895	888	888
query45	174	172	164	164
query46	906	1056	685	685
query47	1764	1823	1757	1757
query48	414	449	324	324
query49	717	512	405	405
query50	691	724	451	451
query51	4214	4290	4199	4199
query52	119	118	108	108
query53	251	269	214	214
query54	623	611	546	546
query55	88	88	89	88
query56	317	325	314	314
query57	1195	1192	1132	1132
query58	276	276	276	276
query59	2844	2856	2793	2793
query60	354	333	314	314
query61	129	146	130	130
query62	789	727	657	657
query63	241	200	203	200
query64	3689	1063	727	727
query65	4338	4237	4255	4237
query66	934	419	318	318
query67	16060	15880	15815	15815
query68	8218	971	561	561
query69	484	326	280	280
query70	1275	1205	1198	1198
query71	486	333	320	320
query72	5718	4900	4844	4844
query73	753	700	378	378
query74	9287	9129	8729	8729
query75	3923	3258	2807	2807
query76	3611	1186	753	753
query77	793	413	306	306
query78	10239	10362	9425	9425
query79	2158	914	636	636
query80	615	543	468	468
query81	497	263	270	263
query82	458	134	98	98
query83	279	266	253	253
query84	254	122	90	90
query85	789	385	329	329
query86	394	327	298	298
query87	4455	4566	4398	4398
query88	3704	2452	2412	2412
query89	391	330	300	300
query90	1936	225	221	221
query91	145	149	123	123
query92	73	61	60	60
query93	1591	1004	632	632
query94	679	407	307	307
query95	393	312	307	307
query96	552	591	299	299
query97	2732	2796	2703	2703
query98	242	215	209	209
query99	1688	1436	1294	1294
Total cold run time: 278361 ms
Total hot run time: 189799 ms

doris-robot · 2025-07-01T04:32:19Z

ClickBench: Total hot run time: 30.43 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 637b2ae92b829ba87136f306f2cec2e75ad9a992, data reload: false
query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.25	0.08	0.08
query4	1.61	0.11	0.11
query5	0.45	0.46	0.44
query6	1.22	0.67	0.66
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.53	0.54
query10	0.59	0.59	0.59
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.64	0.62	0.63
query14	0.81	0.83	0.83
query15	0.92	0.91	0.87
query16	0.41	0.40	0.42
query17	1.09	1.10	1.12
query18	0.25	0.23	0.22
query19	2.03	1.94	1.97
query20	0.02	0.01	0.01
query21	15.38	0.93	0.56
query22	0.76	1.20	0.78
query23	14.87	1.41	0.62
query24	6.76	1.44	0.88
query25	0.49	0.25	0.13
query26	0.64	0.18	0.15
query27	0.08	0.06	0.06
query28	8.92	0.95	0.47
query29	12.53	4.08	3.47
query30	0.26	0.09	0.06
query31	2.83	0.62	0.39
query32	3.25	0.57	0.49
query33	3.13	3.18	3.14
query34	16.05	5.43	4.77
query35	4.88	4.91	4.85
query36	0.70	0.51	0.49
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.15	0.14
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.05	0.04	0.03
Total cold run time: 103.47 s
Total hot run time: 30.43 s

hello-stephen · 2025-07-01T05:55:36Z

BE UT Coverage Report

Increment line coverage 0.00% (0/14) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.07% (15347/26892)
Line Coverage	46.14% (139422/302188)
Region Coverage	45.44% (70659/155483)
Branch Coverage	40.23% (37326/92780)

* #51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start

Cherry-picked from #52541 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

…apache#52602) Cherry-picked from apache#52541 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

* apache#51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start

…pache#52603) Cherry-picked from apache#52541 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

swjtu-zhanglei requested review from dataroaring and gavinchou as code owners June 30, 2025 09:57

[fix](be) Fix check_storage_vault deadlock
637b2ae
* apache#51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start

swjtu-zhanglei force-pushed the master-fix15 branch from fe91340 to 637b2aeCompare July 1, 2025 03:05

dataroaring approved these changes Jul 1, 2025
View reviewed changes

dataroaring added dev/3.0.x dev/3.1.x labels Jul 1, 2025

github-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 1, 2025

gavinchou approved these changes Jul 1, 2025
View reviewed changes

dataroaring merged commit db806d2 into apache:masterJul 1, 2025

github-actionsBot mentioned this pull request Jul 1, 2025
branch-3.0: [fix](be) Fix check_storage_vault deadlock #52541 #52602
Merged

github-actionsBot mentioned this pull request Jul 1, 2025
branch-3.1: [fix](be) Fix check_storage_vault deadlock #52541 #52603
Merged

dataroaring pushed a commit that referenced this pull request Jul 2, 2025
branch-3.0: [fix](be) Fixcheck_storage_vaultdeadlock#52541(#52602)
79be96b
Cherry-picked from #52541 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

dataroaring added dev/3.0.7-merged and removed dev/3.0.x labels Jul 2, 2025

morrySnow pushed a commit that referenced this pull request Jul 3, 2025
branch-3.1: [fix](be) Fix check_storage_vault deadlock#52541(#52603)
01682e2
Cherry-picked from #52541 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Jul 3, 2025

koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
branch-3.0: [fix](be) Fixcheck_storage_vaultdeadlockapache#52541(…
e8a8755
…apache#52602) Cherry-picked from apache#52541 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

etah000 pushed a commit to etah000/doris that referenced this pull request Jul 7, 2025
branch-3.1: [fix](be) Fix check_storage_vault deadlockapache#52541(a…
848a684
…pache#52603) Cherry-picked from apache#52541 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

gavinchou mentioned this pull request Aug 15, 2025
Release Note 3.0.7 #54868
Closed

Uh oh!

Conversation

swjtu-zhanglei commented Jun 30, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

swjtu-zhanglei commented Jun 30, 2025

Uh oh!

Thearas commented Jun 30, 2025

Uh oh!

swjtu-zhanglei commented Jun 30, 2025

Uh oh!

doris-robot commented Jun 30, 2025

BE UT Coverage Report

Uh oh!

doris-robot commented Jun 30, 2025

Uh oh!

doris-robot commented Jun 30, 2025

Uh oh!

doris-robot commented Jun 30, 2025

Uh oh!

swjtu-zhanglei commented Jul 1, 2025

Uh oh!

doris-robot commented Jul 1, 2025

Uh oh!

doris-robot commented Jul 1, 2025

Uh oh!

doris-robot commented Jul 1, 2025

Uh oh!

swjtu-zhanglei commented Jul 1, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jul 1, 2025

Uh oh!

github-actionsBot commented Jul 1, 2025

Uh oh!

doris-robot commented Jul 1, 2025

Uh oh!

doris-robot commented Jul 1, 2025

Uh oh!

doris-robot commented Jul 1, 2025

Uh oh!

hello-stephen commented Jul 1, 2025

BE UT Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

swjtu-zhanglei commented Jun 30, 2025•
edited
Loading