Uh oh!
There was an error while loading. Please reload this page.
[Fix](mow) Fix DeleteBitmap's assignment operator and constructor - #52582
Merged
Conversation
Thearas
commented
Jul 1, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bobhan1
commented
Jul 1, 2025
ContributorAuthor
run buildall |
bobhan1force-pushed
the
fix-delete-bitmap
branch
3 times, most recently
from
July 1, 2025 07:42
ad7580a to
44b81caCompareDeleteBitmap's assignment operatorDeleteBitmap's assignment operator and constructordoris-robot
commented
Jul 1, 2025
TPC-H: Total hot run time: 33290 ms |
bobhan1force-pushed
the
fix-delete-bitmap
branch
2 times, most recently
from
July 1, 2025 08:01
98cb439 to
7e54575Comparedoris-robot
commented
Jul 1, 2025
TPC-DS: Total hot run time: 185012 ms |
doris-robot
commented
Jul 1, 2025
ClickBench: Total hot run time: 29.6 s |
bobhan1
commented
Jul 1, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Jul 1, 2025
TPC-H: Total hot run time: 35579 ms |
doris-robot
commented
Jul 1, 2025
TPC-DS: Total hot run time: 189317 ms |
doris-robot
commented
Jul 1, 2025
ClickBench: Total hot run time: 30.05 s |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
doris-robot
commented
Jul 1, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
bobhan1
commented
Jul 2, 2025
ContributorAuthor
run cloud_p0 |
doris-robot
commented
Jul 7, 2025
TPC-DS: Total hot run time: 185161 ms |
doris-robot
commented
Jul 7, 2025
ClickBench: Total hot run time: 29.67 s |
doris-robot
commented
Jul 7, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
bobhan1
commented
Jul 8, 2025
ContributorAuthor
run cloud_p0 |
bobhan1
commented
Jul 8, 2025
ContributorAuthor
run external |
bobhan1
commented
Jul 8, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Jul 8, 2025
TPC-H: Total hot run time: 33149 ms |
doris-robot
commented
Jul 8, 2025
TPC-DS: Total hot run time: 185763 ms |
doris-robot
commented
Jul 8, 2025
ClickBench: Total hot run time: 29.31 s |
doris-robot
commented
Jul 8, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actionsBot
pushed a commit
that referenced
this pull request
Jul 9, 2025
…52582) ### What problem does this PR solve? Currently, `DeleteBitmap`'s wrong move assignment operator can cause correctness problem on mow table if SC's alter process produce delete bitmaps when calculating delete bitmaps for incremental rowsets after the modification in `CloudSchemaChangeJob::_process_delete_bitmap` of #52440 because `origin_dbm` and `delete_bitmap` refer to the same `DeleteBitmap` object. 
github-actionsBot
pushed a commit
that referenced
this pull request
Jul 9, 2025
…52582) ### What problem does this PR solve? Currently, `DeleteBitmap`'s wrong move assignment operator can cause correctness problem on mow table if SC's alter process produce delete bitmaps when calculating delete bitmaps for incremental rowsets after the modification in `CloudSchemaChangeJob::_process_delete_bitmap` of #52440 because `origin_dbm` and `delete_bitmap` refer to the same `DeleteBitmap` object. 
Hastyshell pushed a commit
to Hastyshell/doris
that referenced
this pull request
Jul 21, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently,

DeleteBitmap's wrong move assignment operator can cause correctness problem on mow table if SC's alter process produce delete bitmaps when calculating delete bitmaps for incremental rowsets after the modification inCloudSchemaChangeJob::_process_delete_bitmapof #52440 becauseorigin_dbmanddelete_bitmaprefer to the sameDeleteBitmapobject.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)