Uh oh!
There was an error while loading. Please reload this page.
[fix](nereids) Fix profile lock table,translate summary time err and add ut test - #52601
Conversation
hello-stephen
commented
Jul 1, 2025
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
seawinde
commented
Jul 1, 2025
run buildall |
| if (statementContext.getConnectContext().getExecutor() != null) { | ||
| statementContext.getConnectContext().getExecutor().getSummaryProfile().setNereidsDistributeTime(); | ||
| statementContext.getConnectContext().getExecutor().getSummaryProfile() | ||
| .setNereidsDistributeTime(TimeUtils.getStartTimeMs()); |
There was a problem hiding this comment.
why move TimeUtils.getStartTimeMs() in parameter?
There was a problem hiding this comment.
TimeUtils.getStartTimeMs() is passed in as a parameter to facilitate better unit testing, as the unit tests need to control and assert based on a fixed time.
seawinde
commented
Jul 1, 2025
run buildall |
hello-stephen
commented
Jul 1, 2025
FE UT Coverage ReportIncrement line coverage |
doris-robot
commented
Jul 1, 2025
TPC-H: Total hot run time: 33531 ms |
doris-robot
commented
Jul 1, 2025
TPC-DS: Total hot run time: 184460 ms |
doris-robot
commented
Jul 1, 2025
ClickBench: Total hot run time: 29.19 s |
26c9d03 to
382e09aCompareseawinde
commented
Jul 23, 2025
run buildall |
doris-robot
commented
Jul 23, 2025
TPC-H: Total hot run time: 33813 ms |
doris-robot
commented
Jul 23, 2025
TPC-DS: Total hot run time: 186834 ms |
doris-robot
commented
Jul 23, 2025
ClickBench: Total hot run time: 32.73 s |
0974e81 to
3cd899dCompareseawinde
commented
Aug 27, 2025
run buildall |
1 similar comment
seawinde
commented
Aug 27, 2025
run buildall |
doris-robot
commented
Aug 27, 2025
TPC-H: Total hot run time: 34288 ms |
doris-robot
commented
Aug 27, 2025
TPC-DS: Total hot run time: 186894 ms |
doris-robot
commented
Aug 27, 2025
ClickBench: Total hot run time: 32.62 s |
hello-stephen
commented
Aug 27, 2025
FE UT Coverage ReportIncrement line coverage |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
seawinde
commented
Aug 27, 2025
run buildall |
hello-stephen
commented
Aug 28, 2025
FE UT Coverage ReportIncrement line coverage |
3010c9a to
779bac0Compareseawinde
commented
Sep 10, 2025
run buildall |
doris-robot
commented
Sep 10, 2025
TPC-H: Total hot run time: 34848 ms |
doris-robot
commented
Sep 10, 2025
TPC-DS: Total hot run time: 189687 ms |
doris-robot
commented
Sep 10, 2025
ClickBench: Total hot run time: 29.78 s |
hello-stephen
commented
Sep 10, 2025
FE Regression Coverage ReportIncrement line coverage |
hello-stephen
commented
Sep 11, 2025
FE Regression Coverage ReportIncrement line coverage |
Uh oh!
There was an error while loading. Please reload this page.
…add ut test (apache#52601) 1. Nereids Translate Time should be after method `PhysicalPlanTranslator#translatePlan` 2. fix 2.1 and 3.0 `Parse SQL Time` and `Nereids Lock Table Time` has the same parseSqlStartTime. Related PR: apache#39670apache#45679
What problem does this PR solve?
PhysicalPlanTranslator#translatePlanParse SQL TimeandNereids Lock Table Timehas the same parseSqlStartTime.Issue Number: close #xxx
Related PR: #39670#45679
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)