Skip to content

[opt](recycler) Add concurrency recycle for tmp rowset - #52677

Merged
gavinchou merged 4 commits into
apache:masterfrom
wyxxxcat:conc_recycle_tmp_rs
Sep 4, 2025
Merged

[opt](recycler) Add concurrency recycle for tmp rowset#52677
gavinchou merged 4 commits into
apache:masterfrom
wyxxxcat:conc_recycle_tmp_rs

Conversation

@wyxxxcat

@wyxxxcatwyxxxcat commented Jul 2, 2025

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

after pr

ConcurrencyTrial 1Trial 2Trial 3
1389733673434172
5207142013622548
10147801502215851

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
wyxxxcatforce-pushed the conc_recycle_tmp_rs branch 2 times, most recently from 6e745cb to 66e512bCompareJuly 3, 2025 10:03
@wyxxxcat

wyxxxcat commented Jul 3, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@wyxxxcat
wyxxxcatforce-pushed the conc_recycle_tmp_rs branch 2 times, most recently from a748742 to 125c291CompareJuly 4, 2025 06:52
@wyxxxcat

wyxxxcat commented Jul 4, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run cloudut

@wyxxxcat
wyxxxcatforce-pushed the conc_recycle_tmp_rs branch 2 times, most recently from f1f3635 to c5b2f1bCompareJuly 4, 2025 07:10
@wyxxxcat

wyxxxcat commented Jul 4, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run cloudut

@doris-robot

doris-robot commented Jul 4, 2025

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 100.00% (32/32) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage82.93% (1219/1470)
Line Coverage67.58% (21088/31203)
Region Coverage67.27% (10486/15589)
Branch Coverage56.60% (5490/9700)

@wyxxxcat
wyxxxcatforce-pushed the conc_recycle_tmp_rs branch from c5b2f1b to 0dea5b6CompareJuly 4, 2025 07:36
@wyxxxcat

wyxxxcat commented Jul 4, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run cloudut

@wyxxxcat
wyxxxcatforce-pushed the conc_recycle_tmp_rs branch from 0dea5b6 to dc31f19CompareJuly 4, 2025 08:10
@wyxxxcat

wyxxxcat commented Jul 4, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run cloudut

@wyxxxcat
wyxxxcatforce-pushed the conc_recycle_tmp_rs branch 2 times, most recently from 6f469ff to 79f4f62CompareJuly 4, 2025 08:42
@wyxxxcat

wyxxxcat commented Jul 4, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@doris-robot

doris-robot commented Jul 4, 2025

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 100.00% (29/29) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage82.93% (1219/1470)
Line Coverage67.51% (21062/31200)
Region Coverage67.26% (10485/15589)
Branch Coverage56.64% (5494/9700)

gavinchou
gavinchou reviewed Jul 10, 2025
View reviewed changes
Comment threadcloud/src/recycler/recycler.cpp Outdated
gavinchou
gavinchou reviewed Jul 11, 2025
View reviewed changes
Comment threadcloud/src/recycler/recycler.cpp Outdated
@wyxxxcat
wyxxxcatforce-pushed the conc_recycle_tmp_rs branch from 79f4f62 to f8eab8bCompareJuly 20, 2025 15:06
@wyxxxcat

wyxxxcat commented Aug 12, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@doris-robot

doris-robot commented Aug 12, 2025

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 100.00% (28/28) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage83.61% (1423/1702)
Line Coverage66.84% (24236/36261)
Region Coverage67.86% (12066/17780)
Branch Coverage57.47% (6337/11026)

gavinchou
gavinchou previously approved these changes Aug 13, 2025
View reviewed changes
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 13, 2025
@github-actions

github-actionsBot commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@wyxxxcat

wyxxxcat commented Sep 1, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@wyxxxcat

wyxxxcat commented Sep 1, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

hello-stephen commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 100.00% (37/37) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage84.49% (1465/1734)
Line Coverage67.69% (26155/38640)
Region Coverage68.62% (12985/18922)
Branch Coverage58.58% (6945/11856)

@gavinchou
gavinchou merged commit 0af28af into apache:masterSep 4, 2025
26 checks passed
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
@wyxxxcat@wenzhenghu
[opt](recycler) Add concurrency recycle for tmp rowset (apache#52677)
a0d30a9
after pr
| Concurrency | Trial 1 | Trial 2 | Trial 3 |
|-------------|---------|---------|---------|
| 1 | 38973 | 36734 | 34172 |
| 5 | 20714 | 20136 | 22548 |
| 10 | 14780 | 15022 | 15851 |
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Sep 28, 2025
@wyxxxcat
[opt](recycler) Add concurrency recycle for tmp rowset (apache#52677)
b044bde
after pr
| Concurrency | Trial 1 | Trial 2 | Trial 3 |
|-------------|---------|---------|---------|
| 1 | 38973 | 36734 | 34172 |
| 5 | 20714 | 20136 | 22548 |
| 10 | 14780 | 15022 | 15851 |
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Sep 28, 2025
@wyxxxcat
[opt](recycler) Add concurrency recycle for tmp rowset (apache#52677)
610d0ea
after pr
| Concurrency | Trial 1 | Trial 2 | Trial 3 |
|-------------|---------|---------|---------|
| 1 | 38973 | 36734 | 34172 |
| 5 | 20714 | 20136 | 22548 |
| 10 | 14780 | 15022 | 15851 |
@wyxxxcatwyxxxcat mentioned this pull request Sep 28, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 29, 2025
@wyxxxcat
branch-3.1: [opt](recycler) Add concurrency recycle for tmp rowset#5…
8726a0e
…2677 (#56573)
pick: #52677
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@Yukang-LianYukang-LianYukang-Lian approved these changes
@dataroaringdataroaringAwaiting requested review from dataroaring
@w41terw41terAwaiting requested review from w41ter

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.clouddev/3.1.2-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wyxxxcat@Thearas@doris-robot@hello-stephen@gavinchou@Yukang-Lian@dataroaring@morrySnow