Uh oh!
There was an error while loading. Please reload this page.
[Improvement](cloud) Hold tablets in another RPC thread - #52879
Conversation
Gabriel39
commented
Jul 7, 2025
run buildall |
Thearas
commented
Jul 7, 2025
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Gabriel39
commented
Jul 7, 2025
run buildall |
doris-robot
commented
Jul 7, 2025
TPC-H: Total hot run time: 33223 ms |
doris-robot
commented
Jul 7, 2025
TPC-DS: Total hot run time: 185577 ms |
doris-robot
commented
Jul 7, 2025
ClickBench: Total hot run time: 29.84 s |
doris-robot
commented
Jul 7, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Gabriel39
commented
Jul 8, 2025
run buildall |
doris-robot
commented
Jul 8, 2025
TPC-H: Total hot run time: 33231 ms |
doris-robot
commented
Jul 8, 2025
TPC-DS: Total hot run time: 185766 ms |
doris-robot
commented
Jul 8, 2025
ClickBench: Total hot run time: 29.72 s |
Gabriel39
commented
Jul 8, 2025
run buildall |
doris-robot
commented
Jul 8, 2025
TPC-H: Total hot run time: 33335 ms |
doris-robot
commented
Jul 8, 2025
TPC-DS: Total hot run time: 184087 ms |
doris-robot
commented
Jul 8, 2025
ClickBench: Total hot run time: 29.78 s |
Gabriel39
commented
Jul 8, 2025
run buildall |
doris-robot
commented
Jul 8, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Gabriel39
commented
Jul 8, 2025
run buildall |
doris-robot
commented
Jul 8, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Gabriel39
commented
Jul 9, 2025
run buildall |
Gabriel39
commented
Jul 9, 2025
run buildall |
doris-robot
commented
Jul 9, 2025
TPC-H: Total hot run time: 33354 ms |
doris-robot
commented
Jul 10, 2025
ClickBench: Total hot run time: 29.88 s |
doris-robot
commented
Jul 10, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
| Status OlapScanLocalState::init(RuntimeState* state, LocalStateInfo& info) { | ||
| RETURN_IF_ERROR(Base::init(state, info)); | ||
| RETURN_IF_ERROR(_sync_cloud_tablets(state)); |
There was a problem hiding this comment.
这个_sync_cloud_tablets 实际是一个执行逻辑,但是我们把他放到了一个初始化的逻辑里,可能会有一些不可预期的问题
| _tablets.resize(_scan_ranges.size()); | ||
| _tasks.reserve(_scan_ranges.size()); | ||
| _sync_statistics.resize(_scan_ranges.size()); | ||
| SCOPED_RAW_TIMER(&_duration_ns); |
There was a problem hiding this comment.
这个_duration_ns 似乎没用,因为底下这个调用是异步的。
可能我们需要跟踪一下那个dependency的时间,比如他set ready的时候,记录一个时间,这样才是准确的。
Gabriel39
commented
Jul 16, 2025
run buildall |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
doris-robot
commented
Jul 16, 2025
TPC-H: Total hot run time: 34017 ms |
doris-robot
commented
Jul 16, 2025
TPC-DS: Total hot run time: 186876 ms |
doris-robot
commented
Jul 16, 2025
ClickBench: Total hot run time: 31.95 s |
doris-robot
commented
Jul 16, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jul 16, 2025
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
hello-stephen
commented
Jul 17, 2025
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
With cloud mode on, remote tablets will be loaded into local storage before execution. This will block execution thread now. If it's too slow, pipeline execution thread may hang. This PR makes remote tablets loading asynchronously.
With cloud mode on, remote tablets will be loaded into local storage before execution. This will block execution thread now. If it's too slow, pipeline execution thread may hang. This PR makes remote tablets loading asynchronously.
What problem does this PR solve?
With cloud mode on, remote tablets will be loaded into local storage before execution. This will block execution thread now. If it's too slow, pipeline execution thread may hang.
This PR makes remote tablets loading asynchronously.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)