[Bug](function) fix bitmap_from_base64 function cause heap-buffer-overflow error by zhangstar333 · Pull Request #53018 · apache/doris

zhangstar333 · 2025-07-09T13:07:24Z

What problem does this PR solve?

Problem Summary:

==2403213==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x506001097220 at pc 0x55837edd7fe9 bp 0x7f7efe2dc830 sp 0x7f7efe2dbff8
READ of size 63 at 0x506001097220 thread T1262 (brpc_light)
#0 0x55837edd7fe8 in strlen (/mnt/disk8/zhangsida/doris/output/be/lib/doris_be+0x2c8d7fe8) (BuildId: 5acbe48773972a88)
#1 0x5583bd3ff969 in fmt::v7::detail::buffer_appender<char> fmt::v7::detail::write<char, fmt::v7::detail::buffer_appender<char>>(fmt::v7::detail::buffer_appender<char>, char const*) (/mnt/disk8/zhangsida/doris/output/be/lib/doris_be+0x6aeff969) (BuildId: 5acbe48773972a88)
#2 0x5583bd41640e in char const* fmt::v7::detail::parse_replacement_field<char, fmt::v7::detail::format_handler<fmt::v7::detail::buffer_appender<char>, char, fmt::v7::basic_format_context<fmt::v7::detail::buffer_appender<char>, char>>&>(char const*, char const*, fmt::v7::detail::format_handler<fmt::v7::detail::buffer_appender<char>, char, fmt::v7::basic_format_context<fmt::v7::detail::buffer_appender<char>, char>>&) (/mnt/disk8/zhangsida/doris/output/be/lib/doris_be+0x6af1640e) (BuildId: 5acbe48773972a88)
#3 0x5583bd416c7f in void fmt::v7::detail::vformat_to<char>(fmt::v7::detail::buffer<char>&, fmt::v7::basic_string_view<char>, fmt::v7::basic_format_args<fmt::v7::basic_format_context<fmt::v7::detail::buffer_appender<fmt::v7::type_identity<char>::type>, fmt::v7::type_identity<char>::type>>, fmt::v7::detail::locale_ref) (/mnt/disk8/zhangsida/doris/output/be/lib/doris_be+0x6af16c7f) (BuildId: 5acbe48773972a88)
#4 0x5583bd3f74aa in fmt::v7::detail::vformat[abi:cxx11](fmt::v7::basic_string_view<char>, fmt::v7::format_args) (/mnt/disk8/zhangsida/doris/output/be/lib/doris_be+0x6aef74aa) (BuildId: 5acbe48773972a88)
#5 0x5583a6b4d3bb in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> fmt::v7::format<char [45], char const*&, char>(char const (&) [45], char const*&) /mnt/disk8/zhangsida/doris/thirdparty/installed/include/fmt/core.h:2076:10
#6 0x5583a6b4d3bb in doris::vectorized::BitmapFromBase64::vector(doris::vectorized::PODArray<unsigned char, 4096ul, doris::Allocator<false, false, false, doris::NoTrackingDefaultMemoryAllocator>, 16ul, 15ul> const&, doris::vectorized::PODArray<unsigned int, 4096ul, doris::Allocator<false, false, false, doris::NoTrackingDefaultMemoryAllocator>, 16ul, 15ul> const&, std::vector<doris::BitmapValue, std::allocator<doris::BitmapValue>>&, doris::vectorized::PODArray<unsigned char, 4096ul, doris::Allocator<false, false, false, doris::NoTrackingDefaultMemoryAllocator>, 16ul, 15ul>&, unsigned long) /mnt/disk8/zhangsida/doris/be/src/vec/functions/function_bitmap.cpp:310:29
#7 0x5583a6b4b93b in doris::vectorized::FunctionBitmapAlwaysNull<doris::vectorized::BitmapFromBase64>::execute_impl(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long) const /mnt/disk8/zhangsida/doris/be/src/vec/functions/function_bitmap.cpp:381:13
#8 0x5583a02062ef in doris::vectorized::DefaultExecutable::execute_impl(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long) const /mnt/disk8/zhangsida/doris/be/src/vec/functions/function.h:459:26
#9 0x5583a49d77e3 in doris::vectorized::PreparedFunctionImpl::_execute_skipped_constant_deal(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long, bool) const /mnt/disk8/zhangsida/doris/be/src/vec/functions/function.cpp
#10 0x5583a49d0bf8 in doris::vectorized::PreparedFunctionImpl::default_implementation_for_constant_arguments(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long, bool, bool*) const /mnt/disk8/zhangsida/doris/be/src/vec/functions/function.cpp:168:5
#11 0x5583a49d3324 in doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long, bool) const /mnt/disk8/zhangsida/doris/be/src/vec/functions/function.cpp:237:5

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-07-09T13:07:30Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

…rflow error

zhangstar333 · 2025-07-09T13:09:47Z

run buildall

doris-robot · 2025-07-09T13:45:23Z

TPC-H: Total hot run time: 33072 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1e1d745084dde80d1797a58ef195e326308cca0b, data reload: false
------ Round 1 ----------------------------------
q1	17591	5127	4984	4984
q2	1909	263	184	184
q3	10378	1271	692	692
q4	10276	1012	528	528
q5	8243	2374	2332	2332
q6	184	160	126	126
q7	886	723	590	590
q8	9297	1258	1007	1007
q9	7055	5088	5070	5070
q10	6876	2355	1960	1960
q11	473	285	284	284
q12	335	338	210	210
q13	17762	3641	3112	3112
q14	219	221	206	206
q15	558	491	472	472
q16	416	422	361	361
q17	580	850	350	350
q18	7436	7193	7200	7193
q19	1256	925	544	544
q20	334	330	223	223
q21	3584	3169	2347	2347
q22	355	316	297	297
Total cold run time: 106003 ms
Total hot run time: 33072 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5055	5046	5072	5046
q2	231	329	218	218
q3	2165	2659	2300	2300
q4	1333	1769	1311	1311
q5	4244	4226	4523	4226
q6	226	177	130	130
q7	2019	1907	1741	1741
q8	2686	2590	2522	2522
q9	7134	7369	7184	7184
q10	3176	3293	2887	2887
q11	563	515	532	515
q12	685	770	871	770
q13	3434	3886	3360	3360
q14	274	303	271	271
q15	534	477	470	470
q16	455	484	458	458
q17	1161	1563	1384	1384
q18	7915	7841	7567	7567
q19	790	848	1078	848
q20	1952	1962	1841	1841
q21	4651	4338	4173	4173
q22	662	588	570	570
Total cold run time: 51345 ms
Total hot run time: 49792 ms

doris-robot · 2025-07-09T13:57:00Z

TPC-DS: Total hot run time: 185291 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1e1d745084dde80d1797a58ef195e326308cca0b, data reload: false
query1	997	366	397	366
query2	6503	1634	1640	1634
query3	6756	212	215	212
query4	26808	24424	23516	23516
query5	4339	606	456	456
query6	309	231	197	197
query7	4618	498	293	293
query8	260	211	205	205
query9	8602	2649	2647	2647
query10	476	335	285	285
query11	15709	15072	14794	14794
query12	174	108	104	104
query13	1652	519	396	396
query14	9641	5791	5795	5791
query15	208	184	173	173
query16	7641	419	256	256
query17	1340	708	546	546
query18	2005	395	288	288
query19	184	178	154	154
query20	114	116	115	115
query21	211	144	101	101
query22	4169	4321	4101	4101
query23	34103	33118	33022	33022
query24	8381	2327	2331	2327
query25	513	463	391	391
query26	1216	266	145	145
query27	2768	504	335	335
query28	4296	2112	2107	2107
query29	724	532	436	436
query30	281	221	190	190
query31	929	804	724	724
query32	73	62	65	62
query33	539	349	276	276
query34	800	825	522	522
query35	593	645	551	551
query36	935	980	901	901
query37	107	104	75	75
query38	4141	4053	4064	4053
query39	1509	1418	1445	1418
query40	226	123	108	108
query41	62	59	56	56
query42	134	110	122	110
query43	490	498	481	481
query44	1315	823	820	820
query45	174	172	167	167
query46	829	1018	627	627
query47	1747	1802	1768	1768
query48	380	427	333	333
query49	761	488	393	393
query50	635	684	464	464
query51	4192	4200	4046	4046
query52	109	105	96	96
query53	214	246	184	184
query54	567	549	503	503
query55	83	81	89	81
query56	302	302	288	288
query57	1172	1179	1141	1141
query58	258	249	246	246
query59	2491	2681	2485	2485
query60	327	319	309	309
query61	123	117	121	117
query62	801	725	644	644
query63	224	181	190	181
query64	4379	1180	804	804
query65	4227	4169	4148	4148
query66	1044	411	307	307
query67	15936	15709	15379	15379
query68	8197	874	525	525
query69	487	375	268	268
query70	1211	1096	1091	1091
query71	462	316	316	316
query72	5621	4732	4689	4689
query73	677	595	345	345
query74	9168	8794	9166	8794
query75	3855	3179	2646	2646
query76	3713	1140	714	714
query77	786	363	291	291
query78	11034	11004	10256	10256
query79	2185	819	601	601
query80	564	567	427	427
query81	480	252	214	214
query82	487	124	97	97
query83	253	247	279	247
query84	243	103	93	93
query85	812	352	301	301
query86	389	303	303	303
query87	4391	4420	4272	4272
query88	3715	2254	2251	2251
query89	383	333	278	278
query90	1919	210	205	205
query91	145	149	116	116
query92	68	60	55	55
query93	1641	928	580	580
query94	681	313	196	196
query95	383	292	278	278
query96	489	565	276	276
query97	2748	2759	2655	2655
query98	223	214	209	209
query99	1336	1413	1251	1251
Total cold run time: 276572 ms
Total hot run time: 185291 ms

doris-robot · 2025-07-09T14:02:16Z

ClickBench: Total hot run time: 29.71 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1e1d745084dde80d1797a58ef195e326308cca0b, data reload: false
query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.25	0.08	0.08
query4	1.62	0.11	0.10
query5	0.43	0.42	0.41
query6	1.18	0.67	0.66
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.60	0.51	0.52
query10	0.56	0.56	0.57
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.61	0.60
query14	0.80	0.82	0.83
query15	0.91	0.88	0.86
query16	0.39	0.40	0.39
query17	1.06	1.05	1.06
query18	0.22	0.21	0.20
query19	1.91	1.88	1.80
query20	0.01	0.02	0.02
query21	15.43	0.89	0.53
query22	0.76	1.17	0.77
query23	14.82	1.37	0.60
query24	7.37	1.29	0.97
query25	0.50	0.25	0.07
query26	0.57	0.16	0.13
query27	0.07	0.06	0.05
query28	9.39	0.93	0.46
query29	12.53	3.88	3.27
query30	0.25	0.09	0.07
query31	2.84	0.60	0.39
query32	3.22	0.56	0.47
query33	3.15	3.09	3.08
query34	15.99	5.36	4.78
query35	4.82	4.81	4.85
query36	0.70	0.51	0.50
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 104 s
Total hot run time: 29.71 s

hello-stephen · 2025-07-09T14:58:37Z

BE UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.01% (15504/27194)
Line Coverage	45.87% (138292/301502)
Region Coverage	35.33% (103426/292776)
Branch Coverage	37.78% (45501/120444)

zhangstar333 · 2025-07-10T02:07:02Z

run buildall

github-actions · 2025-07-10T02:09:51Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-07-10T02:09:54Z

PR approved by anyone and no changes requested.

doris-robot · 2025-07-10T03:04:04Z

TPC-H: Total hot run time: 33573 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5db42d63ca64a91dcb11a13016b629aeac2cc6d9, data reload: false
------ Round 1 ----------------------------------
q1	17572	5202	5112	5112
q2	1931	270	188	188
q3	10514	1281	724	724
q4	10267	996	523	523
q5	7773	2313	2379	2313
q6	179	160	126	126
q7	907	772	606	606
q8	9302	1315	1124	1124
q9	7148	5160	5170	5160
q10	6904	2383	1969	1969
q11	497	291	280	280
q12	355	360	217	217
q13	17775	3689	3230	3230
q14	237	225	210	210
q15	552	488	475	475
q16	416	411	376	376
q17	598	896	354	354
q18	7566	7253	7140	7140
q19	1213	960	560	560
q20	323	351	209	209
q21	3678	3128	2368	2368
q22	361	321	309	309
Total cold run time: 106068 ms
Total hot run time: 33573 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5140	5153	5096	5096
q2	245	325	219	219
q3	2158	2702	2266	2266
q4	1361	1797	1376	1376
q5	4281	4328	4560	4328
q6	215	170	124	124
q7	2017	1983	1863	1863
q8	2677	2566	2537	2537
q9	7415	7244	7338	7244
q10	3121	3307	2908	2908
q11	621	520	514	514
q12	728	770	615	615
q13	3761	3915	3288	3288
q14	277	310	405	310
q15	548	481	481	481
q16	438	504	446	446
q17	1188	1596	1325	1325
q18	8023	7699	7675	7675
q19	850	972	1152	972
q20	2042	2038	1874	1874
q21	4766	4353	4322	4322
q22	624	596	569	569
Total cold run time: 52496 ms
Total hot run time: 50352 ms

doris-robot · 2025-07-10T03:15:33Z

TPC-DS: Total hot run time: 185797 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5db42d63ca64a91dcb11a13016b629aeac2cc6d9, data reload: false
query1	1020	385	395	385
query2	6515	1762	1795	1762
query3	6744	213	221	213
query4	25988	23664	22966	22966
query5	4312	560	420	420
query6	287	208	204	204
query7	4618	488	290	290
query8	287	230	212	212
query9	8606	2629	2640	2629
query10	453	335	266	266
query11	15557	15182	14779	14779
query12	156	104	100	100
query13	1632	523	390	390
query14	8635	5827	5906	5827
query15	206	195	179	179
query16	7235	438	274	274
query17	1312	684	578	578
query18	1978	382	297	297
query19	183	176	153	153
query20	119	122	130	122
query21	224	129	100	100
query22	4243	4267	4132	4132
query23	33820	33190	33093	33093
query24	8421	2325	2367	2325
query25	534	490	389	389
query26	1215	263	146	146
query27	2765	498	368	368
query28	4351	2132	2117	2117
query29	779	555	447	447
query30	282	218	196	196
query31	874	833	776	776
query32	69	62	58	58
query33	538	330	277	277
query34	788	837	515	515
query35	589	637	571	571
query36	945	971	861	861
query37	115	99	75	75
query38	4260	4149	4124	4124
query39	1457	1405	1386	1386
query40	212	116	102	102
query41	55	54	51	51
query42	124	108	106	106
query43	503	509	471	471
query44	1301	818	812	812
query45	178	173	164	164
query46	836	1046	622	622
query47	1736	1762	1725	1725
query48	375	405	302	302
query49	727	510	413	413
query50	639	683	422	422
query51	4248	4237	4168	4168
query52	110	106	99	99
query53	223	262	189	189
query54	593	581	506	506
query55	85	89	87	87
query56	311	301	318	301
query57	1197	1175	1123	1123
query58	273	260	291	260
query59	2723	2848	2685	2685
query60	338	325	310	310
query61	127	117	123	117
query62	778	717	668	668
query63	217	186	187	186
query64	4470	1203	805	805
query65	4288	4190	4222	4190
query66	1137	415	318	318
query67	15870	15654	15336	15336
query68	7801	877	528	528
query69	540	340	267	267
query70	1144	1115	1097	1097
query71	411	329	296	296
query72	5612	4615	4653	4615
query73	654	570	351	351
query74	8890	9084	8899	8899
query75	3202	3172	2727	2727
query76	3192	1142	731	731
query77	476	369	287	287
query78	10778	11064	10360	10360
query79	1238	820	591	591
query80	580	521	500	500
query81	461	258	217	217
query82	185	123	100	100
query83	252	249	228	228
query84	245	109	87	87
query85	743	355	310	310
query86	318	296	287	287
query87	4395	4438	4361	4361
query88	2928	2305	2300	2300
query89	375	317	281	281
query90	1910	217	213	213
query91	139	142	110	110
query92	61	60	54	54
query93	1010	955	587	587
query94	655	309	198	198
query95	378	295	287	287
query96	497	567	277	277
query97	2722	2772	2641	2641
query98	232	204	202	202
query99	1325	1397	1268	1268
Total cold run time: 269135 ms
Total hot run time: 185797 ms

doris-robot · 2025-07-10T03:20:50Z

ClickBench: Total hot run time: 29.59 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5db42d63ca64a91dcb11a13016b629aeac2cc6d9, data reload: false
query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.25	0.08	0.07
query4	1.62	0.10	0.11
query5	0.44	0.42	0.43
query6	1.18	0.68	0.67
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.50	0.52
query10	0.57	0.55	0.57
query11	0.16	0.11	0.11
query12	0.14	0.12	0.11
query13	0.63	0.61	0.62
query14	0.80	0.80	0.82
query15	0.91	0.88	0.86
query16	0.38	0.40	0.40
query17	1.01	1.06	1.06
query18	0.23	0.21	0.20
query19	2.00	1.86	1.80
query20	0.01	0.02	0.01
query21	15.40	0.89	0.56
query22	0.75	1.15	0.61
query23	15.02	1.37	0.66
query24	7.29	1.54	0.94
query25	0.48	0.26	0.06
query26	0.54	0.16	0.14
query27	0.06	0.05	0.05
query28	9.80	0.91	0.43
query29	12.59	3.94	3.31
query30	0.25	0.09	0.06
query31	2.83	0.60	0.39
query32	3.24	0.56	0.49
query33	3.04	3.11	3.12
query34	16.07	5.37	4.77
query35	4.83	4.84	4.78
query36	0.68	0.50	0.48
query37	0.09	0.07	0.07
query38	0.06	0.05	0.04
query39	0.03	0.03	0.03
query40	0.16	0.14	0.14
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.47 s
Total hot run time: 29.59 s

doris-robot · 2025-07-10T07:02:58Z

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.00% (15498/27189)
Line Coverage	45.86% (138270/301536)
Region Coverage	35.31% (103395/292810)
Branch Coverage	37.77% (45497/120468)

…rflow error (#53018) ### What problem does this PR solve? Problem Summary: ``` ==2403213==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x506001097220 at pc 0x55837edd7fe9 bp 0x7f7efe2dc830 sp 0x7f7efe2dbff8 READ of size 63 at 0x506001097220 thread T1262 (brpc_light) #0 0x55837edd7fe8 in strlen (/mnt/disk8/zhangsida/doris/output/be/lib/doris_be+0x2c8d7fe8) (BuildId: 5acbe48773972a88) #1 0x5583bd3ff969 in fmt::v7::detail::buffer_appender<char> fmt::v7::detail::write<char, fmt::v7::detail::buffer_appender<char>>(fmt::v7::detail::buffer_appender<char>, char const*) (/mnt/disk8/zhangsida/doris/output/be/lib/doris_be+0x6aeff969) (BuildId: 5acbe48773972a88) #2 0x5583bd41640e in char const* fmt::v7::detail::parse_replacement_field<char, fmt::v7::detail::format_handler<fmt::v7::detail::buffer_appender<char>, char, fmt::v7::basic_format_context<fmt::v7::detail::buffer_appender<char>, char>>&>(char const*, char const*, fmt::v7::detail::format_handler<fmt::v7::detail::buffer_appender<char>, char, fmt::v7::basic_format_context<fmt::v7::detail::buffer_appender<char>, char>>&) (/mnt/disk8/zhangsida/doris/output/be/lib/doris_be+0x6af1640e) (BuildId: 5acbe48773972a88) #3 0x5583bd416c7f in void fmt::v7::detail::vformat_to<char>(fmt::v7::detail::buffer<char>&, fmt::v7::basic_string_view<char>, fmt::v7::basic_format_args<fmt::v7::basic_format_context<fmt::v7::detail::buffer_appender<fmt::v7::type_identity<char>::type>, fmt::v7::type_identity<char>::type>>, fmt::v7::detail::locale_ref) (/mnt/disk8/zhangsida/doris/output/be/lib/doris_be+0x6af16c7f) (BuildId: 5acbe48773972a88) #4 0x5583bd3f74aa in fmt::v7::detail::vformat[abi:cxx11](fmt::v7::basic_string_view<char>, fmt::v7::format_args) (/mnt/disk8/zhangsida/doris/output/be/lib/doris_be+0x6aef74aa) (BuildId: 5acbe48773972a88) #5 0x5583a6b4d3bb in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> fmt::v7::format<char [45], char const*&, char>(char const (&) [45], char const*&) /mnt/disk8/zhangsida/doris/thirdparty/installed/include/fmt/core.h:2076:10 #6 0x5583a6b4d3bb in doris::vectorized::BitmapFromBase64::vector(doris::vectorized::PODArray<unsigned char, 4096ul, doris::Allocator<false, false, false, doris::NoTrackingDefaultMemoryAllocator>, 16ul, 15ul> const&, doris::vectorized::PODArray<unsigned int, 4096ul, doris::Allocator<false, false, false, doris::NoTrackingDefaultMemoryAllocator>, 16ul, 15ul> const&, std::vector<doris::BitmapValue, std::allocator<doris::BitmapValue>>&, doris::vectorized::PODArray<unsigned char, 4096ul, doris::Allocator<false, false, false, doris::NoTrackingDefaultMemoryAllocator>, 16ul, 15ul>&, unsigned long) /mnt/disk8/zhangsida/doris/be/src/vec/functions/function_bitmap.cpp:310:29 #7 0x5583a6b4b93b in doris::vectorized::FunctionBitmapAlwaysNull<doris::vectorized::BitmapFromBase64>::execute_impl(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long) const /mnt/disk8/zhangsida/doris/be/src/vec/functions/function_bitmap.cpp:381:13 #8 0x5583a02062ef in doris::vectorized::DefaultExecutable::execute_impl(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long) const /mnt/disk8/zhangsida/doris/be/src/vec/functions/function.h:459:26 #9 0x5583a49d77e3 in doris::vectorized::PreparedFunctionImpl::_execute_skipped_constant_deal(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long, bool) const /mnt/disk8/zhangsida/doris/be/src/vec/functions/function.cpp #10 0x5583a49d0bf8 in doris::vectorized::PreparedFunctionImpl::default_implementation_for_constant_arguments(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long, bool, bool*) const /mnt/disk8/zhangsida/doris/be/src/vec/functions/function.cpp:168:5 #11 0x5583a49d3324 in doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long, bool) const /mnt/disk8/zhangsida/doris/be/src/vec/functions/function.cpp:237:5 ```

…p-buffer-overflow error #53018 (#53044) Cherry-picked from #53018 Co-authored-by: zhangstar333 <zhangsida@selectdb.com>

…p-buffer-overflow error #53018 (#53043) Cherry-picked from #53018 Co-authored-by: zhangstar333 <zhangsida@selectdb.com>

…p-buffer-overflow error #53018 (#53045) Cherry-picked from #53018 Co-authored-by: zhangstar333 <zhangsida@selectdb.com>

[Bug](function) fix bitmap_from_base64 function cause heap-buffer-ove…
1e1d745
…rflow error

zhangstar333 force-pushed the fix_bitmap_heap_error branch from a902bfc to 1e1d745Compare July 9, 2025 13:09

yiguolei reviewed Jul 10, 2025
View reviewed changes

Comment threadbe/src/vec/functions/function_bitmap.cpp

yiguolei reviewed Jul 10, 2025
View reviewed changes

Comment threadbe/src/vec/functions/function_bitmap.cpp Outdated

update
5db42d6

zclllyybb approved these changes Jul 10, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 10, 2025

github-actionsBot added the reviewed label Jul 10, 2025

yiguolei approved these changes Jul 10, 2025
View reviewed changes

yiguolei added dev/2.1.x dev/3.0.x dev/3.1.x labels Jul 10, 2025

yiguolei merged commit 21e133d into apache:masterJul 10, 2025

github-actionsBot mentioned this pull request Jul 10, 2025
branch-3.0: [Bug](function) fix bitmap_from_base64 function cause heap-buffer-overflow error #53018 #53043
Merged

github-actionsBot mentioned this pull request Jul 10, 2025
branch-2.1: [Bug](function) fix bitmap_from_base64 function cause heap-buffer-overflow error #53018 #53044
Merged

github-actionsBot mentioned this pull request Jul 10, 2025
branch-3.1: [Bug](function) fix bitmap_from_base64 function cause heap-buffer-overflow error #53018 #53045
Merged

yiguolei pushed a commit that referenced this pull request Jul 10, 2025
branch-2.1: [Bug](function) fix bitmap_from_base64 function cause hea…
2f7c15f
…p-buffer-overflow error #53018 (#53044) Cherry-picked from #53018 Co-authored-by: zhangstar333 <zhangsida@selectdb.com>

yiguolei added dev/2.1.11-merged and removed dev/2.1.x labels Jul 10, 2025

dataroaring pushed a commit that referenced this pull request Jul 11, 2025
branch-3.0: [Bug](function) fix bitmap_from_base64 function cause hea…
1af1dcb
…p-buffer-overflow error #53018 (#53043) Cherry-picked from #53018 Co-authored-by: zhangstar333 <zhangsida@selectdb.com>

dataroaring added dev/3.0.7-merged and removed dev/3.0.x labels Jul 11, 2025

morrySnow pushed a commit that referenced this pull request Jul 11, 2025
branch-3.1: [Bug](function) fix bitmap_from_base64 function cause hea…
7087986
…p-buffer-overflow error #53018 (#53045) Cherry-picked from #53018 Co-authored-by: zhangstar333 <zhangsida@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Jul 11, 2025

yiguolei mentioned this pull request Aug 11, 2025
2.1.11 Release Notes #54550
Closed

gavinchou mentioned this pull request Aug 15, 2025
Release Note 3.0.7 #54868
Closed

Uh oh!

Conversation

zhangstar333 commented Jul 9, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jul 9, 2025

Uh oh!

zhangstar333 commented Jul 9, 2025

Uh oh!

doris-robot commented Jul 9, 2025

Uh oh!

doris-robot commented Jul 9, 2025

Uh oh!

doris-robot commented Jul 9, 2025

Uh oh!

hello-stephen commented Jul 9, 2025

BE UT Coverage Report

Uh oh!

Uh oh!

Uh oh!

zhangstar333 commented Jul 10, 2025

Uh oh!

github-actionsBot commented Jul 10, 2025

Uh oh!

github-actionsBot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

BE UT Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants