Skip to content

[fix](recycler) Fix two errors for recycler - #53042

Merged
dataroaring merged 1 commit into
apache:masterfrom
swjtu-zhanglei:master-fix12
Jul 14, 2025
Merged

[fix](recycler) Fix two errors for recycler#53042
dataroaring merged 1 commit into
apache:masterfrom
swjtu-zhanglei:master-fix12

Conversation

@swjtu-zhanglei

@swjtu-zhangleiswjtu-zhanglei commented Jul 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

  • Fix not catch exception for azure AzureListIterator

  • Make AWS::InitAPI and Aws::ShutdownAPI called both in main thread

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei

swjtu-zhanglei commented Jul 10, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@swjtu-zhanglei
[fix](recycler) Fix two errors for recycler
94348a4
* Fix not catch exception for azure AzureListIterator
* Make `AWS::InitAPI` and `Aws::ShutdownAPI` called both in main thread
@swjtu-zhanglei

swjtu-zhanglei commented Jul 10, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jul 10, 2025

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 48.98% (24/49) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage80.62% (1256/1558)
Line Coverage67.76% (21419/31609)
Region Coverage67.25% (10610/15777)
Branch Coverage56.74% (5566/9810)

@github-actions

github-actionsBot commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 10, 2025
@github-actions

github-actionsBot commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jul 14, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gavinchou
gavinchou reviewed Jul 14, 2025
View reviewed changes
Comment threadcloud/src/recycler/s3_accessor.cpp
std::make_shared<SimpleThreadPool>(config::recycle_pool_parallelism, "s3_accessor");
worker_pool->start();
});
S3Environment::getInstance();

@gavinchougavinchouJul 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this call seems confusing and meaningless

@swjtu-zhangleiswjtu-zhangleiJul 14, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this call seems confusing and meaningless

image just a refact, don't change the original logicality

@dataroaring
dataroaring merged commit a9e7311 into apache:masterJul 14, 2025
github-actionsBot pushed a commit that referenced this pull request Jul 14, 2025
@swjtu-zhangleiYour Name
[fix](recycler) Fix two errors for recycler (#53042)
bf1b74d
* Fix not catch exception for azure AzureListIterator
* Make `AWS::InitAPI` and `Aws::ShutdownAPI` called both in main thread
@github-actionsgithub-actionsBot mentioned this pull request Jul 14, 2025
Merged
github-actionsBot pushed a commit that referenced this pull request Jul 14, 2025
@swjtu-zhangleiYour Name
[fix](recycler) Fix two errors for recycler (#53042)
f1b26da
* Fix not catch exception for azure AzureListIterator
* Make `AWS::InitAPI` and `Aws::ShutdownAPI` called both in main thread
@github-actionsgithub-actionsBot mentioned this pull request Jul 14, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jul 15, 2025
@github-actions@swjtu-zhanglei
branch-3.0: [fix](recycler) Fix two errors for recycler#53042(#53224)
5e63953
Cherry-picked from #53042
Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
morrySnow pushed a commit that referenced this pull request Jul 15, 2025
@github-actions@swjtu-zhanglei
branch-3.1: [fix](recycler) Fix two errors for recycler#53042(#53225)
427604f
Cherry-picked from #53042
Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
@gavinchougavinchou mentioned this pull request Aug 15, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou left review comments
@hello-stephenhello-stephenhello-stephen approved these changes
@dataroaringdataroaringdataroaring approved these changes
@w41terw41terAwaiting requested review from w41ter

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.7-mergeddev/3.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@swjtu-zhanglei@Thearas@doris-robot@gavinchou@hello-stephen@dataroaring@morrySnow